On Thu, Mar 18, 2010 at 10:32:36PM +0200, Blue Swirl wrote: > The patch does not apply to current development repository. > > There is no description of the change suitable for changelog without > any editing. > > Signed-off-by: line is missing. > > The patch combines formatting (whitespace) changes with functional > changes. The formatting changes seem useless. > > The essence of the patch is twofold, It adds NetBSD specific includes > and NetBSD specific code to raw_getlength(). These look OK, except > formatting may be a bit off (no space after if) and currently the code > probably should be surrounded by > #ifdef DIOCGWEDGEINFO > #endif > or just #ifdef __NetBSD__.
Also given the extreme mess that raw_getlength is I would much prefer to give every new OS it's own copy of it, similar to how we already handle OpenBSD today.
