Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-27 Thread Shahar Havivi
On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: > Date: Fri, 26 Feb 2010 15:19:19 -0700 > From: "David S. Ahern" > To: Shahar Havivi > CC: qemu-devel@nongnu.org, Dor Laor > Subject: Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based > monitor > > > > > > On

[Qemu-devel] Re: [PATCH v2 0/2] Catch attempt to attach more than one device to a netdev

2010-02-27 Thread Juan Quintela
Markus Armbruster wrote: > Markus Armbruster (2): > qdev: Improve diagnostics for bad property values > qdev: Catch attempt to attach more than one device to a netdev > > hw/qdev-properties.c | 64 > -- > net.c|1 + > 2 fi

[Qemu-devel] [PATCH] Fix qemu -net user,hostfwd= example

2010-02-27 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- qemu-options.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index f53922f..7daa246 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1029,7 +1029,7 @@ the guest, use the following: @example

[Qemu-devel] How to precisely monitor all the memory references in QEMU to feed the cache model

2010-02-27 Thread shocklink99
Hi, I'm adding a cache model into QEMU 0.12 I have encountered a problem that the cache miss error rate was high compared to real platform Creator(arm926) . I used the QEMU integrator board to run the experiment. I've modified softmmu_header.h softmmu_template.h target-arm/translate.c e.g. in sof

Re: [Qemu-devel] How to precisely monitor all the memory references in QEMU to feed the cache model

2010-02-27 Thread Blue Swirl
On 2/27/10, shocklin...@yahoo.com.tw wrote: > Hi, > I'm adding a cache model into QEMU 0.12 > I have encountered a problem that the cache miss error rate was high > compared to real platform Creator(arm926) . > I used the QEMU integrator board to run the experiment. > I've modified > softmmu_hea

[Qemu-devel] Re: KVM usability

2010-02-27 Thread Jan Kiszka
[ adding qemu-devel to CC as most issues concern that project as well ] Ingo Molnar wrote: > * Avi Kivity wrote: > >> On 02/26/2010 01:17 PM, Ingo Molnar wrote: >>> Nobody is really 'in charge' of how KVM gets delivered to the user. You >>> isolated the fun kernel part for you and pushed out the

Re: [Qemu-devel] Re: Re: [PATCH] Fix to 'gdb detach' stub

2010-02-27 Thread Aurelien Jarno
On Fri, Feb 26, 2010 at 02:13:50PM -0300, Daniel Gutson wrote: > Hello Kevin, > please let me know if this works. > If so, please remember that I'd need somebody to commit this for me, since I > don't have write-access. > > Undoing line wrap and tabs. Thanks applied. > Thanks! > Dan

Re: [Qemu-devel] [PATCH] Fix 'make install' from non-srcdir build

2010-02-27 Thread Aurelien Jarno
On Fri, Feb 26, 2010 at 02:00:28PM +0530, Amit Shah wrote: > Commit b5ec5ce0 broke 'make install' from non source-dir build. Fix. > > Signed-off-by: Amit Shah Thanks, applied. > --- > Makefile |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile >

Re: [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets)

2010-02-27 Thread Aurelien Jarno
On Tue, Feb 23, 2010 at 10:32:23PM +0100, Stefan Weil wrote: > Compilation of m68k-softmmu or m68k-linux-user on arm host > (or cross compilation for arm) results in a linker warning: > > LINK m68k-softmmu/qemu-system-m68k > m68k-dis.o: warning: definition of `floatformat_ieee_single_little' >

Re: [Qemu-devel] [PATCH] target-ppc: fix SPE evcmp* instructions

2010-02-27 Thread Aurelien Jarno
On Tue, Feb 23, 2010 at 11:55:14AM -0800, Nathan Froyd wrote: > The CRF_{CH,CL,CH_OR_CL,CH_AND_CL} constants were all off by one bit > position. Because of this, the SPE evcmp* family of instructions would > store values in the result condition register that were also off by one > bit position. >

Re: [Qemu-devel] [PATCH] target-ppc: fix SPE evsplat* instructions

2010-02-27 Thread Aurelien Jarno
On Tue, Feb 23, 2010 at 12:21:31PM -0800, Nathan Froyd wrote: > The shifts in the gen_evsplat* functions were expecting rA to be masked, > not extracted, and so used the wrong shift amounts to sign-extend or pad > with zeroes. > > Signed-off-by: Nathan Froyd Thanks, applied. > --- > target-ppc

Re: [Qemu-devel] [PATCH] sh4: Fix gdb read/write register

2010-02-27 Thread Aurelien Jarno
On Thu, Feb 18, 2010 at 12:53:29AM +0900, takas...@ops.dti.ne.jp wrote: > cpu_gdb_read_register(): Fix n={8...15} case. > cpu_gdb_write_register(): Fix n={8...15} case and runaway "case:". > > Signed-off-by: Takashi YOSHII Thanks, applied. > --- > gdbstub.c | 27 ++- >

Re: [Qemu-devel] [PATCH] kvm/booke: Add synchronize register for booke init

2010-02-27 Thread Aurelien Jarno
On Wed, Jan 27, 2010 at 02:14:09PM +0800, Liu Yu wrote: > So that the following registers init could be flushed back to kvm. > > Signed-off-by: Liu Yu Thanks, applied. > --- > hw/ppc440_bamboo.c |2 ++ > hw/ppce500_mpc8544ds.c |2 ++ > 2 files changed, 4 insertions(+), 0 deletions(

Re: [Qemu-devel] [PATCH 1/2] powerpc/booke: move fdt loading to rom infrastructure

2010-02-27 Thread Aurelien Jarno
On Tue, Feb 02, 2010 at 04:49:02PM +0800, Liu Yu wrote: > It's convinent to use rom to checking overlap, to reset etc. > And uImage and ramdisk loading has already moved to it. > > Also, after we add fdt to rom, free it. This does not build if CONFIG_FDT is not set: |  CCppc-softmmu/ppc440_

Re: [Qemu-devel] [PATCH] Restore terminal attributes for tty based monitor

2010-02-27 Thread David S. Ahern
On 02/27/2010 01:41 AM, Shahar Havivi wrote: > On Fri, Feb 26, 2010 at 03:19:19PM -0700, David S. Ahern wrote: >> Date: Fri, 26 Feb 2010 15:19:19 -0700 >> From: "David S. Ahern" >> To: Shahar Havivi >> CC: qemu-devel@nongnu.org, Dor Laor >> Subject: Re: [Qemu-devel] [PATCH] Restore terminal

Re: [Qemu-devel] [PATCH 1/2] powerpc/booke: move fdt loading to rom infrastructure

2010-02-27 Thread Aurelien Jarno
On Sat, Feb 27, 2010 at 04:33:02PM +0100, Aurelien Jarno wrote: > On Tue, Feb 02, 2010 at 04:49:02PM +0800, Liu Yu wrote: > > It's convinent to use rom to checking overlap, to reset etc. > > And uImage and ramdisk loading has already moved to it. > > > > Also, after we add fdt to rom, free it. >

Re: [Qemu-devel] [FOR 0.12 PATCH] fix undefined shifts by >32

2010-02-27 Thread Aurelien Jarno
I have actually cherry-picked the commit from HEAD. On Thu, Jan 28, 2010 at 11:04:54AM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > vl.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index 5e8c775..d9f1ccb 100644 > --- a/vl.

[Qemu-devel] Re: [PATCHv2 09/12] vhost: vhost net support

2010-02-27 Thread Michael S. Tsirkin
On Fri, Feb 26, 2010 at 09:18:03AM -0600, Anthony Liguori wrote: > On 02/26/2010 08:49 AM, Michael S. Tsirkin wrote: >> >> KVM code needs all kind of work-arounds for KVM specific issues. >> It also assumes that KVM is registered at startup, so it >> does not try to optimize finding slots. >> >

[Qemu-devel] Re: [PATCHv2 10/12] tap: add vhost/vhostfd options

2010-02-27 Thread Michael S. Tsirkin
On Fri, Feb 26, 2010 at 09:23:01AM -0600, Anthony Liguori wrote: > On 02/26/2010 08:51 AM, Michael S. Tsirkin wrote: >> On Thu, Feb 25, 2010 at 01:47:27PM -0600, Anthony Liguori wrote: >> >>> On 02/25/2010 12:28 PM, Michael S. Tsirkin wrote: >>> This adds vhost binary option to tap,

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-27 Thread Paul Brook
>diff --git a/qemu-lock.h b/qemu-lock.h This code isn't used in any interesting ways, it should be removed.. Paul

Re: [Qemu-devel] [PATCH] pc: madvise(MADV_DONTNEED) memory on reset

2010-02-27 Thread Paul Brook
> > I think it would be much cleaner to make the madvise() calls from > > exec.c, now you are duplicating some of the functionality there. The > > calls could be controlled by a global variable (set only in pc.c) so > > non-PC architectures would not be disturbed. > > One thing we could do (that I

Re: [Qemu-devel] [patch uq/master 2/2] Add option to use file backed guest memory

2010-02-27 Thread Paul Brook
>+/* >+ * ftruncate is not supported by hugetlbfs in older >+ * hosts, so don't bother checking for errors. >+ * If anything goes wrong with it under other filesystems, >+ * mmap will fail. >+ */ >+if (ftruncate(fd, memory)) >+ perror("ftruncate"); Code does not m

Re: [Qemu-devel] [PATCH 4/4] kbd keds: vnc

2010-02-27 Thread Paul Brook
> Use led status notification support in vnc. > > The qemu vnc server keeps track of the capslock and numlock states based > on the key presses it receives from the vnc client. But this fails in > case the guests idea of the capslock and numlock state changes for other > reasons. One case is gue

Re: [Qemu-devel] Re: [PATCH] scsi: Make device scsi-disk reject /dev/sg*

2010-02-27 Thread Paul Brook
> On 02/25/10 11:23, Markus Armbruster wrote: > > You're supposed to use scsi-generic for that. Which rejects anything > > but /dev/sg*. > > Well, it isn't *that* easy. The SG_IO ioctl used by scsi-generic works > on tons of devices in linux, not only /dev/sg*. I've seen patches > floading arou

Re: [Qemu-devel] Re: [PATCHv2 09/12] vhost: vhost net support

2010-02-27 Thread Paul Brook
> > I'm pretty sure a guest can cause those to change and I'm not 100% > > sure, but I think it's a potential source of exploits if you assume a > > mapping. In the very least, a guest can trick vhost into writing to ram > > that it wouldn't normally write to. > > This seems harmless. guest can