> > I think it would be much cleaner to make the madvise() calls from > > exec.c, now you are duplicating some of the functionality there. The > > calls could be controlled by a global variable (set only in pc.c) so > > non-PC architectures would not be disturbed. > > One thing we could do (that I think has other uses) is to add a context > parameter to qemu_ram_alloc(). We could start with a simple flag of > something like QRAM_RAM and QRAM_ROM. QRAM_RAM would get automatically > madvise()'d on reset. > > But that said, does anyone know of an architecture where this type of > reset would be a problem? Would it be a problem on sparc?
I think it's simplest to just say that qemu_system_reset is a full hard reset. We already reload ROM images, etc. Paul
