Re: [Qemu-devel] [PATCH 01/15] pci: add new bus functions

2010-02-10 Thread Isaku Yamahata
On Tue, Feb 09, 2010 at 04:01:25PM -0600, Anthony Liguori wrote: > - mapping and managing io regions > - reading and writing physical memory > > Signed-off-by: Anthony Liguori > --- > hw/pci.c | 172 > +++--- > hw/pci.h | 18 ++- >

Re: [Qemu-devel] [PATCH v1 0/4]: QMP related fixes

2010-02-10 Thread Markus Armbruster
Luiz Capitulino writes: > Should be applied on top of feature negotiation series. > > changelog: > -- > > v0 -> v1: > > - Document qobject_from_jsonf() new semantics Looks good.

[Qemu-devel] Re: [PATCH 01/15] pci: add new bus functions

2010-02-10 Thread Michael S. Tsirkin
On Tue, Feb 09, 2010 at 04:01:25PM -0600, Anthony Liguori wrote: > - mapping and managing io regions > - reading and writing physical memory > > Signed-off-by: Anthony Liguori One thing I'm concerned with here is that this adds another level of indirection on datapath operations. Note that rwh

[Qemu-devel] Re: [PATCH 0/15][RFC] New PCI interfaces

2010-02-10 Thread Michael S. Tsirkin
On Tue, Feb 09, 2010 at 04:01:24PM -0600, Anthony Liguori wrote: > This is a work in progress that I wanted to share giving some of the > discussions > around rwhandlers. The idea is to make PCI devices have a common set of > functions to interact with the CPU that is driven entirely through the

[Qemu-devel] Re: [PATCH] pci: introduce get_dev_dict callback.

2010-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2010 at 03:59:30PM +0900, Isaku Yamahata wrote: > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5 Could you please clarify what exactly is the bug, and how this patch fixes it? > by introducing device specific get_dev_dict callback. > pci host bridge doesn't always have

[Qemu-devel] Re: [PATCH 09/15] eepro100: convert to new pci interface

2010-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2010 at 07:32:10AM +0100, Stefan Weil wrote: > See my inline comments. > > > Anthony Liguori schrieb: > > - Removed some dead defines for TARGET_I386 so that we could build once > > > > Signed-off-by: Anthony Liguori > > --- > > hw/eepro100.c | 238 > > ++-

[Qemu-devel] Re: [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread OHMURA Kei
> Please reuse the changelog when reposing a patch, this makes it easier > for me to apply it. Thanks. Will follow it from next time. > Should be a host long size, not guest. This will fail when running a > 32-bit qemu-system-x86_64 binary. Sorry. That was our mistake. > Instead of using a n

Re: [Qemu-devel] qemu 0.12.x / -git PS/2 mouse not working under Win3.11 / Win9x

2010-02-10 Thread Klaus Rechert
Hi, I know from myself that in 0.9.x it worked so you should start testing older versions until it works and then test each commit to the ps2 emulator onward that. Win3.11 worked well with 0.11.x releases, while win9x crashed when switching to VGA (IIRC). 0.10.x worked well for both. Che

[Qemu-devel] Re: [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Avi Kivity
On 02/10/2010 11:55 AM, OHMURA Kei wrote: > >> Instead of using a nested loop if bitmap_ul[i] != 0, it is possible to >> use just a single loop (while (c> 0)), and process a long's worth of data. >> >> The only trickery is with big endian hosts, where the conversion from >> bit number to page numb

Re: [Qemu-devel] Re: [PATCH 09/15] eepro100: convert to new pci interface

2010-02-10 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Feb 10, 2010 at 07:32:10AM +0100, Stefan Weil wrote: >> See my inline comments. >> >> >> Anthony Liguori schrieb: [...] >> > -static void pci_map(PCIDevice * pci_dev, int region_num, >> > -pcibus_t addr, pcibus_t size, int type) >> > +s

Re: [Qemu-devel] Re: [PATCH 09/15] eepro100: convert to new pci interface

2010-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2010 at 11:43:29AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Feb 10, 2010 at 07:32:10AM +0100, Stefan Weil wrote: > >> See my inline comments. > >> > >> > >> Anthony Liguori schrieb: > [...] > >> > -static void pci_map(PCIDevice * pci_dev, int

[Qemu-devel] [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread OHMURA Kei
dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. But We think that dirty-bitmap-traveling by long size is faster than by byte size especially when most of memory is not dirty. Signed-off-by: OHMURA Kei --- bswap.h|1 - qemu-kvm.c | 30 -- 2

Re: [Qemu-devel] [PATCH] alpha-linux-user: Implement signals.

2010-02-10 Thread Riku Voipio
On Tue, Feb 09, 2010 at 10:46:32AM -0800, Richard Henderson wrote: > Ping? The linux-user side of the patch seems fine, but the target-alpha code doesn't apply. Either something has changed upstream or this depends on one of your other alpha patches. If the latter case, I don't mind if this is app

Re: [Qemu-devel] [PATCH] block: saner flags filtering in bdrv_open2

2010-02-10 Thread Christoph Hellwig
ping? On Thu, Jan 28, 2010 at 03:19:12PM +0100, Christoph Hellwig wrote: > Clean up the current mess about figuring out which flags to pass to the > driver. BDRV_O_FILE, BDRV_O_SNAPSHOT and BDRV_O_NO_BACKING are flags > only used by the block layer internally so filter them out directly. > Previo

[Qemu-devel] [PATCH] virtio-spec: document indirect descriptors

2010-02-10 Thread Michael S. Tsirkin
Add documentation for indirect descriptors Signed-off-by: Michael S. Tsirkin --- virtio-spec.lyx | 118 +-- 1 files changed, 114 insertions(+), 4 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 8062e11..b5a8fbd 100644 --- a/

[Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Avi Kivity
On 02/10/2010 12:52 PM, OHMURA Kei wrote: > dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. > But We think that dirty-bitmap-traveling by long size is faster than by byte > size especially when most of memory is not dirty. > > --- a/bswap.h > +++ b/bswap.h > @@ -209,7 +209,6 @@ st

Re: [Qemu-devel] [PATCH 09/15] eepro100: convert to new pci interface

2010-02-10 Thread Anthony Liguori
On 02/10/2010 12:32 AM, Stefan Weil wrote: See my inline comments. Anthony Liguori schrieb: - Removed some dead defines for TARGET_I386 so that we could build once Signed-off-by: Anthony Liguori --- hw/eepro100.c | 238 ++--- 1 fil

[Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/10/2010 02:52 AM, OHMURA Kei wrote: > for (i = 0; i < len; i++) { > -c = bitmap[i]; > -while (c > 0) { > -j = ffsl(c) - 1; > -c &= ~(1u << j); > -page_number = i * 8 + j; > -ad

[Qemu-devel] Training request

2010-02-10 Thread Jean-Christophe Voisin
French version at the end of mail. Please excuse our English. Hello, We are two apprentice in the last year of our training as engineers. We would like to offer our services for the development of qemu. We have 256 hours of school project to accompling, helped by a teacher and researcher at ESEO

[Qemu-devel] Re: [PATCH] pci: introduce get_dev_dict callback.

2010-02-10 Thread Isaku Yamahata
On Wed, Feb 10, 2010 at 11:45:48AM +0200, Michael S. Tsirkin wrote: > On Wed, Feb 10, 2010 at 03:59:30PM +0900, Isaku Yamahata wrote: > > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5 > > Could you please clarify what exactly is the bug, > and how this patch fixes it? How about the fo

[Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Anthony Liguori
On 02/10/2010 07:20 AM, Avi Kivity wrote: > On 02/10/2010 12:52 PM, OHMURA Kei wrote: > >> dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. >> But We think that dirty-bitmap-traveling by long size is faster than by byte >> size especially when most of memory is not dirty. >> >>

[Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Anthony Liguori
On 02/10/2010 07:20 AM, Avi Kivity wrote: > On 02/10/2010 12:52 PM, OHMURA Kei wrote: > >> dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. >> But We think that dirty-bitmap-traveling by long size is faster than by byte >> size especially when most of memory is not dirty. >> >>

[Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Avi Kivity
On 02/10/2010 05:54 PM, Anthony Liguori wrote: > On 02/10/2010 07:20 AM, Avi Kivity wrote: > >> On 02/10/2010 12:52 PM, OHMURA Kei wrote: >> >> >>> dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. >>> But We think that dirty-bitmap-traveling by long size is faster than b

Re: [Qemu-devel] Training request

2010-02-10 Thread Alexander Graf
Hi Jean-Christophe, Jean-Christophe Voisin wrote: > French version at the end of mail. > Please excuse our English. > > Hello, > > We are two apprentice in the last year of our training as engineers. > We would like to offer our services for the development of qemu. We > have 256 hours of school

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Alexander Graf
Anthony Liguori wrote: > On 02/10/2010 07:20 AM, Avi Kivity wrote: > >> On 02/10/2010 12:52 PM, OHMURA Kei wrote: >> >> >>> dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. >>> But We think that dirty-bitmap-traveling by long size is faster than by byte >>> size especial

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Anthony Liguori
On 02/10/2010 10:00 AM, Alexander Graf wrote: > On PPC the bitmap is Little Endian. > Out of curiousity, why? It seems like an odd interface. Regards, Anthony Liguori

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Alexander Graf
Anthony Liguori wrote: > On 02/10/2010 10:00 AM, Alexander Graf wrote: > >> On PPC the bitmap is Little Endian. >> >> > > Out of curiousity, why? It seems like an odd interface. > Because on PPC, you usually run PPC32 userspace code on a PPC64 kernel. Unlike with x86, there's no real

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Avi Kivity
On 02/10/2010 06:35 PM, Anthony Liguori wrote: > On 02/10/2010 10:00 AM, Alexander Graf wrote: > >> On PPC the bitmap is Little Endian. >> >> > Out of curiousity, why? It seems like an odd interface. > > Exactly this issue. If you specify it as unsigned long native endian, there is a

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Avi Kivity
On 02/10/2010 06:43 PM, Alexander Graf wrote: > >> Out of curiousity, why? It seems like an odd interface. >> >> > Because on PPC, you usually run PPC32 userspace code on a PPC64 kernel. > Unlike with x86, there's no real benefit in using 64 bit userspace. > btw, does 32-bit ppc qemu su

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Alexander Graf
Avi Kivity wrote: > On 02/10/2010 06:43 PM, Alexander Graf wrote: > >>> Out of curiousity, why? It seems like an odd interface. >>> >>> >>> >> Because on PPC, you usually run PPC32 userspace code on a PPC64 kernel. >> Unlike with x86, there's no real benefit in using 64 bit usersp

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Avi Kivity
On 02/10/2010 06:47 PM, Alexander Graf wrote: >>> Because on PPC, you usually run PPC32 userspace code on a PPC64 kernel. >>> Unlike with x86, there's no real benefit in using 64 bit userspace. >>> >>> >>> >> btw, does 32-bit ppc qemu support large memory guests? It doesn't on >> x86

Re: [Qemu-devel] Re: [PATCH v2] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-10 Thread Alexander Graf
Avi Kivity wrote: > On 02/10/2010 06:47 PM, Alexander Graf wrote: > Because on PPC, you usually run PPC32 userspace code on a PPC64 kernel. Unlike with x86, there's no real benefit in using 64 bit userspace. >>> btw, does 32-bit ppc qemu supp

[Qemu-devel] [RFC] qcow2: Rewrite alloc_refcount_block

2010-02-10 Thread Kevin Wolf
The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be corrupted. I have found that the only way to fix this is to completely rewrite the thing. This

Re: [Qemu-devel] [PATCH] alpha-linux-user: Implement signals.

2010-02-10 Thread Richard Henderson
On 02/10/2010 04:04 AM, Riku Voipio wrote: On Tue, Feb 09, 2010 at 10:46:32AM -0800, Richard Henderson wrote: Ping? The linux-user side of the patch seems fine, but the target-alpha code doesn't apply. Either something has changed upstream or this depends on one of your other alpha patches. If

Re: [Qemu-devel] [PATCH] Fix lost serial TX interrupts. Report receive overruns.

2010-02-10 Thread Anthony Liguori
On 01/28/2010 05:13 PM, Justin T. Gibbs wrote: This patch compliments the patch submitted by Jergen Lock and further improves the performance of QEMU's serial emulation with FreeBSD's uart(9) driver. o Implement receive overrun status. The FreeBSD uart driver relies on this status in it's p

[Qemu-devel] (no subject)

2010-02-10 Thread Stephen Isard
Hello, I hope you will excuse a naive question here. I'm not getting any response on the users' lists. I'm wondering whether shutting down a guest machine with the quit command in the monitor can corrupt the snapshots saved with savevm. As I understand it, quit will have an effect on the

[Qemu-devel] [PATCH] alpha-linux-user: Implement signals.

2010-02-10 Thread Richard Henderson
Move userland PALcode handling into linux-user main loop so that we can send signals from there. This also makes alpha_palcode.c system-level only, so don't build it for userland. Add defines for GENTRAP PALcall mapping to signals. Signed-off-by: Richard Henderson --- Makefile.target

Re: [Qemu-devel] [PATCH] block: saner flags filtering in bdrv_open2

2010-02-10 Thread Anthony Liguori
On 01/28/2010 08:19 AM, Christoph Hellwig wrote: Clean up the current mess about figuring out which flags to pass to the driver. BDRV_O_FILE, BDRV_O_SNAPSHOT and BDRV_O_NO_BACKING are flags only used by the block layer internally so filter them out directly. Previously BDRV_O_NO_BACKING could ac

Re: [Qemu-devel] [PATCH] Do not ignore error, if open file failed (-serial /dev/tty)

2010-02-10 Thread Anthony Liguori
On 01/28/2010 12:44 PM, Evgeniy Dushistov wrote: In case, when qemu is executed with option like -serial /dev/ttyS0, report if there are problems with opening of devices. At now errors are silently ignoring. Signed-off-by: Evgeniy Dushistov Applied. Thanks. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH v2] qemu-img: Fix qemu-img can't create qcow image based on read-only image

2010-02-10 Thread Anthony Liguori
On 01/28/2010 08:15 PM, Sheng Yang wrote: Commit 03cbdac7 "Disable fall-back to read-only when cannot open drive's file for read-write" result in read-only image can't be used as backed image in qemu-img. Cc: Naphtali Sprei Signed-off-by: Sheng Yang Applied. Thanks. Regards, Anthony Lig

Re: [Qemu-devel] [PATCH] doc: Update mingw cross compile instructions

2010-02-10 Thread Anthony Liguori
On 01/29/2010 01:28 PM, Scott Tsai wrote: The "Cross compilation for Windows with Linux" section of qemu-doc.texi still instructs the user to use 'configure --enable-mingw32' even after the option was removed in Aug 2008: http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=cd01b4a312248dd4e12c3d

Re: [Qemu-devel] [PATCH] Documentation: Add build support for documentation in pdf format

2010-02-10 Thread Anthony Liguori
On 01/29/2010 04:16 PM, Stefan Weil wrote: Makefile already supported dvi, html and info formats, but pdf was missing. pdf is especially convenient for printing and for documentation reviews. I hope it will help to improve qemu's documentation. Make now supports the new target 'pdf' which will

Re: [Qemu-devel] [PATCH] qcow2: Fix signedness bugs

2010-02-10 Thread Anthony Liguori
On 02/02/2010 08:20 AM, Kevin Wolf wrote: Checking for return codes< 0 isn't really going to work with unsigned types. Use signed types instead. Signed-off-by: Kevin Wolf Applied. Thanks. Regards, Anthony Liguori --- block/qcow2-cluster.c | 12 ++-- block/qcow2.h

Re: [Qemu-devel] [PATCH 1/3] do not loop on an incomplete io_thread_fd read

2010-02-10 Thread Anthony Liguori
On 02/02/2010 01:33 PM, Paolo Bonzini wrote: No need to loop if less than a full buffer is read, the next read would return EAGAIN. Signed-off-by: Paolo Bonzini Applied all. Thanks. Regards, Anthony Liguori --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/5] QMP: BLOCK_IO_ERROR event handling

2010-02-10 Thread Anthony Liguori
On 02/03/2010 08:41 AM, Luiz Capitulino wrote: This commit adds the basic definitions for the BLOCK_IO_ERROR event, but actual event emission will be introduced by the next commits. Signed-off-by: Luiz Capitulino Applied all. Thanks. Regards, Anthony Liguori --- QMP/qmp-events.txt |

Re: [Qemu-devel] [PATCH 0/15][RFC] New PCI interfaces

2010-02-10 Thread Blue Swirl
On Wed, Feb 10, 2010 at 12:01 AM, Anthony Liguori wrote: > This is a work in progress that I wanted to share giving some of the > discussions > around rwhandlers.  The idea is to make PCI devices have a common set of > functions to interact with the CPU that is driven entirely through the PCI >

Re: [Qemu-devel] [PATCH] configure: Add --enable-docs and --disable-docs to --help

2010-02-10 Thread Anthony Liguori
On 02/06/2010 02:48 AM, Dirk Ullrich wrote: This patch adds the documentation-related options "--enable-docs" and "--disable-docs" to the help message of "configure". Signed-off-by: Dirk Ullrich This patch is white space damaged and this is not a valid SoB line. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] add close callback for tty-based char device

2010-02-10 Thread Anthony Liguori
On 02/03/2010 10:18 AM, David S. Ahern wrote: Add a tty close callback. Right now if a guest device that is connected to a tty-based chardev in the host is removed, the tty is not closed. With this patch it is closed. Example use case is connecting an emulated USB serial cable in the guest to tt

Re: [Qemu-devel] [PATCH] audio streaming from usb devices

2010-02-10 Thread Anthony Liguori
On 02/03/2010 09:49 AM, David S. Ahern wrote: I have streaming audio devices working within qemu-kvm. This is a port of the changes to qemu. Streaming audio generates a series of isochronous requests that are repetitive and time sensitive. The URBs need to be submitted in consecutive USB frames

Re: [Qemu-devel] [PATCH] segfault due to buffer overrun in usb-serial

2010-02-10 Thread Anthony Liguori
On 02/03/2010 10:00 AM, David S. Ahern wrote: This fixes a segfault due to buffer overrun in the usb-serial device. The memcpy was incrementing the start location by recv_used yet, the computation of first_size (how much to write at the end of the buffer before wrapping to the front) was not acco

Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset command cause assert failed)

2010-02-10 Thread Anthony Liguori
On 02/03/2010 08:30 PM, Roy Tam wrote: 2010/2/4 Roy Tam: 2010/2/3 Luiz Capitulino: OK we are fooled by the json lexer and parser. As we use %I64d to print 'long long' variables in Win32, but lexer and parser only deal with %lld but not %I64d, this patch add support for %I64d and solve

Re: [Qemu-devel] [PATCH] kvm: reduce code duplication in config_iothread

2010-02-10 Thread Anthony Liguori
On 02/04/2010 08:46 AM, Amit Shah wrote: We have some duplicated code in the CONFIG_IOTHREAD #ifdef and #else cases. Fix that. Signed-off-by: Amit Shah Applied. Thanks. Regards, Anthony Liguori --- kvm-all.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --

Re: [Qemu-devel] [PATCH 0/15][RFC] New PCI interfaces

2010-02-10 Thread Anthony Liguori
On 02/10/2010 12:34 PM, Blue Swirl wrote: On Wed, Feb 10, 2010 at 12:01 AM, Anthony Liguori wrote: This is a work in progress that I wanted to share giving some of the discussions around rwhandlers. The idea is to make PCI devices have a common set of functions to interact with the CPU tha

Re: [Qemu-devel] [PATCH 1/4] QMP: Add QEMU's version to the greeting message

2010-02-10 Thread Anthony Liguori
On 02/04/2010 02:10 PM, Luiz Capitulino wrote: With capability negotiation support clients will only have a chance to check QEMU's version (ie. issue 'query-version') after the negotiation procedure is done. It might be useful to clients to check QEMU's version before negotiating features, thoug

Re: [Qemu-devel] [PATCH v2] vnc: Migrate to using QTAILQ instead of custom implementation

2010-02-10 Thread Anthony Liguori
On 02/05/2010 05:04 AM, Amit Shah wrote: Just a 1-1 conversion for now. Signed-off-by: Amit Shah Applied. Thanks. Regards, Anthony Liguori --- v2: - QTAILQ_INIT the queue. vnc.c | 74 vnc.h |5 ++- 2 files ch

Re: [Qemu-devel] [PATCH 2/8] Documentation: Add direntry for info format

2010-02-10 Thread Anthony Liguori
On 02/05/2010 04:51 PM, Stefan Weil wrote: update-info-dir maintains an index of all available documentation in info format (the file /usr/share/info/dir). It reads special @direntry tags in info files. This patch (extracted from a larger patch provided by Dirk Ullrich) adds these tags for qemu

Re: [Qemu-devel] [PATCH] configure: Add --enable-docs and --disable-docs to --help

2010-02-10 Thread Anthony Liguori
On 02/06/2010 02:48 AM, Dirk Ullrich wrote: This patch adds the documentation-related options "--enable-docs" and "--disable-docs" to the help message of "configure". Signed-off-by: Dirk Ullrich Applied. But I missed that you weren't using a valid SoB. Please use a proper email address

[Qemu-devel] Re: Network shutdown under load

2010-02-10 Thread Anthony Liguori
On 02/08/2010 10:10 AM, Tom Lendacky wrote: Fix a race condition where qemu finds that there are not enough virtio ring buffers available and the guest make more buffers available before qemu can enable notifications. Signed-off-by: Tom Lendacky Signed-off-by: Anthony Liguori Applied. Tha

Re: [Qemu-devel] [PATCH] iothread: fix vcpu stop with smp tcg

2010-02-10 Thread Anthony Liguori
On 02/09/2010 08:49 AM, Marcelo Tosatti wrote: Round robin vcpus in tcg_cpu_next even if the vm stopped. This allows all cpus to enter stopped state. Signed-off-by: Marcelo Tosatti Applied. Thanks. Regards, Anthony Liguori diff --git a/vl.c b/vl.c index 880bcd5..f61e362 100644 --- a/vl

Re: [Qemu-devel] [PATCH] fix inet_parse typo

2010-02-10 Thread Anthony Liguori
On 02/09/2010 11:31 AM, Marcelo Tosatti wrote: qemu_opt_set wants on/off, not yes/no. Signed-off-by: Marcelo Tosatti Applied. Thanks. Regards, Anthony Liguori diff --git a/qemu-sockets.c b/qemu-sockets.c index 8850516..a88b2a7 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -424,7

Re: [Qemu-devel] [PATCH 1/2] versatile_pci: convert to symbolic names

2010-02-10 Thread Anthony Liguori
On 02/08/2010 03:41 PM, Michael S. Tsirkin wrote: This converts versatile_pci to use symbolic constants. Verified by comparing binary to original one. Signed-off-by: Michael S. Tsirkin Acked-by: Anthony Liguori Regards, Anthony Liguori --- hw/versatile_pci.c | 17 ++---

Re: [Qemu-devel] [PATCH 2/2] versatile_pci: cleanup

2010-02-10 Thread Anthony Liguori
On 02/08/2010 03:43 PM, Michael S. Tsirkin wrote: Cleanup versatile_pci: no need to re-set fields to zero (pci core sets 0 already), use set_word for status field. Compile-tested only, but seems obvious. Signed-off-by: Michael S. Tsirkin Acked-by: Anthony Liguori Regards, Anthony Liguor

Re: [Qemu-devel] [PATCH] Add cpu model configuration support.. (resend)

2010-02-10 Thread Anthony Liguori
On 02/01/2010 01:02 PM, john cooper wrote: [target-x86_64.conf was unintentionally omitted from the earlier patch] This is a reimplementation of prior versions which adds the ability to define cpu models for contemporary processors. The added models are likewise selected via -cpu, and are intend

Re: [Qemu-devel] [PATCH 0/15][RFC] New PCI interfaces

2010-02-10 Thread Richard Henderson
On 02/10/2010 11:29 AM, Anthony Liguori wrote: void *pci_memory_map(PCIDevice *dev, pcibus_t addr, pcibus_t *plen, int is_write); void pci_memory_unmap(PCIDevice *dev, void *buf, pcibus_t *plen, int is_write, pcibus_t access_len); Are these functions intended to be controllable by the root bus

Re: [Qemu-devel] [PATCH 0/15][RFC] New PCI interfaces

2010-02-10 Thread Anthony Liguori
On 02/10/2010 02:41 PM, Richard Henderson wrote: On 02/10/2010 11:29 AM, Anthony Liguori wrote: void *pci_memory_map(PCIDevice *dev, pcibus_t addr, pcibus_t *plen, int is_write); void pci_memory_unmap(PCIDevice *dev, void *buf, pcibus_t *plen, int is_write, pcibus_t access_len); Are these fun

[Qemu-devel] forking i386 binaries on arm linux user mode

2010-02-10 Thread Damion Yates
I've grabbed the latest stable qemu and compiled under scratchbox. I hit an issue compiling it, with no __builtin__clear_cache() so linked in a kludge.c containing a call to __clear_cache() with the params passed as they would be to __builtin__clear_cache(). Firstly does this sound like it should

Re: [Qemu-devel] [PATCH] qemu-img: use the heap instead of the huge stack array for win32

2010-02-10 Thread Anthony Liguori
On 02/08/2010 02:20 AM, TeLeMan wrote: The default stack size of PE is 1MB on win32 and IO_BUF_SIZE in img_convert()& img_rebase() is 2MB, so qemu-img will crash when doing "convert"& "rebase" on win32. Although we can improve the stack size of PE to resolve it, I think we should avoid using th

Re: [Qemu-devel] [PATCH] don't dereference NULL after failed strdup

2010-02-10 Thread Anthony Liguori
On 02/08/2010 12:28 PM, Jim Meyering wrote: Most of these are obvious NULL-deref bug fixes, for example, the ones in these files: block/curl.c net.c slirp/misc.c and the first one in block/vvfat.c. The others in block/vvfat.c may not lead to an immediate segfault, but I traced the two

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-10 Thread Anthony Liguori
On 02/08/2010 01:01 PM, Luiz Capitulino wrote: Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated in the callers. Signed-off-by: Luiz Capitulino Applied all. Thanks. Regards, Anthony Liguori --- qjson.c |5 +

Re: [Qemu-devel] [PATCH 1/1] Increase VNC_MAX_WIDTH

2010-02-10 Thread Anthony Liguori
On 02/08/2010 02:22 PM, Brian Jackson wrote: Increase VNC_MAX_WIDTH to match "commonly available" consumer level monitors available these days. This also closes KVM bug 2907597 Signed-off-by: Brian Jackson Applied. Thanks. Regards, Anthony Liguori --- vnc.h |2 +- 1 files chang

[Qemu-devel] [PATCH] add close callback for tty-based char device

2010-02-10 Thread David Ahern
Add a tty close callback. Right now if a guest device that is connected to a tty-based chardev in the host is removed, the tty is not closed. With this patch it is closed. Example use case is connecting an emulated USB serial cable in the guest to ttyS0 of the host using the monitor command: usb

Re: [Qemu-devel] forking i386 binaries on arm linux user mode

2010-02-10 Thread Laurent Desnogues
On Wed, Feb 10, 2010 at 10:38 PM, Damion Yates wrote: > I've grabbed the latest stable qemu and compiled under scratchbox.  I > hit an issue compiling it, with no __builtin__clear_cache() so linked in > a kludge.c containing a call to __clear_cache() with the params passed > as they would be to __

[Qemu-devel] [PATCH 1/5] virtio-blk: revert serial number support

2010-02-10 Thread Christoph Hellwig
The addition of the whole ATA IDENTIY page caused the config space to go above the allowed size in the PCI spec, and thus the feature was already reverted in the Linux guest driver and disabled by default in qemu. Signed-off-by: Christoph Hellwig Index: qemu/hw/virtio-blk.c =

[Qemu-devel] [PATCH 2/5] block: add topology qdev properties

2010-02-10 Thread Christoph Hellwig
Add three new qdev properties to export block topology information to the guest. This is needed to get optimal I/O alignment for RAID arrays or SSDs. The options are: - physical_block_size to specify the physical block size of the device, this is going to increase from 512 bytes to 4096 kilo

[Qemu-devel] [PATCH 3/5] virtio-blk: add topology support

2010-02-10 Thread Christoph Hellwig
Export all topology information in the block config structure, guarded by a new VIRTIO_BLK_F_TOPOLOGY feature flag. Signed-off-by: Christoph Hellwig Index: qemu/hw/virtio-blk.c === --- qemu.orig/hw/virtio-blk.c 2010-02-10 23:27:55

[Qemu-devel] [PATCH 4/5] scsi: add topology support

2010-02-10 Thread Christoph Hellwig
Export the physical block size in the READ CAPACITY (16) command, and add the new block limits VPD page to export the minimum and optiomal I/O sizes. Note that we also need to bump the scsi revision level to SPC-2 as that is the minimum requirement by at least the Linux kernel to try READ CAPACITY

[Qemu-devel] [PATCH 5/5] ide: add topology support

2010-02-10 Thread Christoph Hellwig
Export the physical block size in the ATA IDENTIFY command. The other topology values are not supported in ATA so skip them. Signed-off-by: Christoph Hellwig Index: qemu/hw/ide/core.c === --- qemu.orig/hw/ide/core.c 2010-02-10

[Qemu-devel] sparc32 fix spurious dma interrupts

2010-02-10 Thread Artyom Tarasenko
Don't raise interrupt when not enabled. Don't set DMA_INTR bit spuriously. Don't print misleading debug messages "Raise IRQ" when not raising any. Signed-off-by: Artyom Tarasenko --- diff --git a/hw/sparc32_dma.c b/hw/sparc32_dma.c index 6e991e0..b2992ca 100644 --- a/hw/sparc32_dma.c +++ b/hw/spa

Re: [Qemu-devel] [PATCH] add close callback for tty-based char device

2010-02-10 Thread Anthony Liguori
On 02/10/2010 04:00 PM, David Ahern wrote: Add a tty close callback. Right now if a guest device that is connected to a tty-based chardev in the host is removed, the tty is not closed. With this patch it is closed. Example use case is connecting an emulated USB serial cable in the guest to ttyS0

[Qemu-devel] [PATCH 0/4] qemu-kvm: prepare for adding eventfd usage to upstream

2010-02-10 Thread Paolo Bonzini
This patch series morphs the code in qemu-kvm's eventfd so that it looks like the code in upstream qemu. Patch 4 is not yet in upstream QEMU, I'm submitting it first to qemu-kvm to avoid conflicts. Paolo Bonzini (4): morph qemu_kvm_notify_work into qemu.git's qemu_event_increment morph io_thr

[Qemu-devel] [PATCH 4/4] qemu-kvm: move qemu_eventfd to osdep.c

2010-02-10 Thread Paolo Bonzini
Upstream has no compatfd.[ch], so move the code to the most similar place. Signed-off-by: Paolo Bonzini --- compatfd.c| 26 -- compatfd.h|2 -- osdep.c | 32 qemu-common.h |1 + 4 files changed, 33 insertions(+),

[Qemu-devel] [PATCH 3/4] qemu-kvm: fix placement of config-host.h inclusion

2010-02-10 Thread Paolo Bonzini
Cherry-picked from upstream f582af5. Signed-off-by: Paolo Bonzini --- osdep.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/osdep.c b/osdep.c index e613e4b..616e821 100644 --- a/osdep.c +++ b/osdep.c @@ -28,14 +28,15 @@ #include #include #include + +/* Need

[Qemu-devel] [PATCH 1/4] qemu-kvm: morph qemu_kvm_notify_work into qemu.git's qemu_event_increment

2010-02-10 Thread Paolo Bonzini
No need to loop if < 8 bytes are written, since that will happen only for pipes and is harmless. eventfd writes of 8 bytes will always succeed or fail with EAGAIN. Signed-off-by: Paolo Bonzini --- qemu-kvm.c | 34 -- 1 files changed, 12 insertions(+), 22 deleti

[Qemu-devel] [PATCH 2/4] qemu-kvm: morph io_thread_wakeup into qemu.git's qemu_event_read

2010-02-10 Thread Paolo Bonzini
Again, no need to loop if less than a full buffer is read, the next read would return EAGAIN. Signed-off-by: Paolo Bonzini --- qemu-kvm.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/qemu-kvm.c b/qemu-kvm.c index 669a784..50e1303 100644 --- a/qemu-kvm.

[Qemu-devel] Re: [PATCH] virtio-spec: document indirect descriptors

2010-02-10 Thread Rusty Russell
On Wed, 10 Feb 2010 11:30:39 pm Michael S. Tsirkin wrote: > Add documentation for indirect descriptors Thanks, that's awesome! I added an entry to the Reserved Feature table in appendix B, and applied it. We're now at 0.8.5. Cheers, Rusty.

[Qemu-devel] [PATCH 0/2] simplify global register save/restore

2010-02-10 Thread Paolo Bonzini
Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global register that is actually used is AREG0, so the complexity of hostregs_helper.h is unwarranted. Let's just say that env should be the only global register. AREG1 and AREG2 in principle could still be used to work around bad

[Qemu-devel] [PATCH 1/2] remove dead m68k global register definitions

2010-02-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target-m68k/exec.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/target-m68k/exec.h b/target-m68k/exec.h index 1267bb6..ece9aa0 100644 --- a/target-m68k/exec.h +++ b/target-m68k/exec.h @@ -20,10 +20,6 @@ #include "dyngen-exec.h" r

[Qemu-devel] [PATCH 2/2] get rid of hostregs_helper.h

2010-02-10 Thread Paolo Bonzini
Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global register that is used is AREG0, so the complexity of hostregs_helper.h is unused. Use regular assignments and a compiler optimization barrier. Signed-off-by: Paolo Bonzini --- cpu-exec.c| 15 +++- hostreg

[Qemu-devel] [PATCH] [uq/master] use eventfd for iothread

2010-02-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- osdep.c | 32 qemu-common.h |1 + vl.c |9 + 3 files changed, 38 insertions(+), 4 deletions(-) diff --git a/osdep.c b/osdep.c index 9059f01..9e4b17b 100644 --- a/osdep.c +++ b/osdep.c @@ -37,6 +37,

[Qemu-devel] [PATCH 1/3] use lazy initialization for display_state

2010-02-10 Thread Paolo Bonzini
Ensure initialization of a dumb display, if needed, by making all accesses go through get_displaystate. Signed-off-by: Paolo Bonzini --- vl.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/vl.c b/vl.c index 5ddf1fe..94aeb5e 100644 --- a/vl.

[Qemu-devel] [PATCH 2/3] remove knowledge of defaultallocator_free_displaysurface from sdl.c

2010-02-10 Thread Paolo Bonzini
Let register_displayallocator hand over the old width/height to the new allocator. Signed-off-by: Paolo Bonzini --- So these functions will be made static when moved to console.c. sdl.c |4 vl.c |8 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/sd

[Qemu-devel] [PATCH 3/3] move default allocator to console.c

2010-02-10 Thread Paolo Bonzini
Moving stuff in console.c to avoid the need for prototypes makes this patch a bit bigger, but there's no change in the code. Signed-off-by: Paolo Bonzini --- console.c | 176 +++-- console.h |4 -- vl.c | 50 - 3

[Qemu-devel] [PATCH 0/3] move stuff out from vl.c to console.c

2010-02-10 Thread Paolo Bonzini
Moving stuff around to console.c; video does not belong in a target-dependent file. Paolo Bonzini (3): use lazy initialization for display_state remove knowledge of defaultallocator_free_displaysurface from sdl.c move default allocator to console.c console.c | 176

[Qemu-devel] Audio latency

2010-02-10 Thread Alberich de megres
Hi! I'm running qemu on suse, and i got a very high audio latency. For example, using windows latency is about 4s and audio gets distorted with little cuts. On the host side (suse), i changed the audio pci device latency to 99 but this only improves a little bit. Other thing i noticed is when low

Re: [Qemu-devel] Audio latency

2010-02-10 Thread malc
On Thu, 11 Feb 2010, Alberich de megres wrote: > Hi! > > I'm running qemu on suse, and i got a very high audio latency. For > example, using windows latency is about 4s and audio gets distorted > with little cuts. > On the host side (suse), i changed the audio pci device latency to 99 > but this

[Qemu-devel] [PATCH v2] add close callback for tty-based char device

2010-02-10 Thread David Ahern
v1 -> v2 coding style changes Add a tty close callback. Right now if a guest device that is connected to a tty-based chardev in the host is removed, the tty is not closed. With this patch it is closed. Example use case is connecting an emulated USB serial cable in the guest to ttyS0 of the host

[Qemu-devel] [PATCH v0 00/21]: Monitor: improve handlers error handling

2010-02-10 Thread Luiz Capitulino
Hi there, When I started converting handlers to the QObject style, I thought that returning an error code wouldn't be needed. That is, we have an error object already, so if the handler returns the error object it has failed, otherwise it has succeeded. This was also very convenient, because h

[Qemu-devel] [PATCH 01/21] Monitor: Introduce cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
In order to implement the new error handling and debugging mechanism for command handlers, we need to change the cmd_new() callback to return a value. This commit introduces cmd_new_ret(), which returns a value and will be used only temporarily to handle the transition from cmd_new(). That is, as

[Qemu-devel] [PATCH 03/21] Monitor: Convert do_cont() to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- monitor.c |8 ++-- qemu-monitor.hx |2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index c1e0af8..cede368 100644 --- a/monitor.c +++ b/monitor.c @@ -1148,14 +1148,18 @@ struct bdrv_iterate_context {

[Qemu-devel] [PATCH 02/21] Monitor: Convert simple handlers to cmd_new_ret()

2010-02-10 Thread Luiz Capitulino
The following handlers always succeed and hence can be converted to cmd_new_ret() in the same commit. - do_stop() - do_quit() - do_system_reset() - do_system_powerdown() - do_migrate_cancel() - do_qmp_capabilities() - do_migrate_set_speed() - do_migrate_set_downtime() Signed-off-by: Luiz Capituli

  1   2   >