Re: [Qemu-devel] [PATCH] fix inet_parse typo

[Anthony Liguori]

On 02/09/2010 11:31 AM, Marcelo Tosatti wrote:

qemu_opt_set wants on/off, not yes/no.

Signed-off-by: Marcelo Tosatti<mtosa...@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

diff --git a/qemu-sockets.c b/qemu-sockets.c
index 8850516..a88b2a7 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
                      __FUNCTION__, str);
              return -1;
          }
-        qemu_opt_set(opts, "ipv6", "yes");
+        qemu_opt_set(opts, "ipv6", "on");
      } else if (qemu_isdigit(str[0])) {
          /* IPv4 addr */
          if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) {
@@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str)
                      __FUNCTION__, str);
              return -1;
          }
-        qemu_opt_set(opts, "ipv4", "yes");
+        qemu_opt_set(opts, "ipv4", "on");
      } else {
          /* hostname */
          if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) {
@@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str)
      if (h)
          qemu_opt_set(opts, "to", h+4);
      if (strstr(optstr, ",ipv4"))
-        qemu_opt_set(opts, "ipv4", "yes");
+        qemu_opt_set(opts, "ipv4", "on");
      if (strstr(optstr, ",ipv6"))
-        qemu_opt_set(opts, "ipv6", "yes");
+        qemu_opt_set(opts, "ipv6", "on");
      return 0;
  }