The default stack size of PE is 1MB on win32 and IO_BUF_SIZE in
img_convert() & img_rebase() is 2MB, so qemu-img will crash when doing
"convert" & "rebase" on win32.
Although we can improve the stack size of PE to resolve it, I think we
should avoid using the huge stack variables.
Signed-off-by: T
You can improve your patch's chances for getting noticed, reviewed and
merged by putting [PATCH] in your subject. Consider using
git-format-patch and git-send-email.
On 02/08/2010 06:56 AM, TeLeMan wrote:
The static compilation for sdl is broken after
79427693174a553d62f3da44aacd3f19ba8df3a7.
ACK.
Signed-off-by: TeLeMan
---
configure |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 4c95c27..213d
malc,
commit bc5b600 does the same thing as the series I posted at
http://permalink.gmane.org/gmane.comp.emulators.qemu/62997, only worse:
1) for vl.c and qemu-img.c, it disable FORTIFY_SOURCE checking which is
only enabled by the printf macro:
# define printf(...) \
__builtin___printf_c
On 02/05/2010 07:26 PM, Blue Swirl wrote:
Thanks, applied.
Thanks Blue Swirl, can you please cherry-pick commit 0dfbd514 (fix
undefined shifts by >32) into stable-0.12?
Paolo
On 02/08/2010 12:09 AM, Anthony Liguori wrote:
On 02/07/2010 10:31 AM, Avi Kivity wrote:
Only insofar as you don't have to deal with getting at the VM fd.
You can avoid the problem by having the kvm ioctl interface take a
pid or something.
That's a racy interface.
The mechanism itself is
On Mon, Feb 08, 2010, TeLeMan wrote:
> The static compilation for sdl is broken after
> 79427693174a553d62f3da44aacd3f19ba8df3a7.
>
> Signed-off-by: TeLeMan
> ---
> configure |7 +--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 4c95c2
On Mon, 8 Feb 2010, Paolo Bonzini wrote:
> malc,
>
> commit bc5b600 does the same thing as the series I posted at
> http://permalink.gmane.org/gmane.comp.emulators.qemu/62997, only worse:
>
> 1) for vl.c and qemu-img.c, it disable FORTIFY_SOURCE checking which is only
> enabled by the printf mac
On 02/08/2010 10:09 AM, malc wrote:
Because i had a hard disk crash and hence ended up with a new shiny
system where QEMU does not build anymore, also not enough patience
to revisit the thread and figure out why it wasn't applied yet.
Sorry for you, but that's what local branches are for.
Paol
rewrote timer implementation for rtl8139. Add a QEMU timer only when needed
(timeout status not set, timeout irq wanted and timer set).
Signed-off-by: Frediano Ziglio
---
hw/rtl8139.c | 136 ++---
1 files changed, 81 insertions(+), 55 deletion
On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote:
> This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5.
> pci host bridge doesn't have header type of bridge.
> The check should be by header type, instead of pci class device.
>
> Cc: Blue Swirl
> Cc: "Michael S. Tsirkin"
> Si
Hi,
Seabios seems to have some assumptions built in that break when -M isapc
is selected. Is this supposed to work or is isapc about to die?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
On 01/12/2010 03:36 PM, Kevin O'Connor wrote:
On Tue, Jan 12, 2010 at 10:10:41AM +0100, Magnus Christensson wrote:
On 12/24/2009 01:29 AM, Kevin O'Connor wrote:
On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote:
Should be cpu_length + 2 as far as I can tell.
On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
> initialize header type register in pci generic code.
>
> Cc: Blue Swirl
> Cc: "Michael S. Tsirkin"
> Signed-off-by: Isaku Yamahata
No objections here, I am assuming this will be followed
by patches removing header type init from
We think access phys_ram_dirty through inline functions is better
than directly for encoupseling reason.
We devided the ram in a 64 pages block. Each block has a counter, which is
stored in phys_ram_dirty_by_word. It shows the number of dirty pages.
We will find the 64 pages block is dirty or non-
The dirty and non-dirty pages are checked one by one in vl.c.
Since we believe that most of the memory is not dirty,
checking the dirty and non-dirty pages by multiple page size
should be much faster than checking them one by one.
We think there is mostly two kind of situation.
One is almost all t
We will check the dirty and non-dirty pages as follows:
1. Checked by 64 pages block.
Check pages using phys_ram_dirty_by_word. Count up/down it when
phys_ram_dirty when is 0xff or not.
2. Checked by TARGET_LONG_SIZE pages block.
3. Checked by one page.
Signed-off-by: OHMURA Kei
---
exec.c | 1
Get number of the dirty and non-dirty pages using
cpu_physical_memory_get_{dirty|non_dirty}_range().
Signed-off-by: OHMURA Kei
---
vl.c | 57 ++---
1 files changed, 38 insertions(+), 19 deletions(-)
diff --git a/vl.c b/vl.c
index 4ef6a78..0
Am 07.02.2010 15:19, schrieb Naphtali Sprei:
> This version addresses comments by Kevin Wolf to v2
> Also separate commits squashed.
>
>
> Open image file read-only where possible
> Upgrade file to read-write during commit, back to read-only after commit
> Added option for qemu-img.c bdrv_new_op
On Mon, Feb 08, 2010 at 03:45:03PM +0900, Isaku Yamahata wrote:
> The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00
> specifies pbm pci host bridge is type of bridge.
> It contradicts with pbm_pci_host_init().
>
> Blue Swirl, could you please check this patch?
> To be honest I don't know
On Mon, Feb 08, 2010 at 03:45:03PM +0900, Isaku Yamahata wrote:
> The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00
> specifies pbm pci host bridge is type of bridge.
> It contradicts with pbm_pci_host_init().
By the way, the next below (cover letter) should be put after
--- rather than
On 01/28/10 05:39, Kevin O'Connor wrote:
As a side note, it should probably do the e820 map check even for qemu
users (ie, not just kvm).
Hi Kevin,
Here is an updated version of the patch which does the e820 read
unconditionally of the return from kvm_para_available() so it should
work for co
On Mon, Feb 08, 2010 at 03:38:36PM +0900, Isaku Yamahata wrote:
> typo in c021f8e65f5009a5ab5711d9d5326fcab553ef1c.
> comparison fix.
>
> Cc: Blue Swirl
> Cc: "Michael S. Tsirkin"
> Signed-off-by: Isaku Yamahata
thanks, applied.
> ---
> hw/pci.c |2 +-
> 1 files changed, 1 insertions(+),
2010/2/8 Igor Kovalenko :
> On Sun, Feb 7, 2010 at 6:22 PM, Frediano Ziglio wrote:
>> rewrote timer implementation for rtl8139. Add a QEMU
>> timer only when needed (timeout status not set, timeout irq wanted and
>> timer set).
>>
>> Signed-off-by: Frediano Ziglio
>> --
>> diff --git a/hw/rtl8139
On Mon, Feb 08, 2010 at 12:10:52PM +0200, Michael S. Tsirkin wrote:
> On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote:
> > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5.
> > pci host bridge doesn't have header type of bridge.
> > The check should be by header type, instea
On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote:
> This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5.
> pci host bridge doesn't have header type of bridge.
> The check should be by header type, instead of pci class device.
>
> Cc: Blue Swirl
> Cc: "Michael S. Tsirkin"
> Si
On 02/08/2010 10:10 AM, Paolo Bonzini wrote:
On 02/08/2010 10:09 AM, malc wrote:
Because i had a hard disk crash and hence ended up with a new shiny
system where QEMU does not build anymore, also not enough patience
to revisit the thread and figure out why it wasn't applied yet.
Sorry for you,
Hi all,
Is it possible to run any linux based USB device side application on QEMU? For
example I want to develop a linux based mass storage device and I want to test
it on QEMU.
BR,
Taimoor
__
On 02/08/10 11:17, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
initialize header type register in pci generic code.
Cc: Blue Swirl
Cc: "Michael S. Tsirkin"
Signed-off-by: Isaku Yamahata
No objections here, I am assuming this will be followed
by pa
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
> On 02/08/10 11:17, Michael S. Tsirkin wrote:
>> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
>>> initialize header type register in pci generic code.
>>>
>>> Cc: Blue Swirl
>>> Cc: "Michael S. Tsirkin"
>>> Signed-of
On Fri, 05 Feb 2010 18:14:41 +0100
Markus Armbruster wrote:
> Anthony Liguori writes:
[...]
> Yes. But what's reasonably expected entirely depends on the contract
> between the function and its callers.
>
> I think we need a function that cannot fail and shouldn't used with
> untrusted argum
>> Would be great if you could provide a version for upstream as well
>> because it will likely replace this qemu-kvm code on day.
> O.K. We'll prepare it.
We have implemented the version for upstream. Some source code are borrowed
from qemu-kvm.c. It is not fully tested yet, though.
We also
On Mon, Feb 08, 2010 at 01:56:44PM +0800, TeLeMan wrote:
> The static compilation for sdl is broken after
> 79427693174a553d62f3da44aacd3f19ba8df3a7.
>
> Signed-off-by: TeLeMan
Thanks, applied.
> ---
> configure |7 +--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git
OHMURA Kei wrote:
>>> Would be great if you could provide a version for upstream as well
>>> because it will likely replace this qemu-kvm code on day.
>> O.K. We'll prepare it.
>
>
> We have implemented the version for upstream. Some source code are borrowed
> from qemu-kvm.c. It is not fully
On Sun, Feb 07, 2010 at 02:02:31PM +0100, Laurent Desnogues wrote:
> On Sun, Feb 7, 2010 at 1:54 PM, Laurent Desnogues
> wrote:
> > On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote:
> >> From: Juha Riihimäki
> >> add an extra check in "two registers and a shift" to ensure element
> >> size dec
On Mon, 8 Feb 2010 15:42:30 +0800
Roy Tam wrote:
> 2010/2/8 TeLeMan :
> > The json parser does not support "%I64d", so we have to use "%lld"
> > instead of "%I64d".
> >
>
> We use PRId64 with json in more places besides migration.c and
> monitor.c, adding %I64d support in json lexer/parser is a
Hi,
I've just compiled qemu 0.12.2 for Windows under msys.
I am using "-m prep -M 750" options which on 0.11 worked fine. In 012.2
however, I get the following error:
qemu: hardware error: PowerPC 601 / 620 / 970 need a 1MB BIOS
CPU #0:
NIP LR CTR XER
MSR 00
On 02/05/2010 12:18 PM, OHMURA Kei wrote:
> dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c.
> But We think that dirty-bitmap-traveling by long size is faster than by byte
> size especially when most of memory is not dirty.
>
>
>
> +
> +static int kvm_get_dirty_pages_log_range_by_l
On 02/08/10 12:16, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
On 02/08/10 11:17, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
initialize header type register in pci generic code.
Cc: Blue Swirl
Cc: "Mic
On 02/07/10 17:24, Anthony Liguori wrote:
On 02/06/2010 12:59 PM, john cooper wrote:
This patch reworks support for both assignment and
append in the config file parser. It was motivated
by comments received on the cpu model config file
format.
Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9
ch
Just a note, maybe someone finds the time to look at this:
Sending ALT-F4 to the SDL window of qemu (stable-0.12 and master) when
it was configured with --enable-io-thread and runs -smp 2 or more causes
a lock-up of the qemu process.
[I currently trigger way too many bugs...]
Jan
--
Siemens AG
Hi there,
I have two not so related QMP events issues two discuss, but I will talk about
them in the same email to avoid starting two threads.
The first problem is wrt the STOP event. Right now it's only emitted if it's
triggered through qemu_system_vmstop_request(), which afaik will only be
Hello,
In my testing of virtio-console, I found qemu-kvm.git introduces a lot
of overhead in thread scheduling compared to qemu.git.
My test sends a 260M file from the host to a guest via a virtio-console
port and then computes the sha1sum of the file on the host as well as on
the guest, compares
On Mon, Feb 08, 2010 at 11:41:45AM -0200, Luiz Capitulino wrote:
>
> Hi there,
>
> I have two not so related QMP events issues two discuss, but I will talk
> about
> them in the same email to avoid starting two threads.
>
> The first problem is wrt the STOP event. Right now it's only emitted
On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
> initialize header type register in pci generic code.
>
> Cc: Blue Swirl
> Cc: "Michael S. Tsirkin"
> Signed-off-by: Isaku Yamahata
Applied, thanks.
> ---
> hw/pci.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Hello,
I'm trying to emulate the following MIPS code (taken from the bootloader of my
system):
/* Initialize GOT pointer.
** Global symbols can't be resolved before this is done, and as such we
can't
** use any global symbols in this code. We use the bal/ move xxx,ra
On 02/08/2010 08:12 AM, Daniel P. Berrange wrote:
For further backgrou, the key end goal here is that in a QMP client, upon
receipt of the 'RESET' event, we need to reliably& immediately determine
why it occurred. eg, triggered by watchdog, or by guest OS request. There
are actually 3 possibl
On 02/05/2010 11:14 AM, Markus Armbruster wrote:
Run time asserts are a terrible way to deal with reasonably expected errors.
Yes. But what's reasonably expected entirely depends on the contract
between the function and its callers.
I think we need a function that cannot fail and shouldn
On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote:
> On 02/08/2010 08:12 AM, Daniel P. Berrange wrote:
> >
> >For further backgrou, the key end goal here is that in a QMP client, upon
> >receipt of the 'RESET' event, we need to reliably& immediately determine
> >why it occurred. eg
On 02/08/2010 07:46 AM, Amit Shah wrote:
Hello,
In my testing of virtio-console, I found qemu-kvm.git introduces a lot
of overhead in thread scheduling compared to qemu.git.
My test sends a 260M file from the host to a guest via a virtio-console
port and then computes the sha1sum of the file on
On Sun, 7 Feb 2010, Richard Henderson wrote:
>
> I imagine that QEMU's VDSO would not have the complicated bits that the
> kernel's version does, where it arranges to read the clock without going into
> kernel space. I imagine QEMU would simply stuff a normal syscall sequence in
> there, which wo
update_refcount is marked as a function for which we must use its result,
static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
and rightly so, since doing otherwise would amount to ignoring write failure.
However, there are two cases in which the return value is currently
On Mon, 08 Feb 2010 08:53:26 -0600
Anthony Liguori wrote:
> On 02/05/2010 11:14 AM, Markus Armbruster wrote:
> >> Run time asserts are a terrible way to deal with reasonably expected
> >> errors.
> >>
> > Yes. But what's reasonably expected entirely depends on the contract
> > between the
On Mon, Feb 08, 2010 at 05:26:33PM +0300, Dmitry Antipov wrote:
> Hello,
>
> I'm trying to emulate the following MIPS code (taken from the bootloader of
> my system):
>
> /* Initialize GOT pointer.
> ** Global symbols can't be resolved before this is done, and as such
> we can't
On 02/08/2010 08:56 AM, Daniel P. Berrange wrote:
On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote:
On 02/08/2010 08:12 AM, Daniel P. Berrange wrote:
For further backgrou, the key end goal here is that in a QMP client, upon
receipt of the 'RESET' event, we need to reli
Am 08.02.2010 16:01, schrieb Jim Meyering:
> update_refcount is marked as a function for which we must use its result,
>
> static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
>
> and rightly so, since doing otherwise would amount to ignoring write failure.
> However, ther
Kevin Wolf wrote:
...
> I'm currently working on fixing exactly this, and unfortunaly, no, it's
> not that easy. What you introduce looks like proper error handling at
> first sight, but what happens in fact is that while the current write
> request correctly fails now we're running with corrupted
French version at the end of mail.
Please excuse our English.
Hello,
We are two apprentice in the last year of our training as engineers.
We would like to offer our services for the development of qemu. We
have 256 hours of school project to accompling, helped by a teacher
and researcher at ESEO
On Thu, Feb 04, 2010 at 08:21:08PM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Marcelo Tosatti wrote:
> >> With kvm-autotest the failure is not sporadic (and the above commit
> >> applied): with KVM_SET_GUEST_DEBUG in arch_put_regs all migration
> >> tests fail, without, all of them succeed.
On Thu, Feb 04, 2010 at 08:00:26PM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Marcelo Tosatti wrote:
> >>
> >> Unrelated to this problem, won't put_vcpu_events, which is executed
> >> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions?
> >
> > Good point, SET_GUEST_DEBUG shoul
On Mon, Feb 8, 2010 at 12:47 PM, Riku Voipio wrote:
> On Sun, Feb 07, 2010 at 02:02:31PM +0100, Laurent Desnogues wrote:
>> On Sun, Feb 7, 2010 at 1:54 PM, Laurent Desnogues
>> wrote:
>> > On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote:
>> >> From: Juha Riihimäki
>
>> >> add an extra check i
Marcelo Tosatti wrote:
> On Thu, Feb 04, 2010 at 08:00:26PM +0100, Jan Kiszka wrote:
>> Jan Kiszka wrote:
>>> Marcelo Tosatti wrote:
Unrelated to this problem, won't put_vcpu_events, which is executed
after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions?
>>> Good point, SET_G
Gerd Hoffmann wrote:
> On 02/07/10 17:24, Anthony Liguori wrote:
>> On 02/06/2010 12:59 PM, john cooper wrote:
>>> This patch reworks support for both assignment and
>>> append in the config file parser. It was motivated
>>> by comments received on the cpu model config file
>>> format.
>>>
>>> Comm
Fix a race condition where qemu finds that there are not enough virtio
ring buffers available and the guest make more buffers available before
qemu can enable notifications.
Signed-off-by: Tom Lendacky
Signed-off-by: Anthony Liguori
hw/virtio-net.c | 10 +-
1 files changed, 9 insert
On 02/04/2010 10:59 AM, Roy Tam wrote:
2010/2/4 Luiz Capitulino:
On Thu, 4 Feb 2010 10:30:30 +0800
Roy Tam wrote:
2010/2/4 Roy Tam:
2010/2/3 Luiz Capitulino:
OK we are fooled by the json lexer and parser. As we use %I64d to
print 'long long' variables in Win32, b
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
> On 02/08/10 11:17, Michael S. Tsirkin wrote:
>> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
>>> initialize header type register in pci generic code.
>>>
>>> Cc: Blue Swirl
>>> Cc: "Michael S. Tsirkin"
>>> Signed-of
On 02/03/2010 05:55 PM, Marcelo Tosatti wrote:
The following changes since commit 117f8eb81dfdf51a0418fbf6d260cbb72bcd4a9d:
Markus Armbruster (1):
qdev: Add rudimentary help for property value
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.
On 02/05/2010 08:05 AM, Riku Voipio wrote:
Same patchset as sent last week, with the TLS patched changed to the
"refactor cp15.c13" patch already acked by Laurent.
The following changes since commit 117f8eb81dfdf51a0418fbf6d260cbb72bcd4a9d:
Markus Armbruster (1):
qdev: Add rudimentar
On 02/08/2010 04:19 AM, Avi Kivity wrote:
On 01/12/2010 03:36 PM, Kevin O'Connor wrote:
On Tue, Jan 12, 2010 at 10:10:41AM +0100, Magnus Christensson wrote:
On 12/24/2009 01:29 AM, Kevin O'Connor wrote:
On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote:
Should be cpu_length
On Mon, Feb 8, 2010 at 12:37 PM, Michael S. Tsirkin wrote:
> On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote:
>> This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5.
>> pci host bridge doesn't have header type of bridge.
>> The check should be by header type, instead of pci cl
On 02/08/10 17:27, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
On 02/08/10 11:17, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
initialize header type register in pci generic code.
Cc: Blue Swirl
Cc: "Mic
On Mon, Feb 8, 2010 at 8:45 AM, Isaku Yamahata wrote:
> The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00
> specifies pbm pci host bridge is type of bridge.
> It contradicts with pbm_pci_host_init().
Bridge header type in qdev info is needed so that the write masks are
correct. Otherwise
On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote:
> On 02/08/10 17:27, Michael S. Tsirkin wrote:
>> On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
>>> On 02/08/10 11:17, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote:
>
On (Mon) Feb 08 2010 [08:57:05], Anthony Liguori wrote:
> On 02/08/2010 07:46 AM, Amit Shah wrote:
>> Hello,
>>
>> In my testing of virtio-console, I found qemu-kvm.git introduces a lot
>> of overhead in thread scheduling compared to qemu.git.
>>
>> My test sends a 260M file from the host to a gues
On 02/08/10 18:32, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote:
On 02/08/10 17:27, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
On 02/08/10 11:17, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 03:41:47
On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote:
> On 02/08/10 18:32, Michael S. Tsirkin wrote:
>> On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote:
>>> On 02/08/10 17:27, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote:
>
On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote:
> On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote:
>> On 02/08/10 18:32, Michael S. Tsirkin wrote:
>>> On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote:
On 02/08/10 17:27, Michael S. Tsirkin wrote:
> On M
On 02/08/10 18:37, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote:
On 02/08/10 18:32, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote:
On 02/08/10 17:27, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 12:14:11
On Mon, 8 Feb 2010 14:12:20 +
"Daniel P. Berrange" wrote:
> On Mon, Feb 08, 2010 at 11:41:45AM -0200, Luiz Capitulino wrote:
> >
> > Hi there,
> >
> > I have two not so related QMP events issues two discuss, but I will talk
> > about
> > them in the same email to avoid starting two threa
On Mon, 08 Feb 2010 09:13:37 -0600
Anthony Liguori wrote:
> On 02/08/2010 08:56 AM, Daniel P. Berrange wrote:
> > On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote:
> >
> >> On 02/08/2010 08:12 AM, Daniel P. Berrange wrote:
> >>
> >>> For further backgrou, the key end goal
On Mon, Feb 08, 2010 at 06:43:51PM +0100, Gerd Hoffmann wrote:
> On 02/08/10 18:37, Michael S. Tsirkin wrote:
>> On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote:
>>> On 02/08/10 18:32, Michael S. Tsirkin wrote:
On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote:
>
Most of these are obvious NULL-deref bug fixes, for example,
the ones in these files:
block/curl.c
net.c
slirp/misc.c
and the first one in block/vvfat.c.
The others in block/vvfat.c may not lead to an immediate segfault, but I
traced the two schedule_rename(..., strdup(path)) uses, and a fa
On Mon, Feb 08, 2010 at 07:56:27PM +0200, Blue Swirl wrote:
> On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote:
> > On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote:
> >> On 02/08/10 18:32, Michael S. Tsirkin wrote:
> >>> On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann
Jan Kiszka wrote:
Hi,
Seabios seems to have some assumptions built in that break when -M isapc
is selected. Is this supposed to work or is isapc about to die?
SeaBIOS doesn't POST if the F-segment is not writeable [1]. A possible, but IMO
wrong fix was posted on the list [2].
[1] http://lists
Add an assert() to qobject_from_jsonf() to assure that the returned
QObject is not NULL. Currently this is duplicated in the callers.
Signed-off-by: Luiz Capitulino
---
qjson.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/qjson.c b/qjson.c
index 9ad8a91..483c667 1
It's not needed to check the return of qobject_from_jsonf()
anymore, as an assert() has been added there.
Signed-off-by: Luiz Capitulino
---
block.c |3 ---
hw/pci-hotplug.c |1 -
migration.c |3 ---
monitor.c|5 -
4 files changed, 0 insertions(+), 12 de
Ideally, Monitor code should report an error only once and
return the error information up the call chain.
To assure that this happens as expected and that no error is
lost, we have an assert() in qemu_error_internal().
However, we still have not fully converted handlers using
monitor_printf() to
QMP's chardev event callback doesn't call
json_message_parser_destroy() on CHR_EVENT_CLOSED. As the call
to json_message_parser_init() on CHR_EVENT_OPENED allocates memory,
we'are leaking on close.
Fix that by just calling json_message_parser_destroy() on
CHR_EVENT_CLOSED.
Signed-off-by: Luiz Cap
Sebastian Herbszt wrote:
> Jan Kiszka wrote:
>> Hi,
>>
>> Seabios seems to have some assumptions built in that break when -M isapc
>> is selected. Is this supposed to work or is isapc about to die?
>
> SeaBIOS doesn't POST if the F-segment is not writeable [1]. A possible, but
> IMO
> wrong fix w
On 02/08/2010 12:25 PM, Luiz Capitulino wrote:
On Mon, 08 Feb 2010 09:13:37 -0600
Anthony Liguori wrote:
On 02/08/2010 08:56 AM, Daniel P. Berrange wrote:
On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote:
On 02/08/2010 08:12 AM, Daniel P. Berrange wrote:
On Mon, Feb 8, 2010 at 8:26 PM, Michael S. Tsirkin wrote:
> On Mon, Feb 08, 2010 at 07:56:27PM +0200, Blue Swirl wrote:
>> On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote:
>> > On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote:
>> >> On 02/08/10 18:32, Michael S. Tsirkin wrot
On Mon, Feb 08, 2010 at 09:32:54PM +0200, Blue Swirl wrote:
> On Mon, Feb 8, 2010 at 8:26 PM, Michael S. Tsirkin wrote:
> > On Mon, Feb 08, 2010 at 07:56:27PM +0200, Blue Swirl wrote:
> >> On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote:
> >> > On Mon, Feb 08, 2010 at 06:37:41PM +0100, G
Hi,
This still means we have two copies of same data
and need to maintain code that keeps them in sync,
even if that is called just at init time.
No. There is nothing to keep in sync. And there is no extra copy of data.
Today you have pci_set_*() calls somewhere in PCIDeviceInfo->init().
Should be applied on top of feature negotiation series.
changelog:
--
v0 -> v1:
- Document qobject_from_jsonf() new semantics
On Mon, 08 Feb 2010 13:14:24 -0600
Anthony Liguori wrote:
> On 02/08/2010 12:25 PM, Luiz Capitulino wrote:
> > On Mon, 08 Feb 2010 09:13:37 -0600
> > Anthony Liguori wrote:
> >
> >
> >> On 02/08/2010 08:56 AM, Daniel P. Berrange wrote:
> >>
> >>> On Mon, Feb 08, 2010 at 08:49:20AM -060
On Mon, Feb 08, 2010 at 08:55:58PM +0100, Gerd Hoffmann wrote:
> Hi,
>
>> This still means we have two copies of same data
>> and need to maintain code that keeps them in sync,
>> even if that is called just at init time.
>
> No. There is nothing to keep in sync. And there is no extra copy of d
On 02/08/2010 01:59 PM, Luiz Capitulino wrote:
Looks reasonable to me, what do think Daniel?
Note that if we agree on the 'context design', I'll have to change
VNC's events names..
Let me give you a few suggestions before diving into it. context might
not be the best name.
For eve
Increase VNC_MAX_WIDTH to match "commonly available" consumer level monitors
available these days.
This also closes KVM bug 2907597
Signed-off-by: Brian Jackson
---
vnc.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.h b/vnc.h
index 1210824..1575af2 100644
--- a
On 02/08/2010 11:35 AM, Amit Shah wrote:
On (Mon) Feb 08 2010 [08:57:05], Anthony Liguori wrote:
On 02/08/2010 07:46 AM, Amit Shah wrote:
Hello,
In my testing of virtio-console, I found qemu-kvm.git introduces a lot
of overhead in thread scheduling compared to qemu.git.
My test send
In article you write:
>On Tue, 19 Jan 2010, Anthony Liguori wrote:
>
>> On 01/17/2010 11:23 AM, Juergen Lock wrote:
>> > As suggested by Andreas F?rber, here is a cumulative patch that syncs
>> > OSS_GETVERSION handling with head by merging the following commits:
>> >
>> > 1. oss: issue OSS_GETVE
1 - 100 of 122 matches
Mail list logo
