[Qemu-devel] [PATCH 1/5] substitute all uses of which by type

Except in one case, we are only interested in knowing if a command exist, not is path. Just create prog_exists() function that does this check. Signed-off-by: Juan Quintela --- configure | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/configure

[Qemu-devel] [PATCH 0/5] Remove which use

This series substitute "which" use by "type" one. It is similar to Loïc patch, just that I didn't use path_of() because it was used just once. This addresses commets about using && instead of -a. It also remove the search for "grep" in kvm code. grep is assumed in lots of other places in configur

[Qemu-devel] [PATCH 4/5] Remove check for grep

The rest of configure assumes that grep is available already Signed-off-by: Juan Quintela --- configure |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 83f8b26..f31be87 100755 --- a/configure +++ b/configure @@ -1430,8 +1430,7 @@ EOF fi

[Qemu-devel] [PATCH 3/5] Add -static earlier to LDFLAGS for compile_prog()

From: Loïc Minier Add -static to LDFLAGS earlier as to run the compile_prog() tests with this flags, this will avoid turning on features for which a shared library is available but not a static one. Signed-off-by: Loïc Minier Signed-off-by: Juan Quintela --- configure |5 +++-- 1 files ch

[Qemu-devel] [PATCH 2/5] Check for sdl-config before calling it

Adapted Loïc Minier version to not use which. cc: Loïc Minier Signed-off-by: Juan Quintela --- configure |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 71edaf5..c671918 100755 --- a/configure +++ b/configure @@ -996,9 +996,15 @@ fi

[Qemu-devel] [PATCH 5/5] Fix missing symbols in .rel/.rela.plt sections

From: Loïc Minier Fix .rel.plt sections in the output to not only include .rel.plt sections from the input but also the .rel.iplt sections and to define the hidden symbols __rel_iplt_start and __rel_iplt_end around .rel.iplt as otherwise we get undefined references to these when linking staticall

Re: [Qemu-devel] [PATCH] make: qemu-img depends on config-host.h

Am 20.01.2010 um 17:12 schrieb Anthony Liguori: Fixes mingw32 build out of tree. Signed-off-by: Anthony Liguori --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b1bbe6d..60d5c66 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,

[Qemu-devel] [PATCH 0/7] *** SUBJECT HERE ***

*** BLURB HERE *** Juan Quintela (7): Rename --enable-uname-release Add PATH argument to options that need it Sort together all options that take arguments Add help to --cpu and --with-pkgversion Change --static to --enable-static Sort boolean options Add documentation for --enable/d

[Qemu-devel] [PATCH 1/7] Rename --enable-uname-release

It really sets uname string. It don't make sense a --disable option Signed-off-by: Juan Quintela --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 192338f..08ff6a2 100755 --- a/configure +++ b/configure @@ -578,7 +578,7 @@ for

[Qemu-devel] [PATCH 2/7] Add PATH argument to options that need it

Signed-off-by: Juan Quintela --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 08ff6a2..6175b75 100755 --- a/configure +++ b/configure @@ -779,9 +779,9 @@ echo " emulation targets" echo " --disable-

[Qemu-devel] [PATCH 3/7] Sort together all options that take arguments

Signed-off-by: Juan Quintela --- configure | 103 +++- 1 files changed, 53 insertions(+), 50 deletions(-) diff --git a/configure b/configure index 6175b75..1e6088c 100755 --- a/configure +++ b/configure @@ -60,12 +60,12 @@ audio_win_int="

[Qemu-devel] [PATCH 4/7] Add help to --cpu and --with-pkgversion

Signed-off-by: Juan Quintela --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 1e6088c..c9061e1 100755 --- a/configure +++ b/configure @@ -715,6 +715,7 @@ echo " Available cards: $audio_possible_cards"

[Qemu-devel] [PATCH 5/7] Change --static to --enable-static

This way it is consistent with everything else. Leave --static as compatible option, but don't document it Signed-off-by: Juan Quintela --- configure |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index c9061e1..f86fef3 100755 --- a/configu

[Qemu-devel] [PATCH 6/7] Sort boolean options

No code changes Signed-off-by: Juan Quintela --- configure | 285 +++-- 1 files changed, 144 insertions(+), 141 deletions(-) diff --git a/configure b/configure index f86fef3..046b0fb 100755 --- a/configure +++ b/configure @@ -477,164 +477

[Qemu-devel] [PATCH 7/7] Add documentation for --enable/disable-docs

Signed-off-by: Juan Quintela --- configure |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 046b0fb..9d315f4 100755 --- a/configure +++ b/configure @@ -758,6 +758,8 @@ echo " --disable-debug disable common debug build options" echo

Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

Luiz Capitulino writes: > Hi, > > This new version addresses Markus's comments. > > changelog > - > > V1 -> V2 > > - Make class_info's key 'desc' optional > - Better indentation > - Doc fixes > > V0 -> V1 > > - Coding style fixes > - Make 'BAR' and 'IRQ' keys lowercase > - Add 'irq' key

Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

On Wed, 20 Jan 2010 18:57:56 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Hi, > > > > This new version addresses Markus's comments. > > > > changelog > > - > > > > V1 -> V2 > > > > - Make class_info's key 'desc' optional > > - Better indentation > > - Doc fixes > > >

[Qemu-devel] Re: Stop using "which" in ./configure

Loïc Minier writes: > On Wed, Jan 20, 2010, Paolo Bonzini wrote: >> > Are you saying that I can't backup/restore IFS without setting it >> > first? >> Yes, it affects the behavior of read for example: >> $ echo a b c | (read a b c; echo $a; echo $b; echo $c) >> a >> b >> c >> $ IFS= >> $ echo a

[Qemu-devel] Re: sparc32 do_unassigned_access overhaul

On Tue, Jan 19, 2010 at 9:44 PM, Artyom Tarasenko wrote: > 2010/1/19 Blue Swirl : >> On Tue, Jan 19, 2010 at 5:30 PM, Artyom Tarasenko >> wrote: >>> 2010/1/15 Artyom Tarasenko : 2010/1/15 Blue Swirl : > On Fri, Jan 15, 2010 at 9:11 PM, Artyom Tarasenko > wrote: >> 2010/1/15 Blue

Re: [Qemu-devel] [PATCH 1/5] substitute all uses of which by type

Juan Quintela schrieb: > Except in one case, we are only interested in knowing if a command > exist, not is path. Just create prog_exists() function that does this > check. > > Signed-off-by: Juan Quintela See comments below. The changes proposed are a suggestion, no real need. Regards, Stefan

Re: [Qemu-devel] [PATCH] sparc64: reimplement tick timers v2

On Tue, Jan 19, 2010 at 10:24 PM, Igor Kovalenko wrote: > On Tue, Jan 19, 2010 at 9:44 PM, Blue Swirl wrote: >> On Mon, Jan 18, 2010 at 10:28 PM, Igor V. Kovalenko >> wrote: >>> From: Igor V. Kovalenko >>> >>> sparc64 timer has tick counter which can be set and read, >>> and tick compare value

[Qemu-devel] [PATCH 01/14] arm host: Fix compiler warning

Compilation for arm (native or cross) results in this warning: fpu/softfloat-native.c: In function ‘float64_round_to_int’: fpu/softfloat-native.c:387: error: control reaches end of non-void function float64_round_to_int uses special assembler code for arm and has no explicit return value. As the

[Qemu-devel] Re: [PATCH 1/5] substitute all uses of which by type

Stefan Weil wrote: > Juan Quintela schrieb: >> Except in one case, we are only interested in knowing if a command >> exist, not is path. Just create prog_exists() function that does this >> check. >> >> Signed-off-by: Juan Quintela > > See comments below. The changes proposed are a suggestion, no

Re: [Qemu-devel] [PATCH v2 0/5]: Convert pci_info() to QObject

On Wed, Jan 20, 2010 at 6:11 PM, Luiz Capitulino wrote: > On Wed, 20 Jan 2010 18:57:56 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> >  Hi, >> > >> >  This new version addresses Markus's comments. >> > >> > changelog >> > - >> > >> > V1 -> V2 >> > >> > - Make class_

[Qemu-devel] [PATCH] Fix generation of config-host.h

This patch improves Anthony patch a6a853c86275efd89996ce59612a000c5873db5d Once there, it improves handling of object files for qemu tools cc: Andreas Färber Signed-off-by: Juan Quintela --- Makefile | 17 + 1 files changed, 5 insertions(+), 12 deletions(-) diff --git a/Mak

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Jamie Lokier wrote: > Anthony Liguori wrote: >> On 01/18/2010 10:45 AM, john cooper wrote: >>> x86 Conroe Intel Celeron_4x0 (Conroe/Merom Class Core 2) >>> x86 Penryn Intel Core 2 Duo P9xxx (Penryn Class Core 2) >>> x86 Nehalem Intel Core i7 9xx (Nehalem

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Anthony Liguori wrote: > On 01/19/2010 02:03 PM, Chris Wright wrote: >> * Anthony Liguori (anth...@codemonkey.ws) wrote: >> >>> I'm very much against having -cpu Nehalem. The whole point of this is >>> to make things easier for a user and for most of the users I've >>> encountered, -cpu Nehalem

[Qemu-devel] [PATCH v2 00/17] Fix compilation with _FORTIFY_SOURCE

changes in v2: - we retry the write in the signal handler when error is -EINTR (just use the qemu_write_full() function) (spoted by Jamie Lokier) - we don't do arith on void * anymore (spoted by malc) and there were no more pending commets. you can get it as a branch at: git://repo.or.cz/qe

[Qemu-devel] [PATCH 02/17] force to test result for qemu_write_full()

Signed-off-by: Juan Quintela --- qemu-common.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index a2731e1..ae4f23b 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -161,7 +161,8 @@ void qemu_mutex_lock_iothread(void); void qemu_mutex_

[Qemu-devel] [PATCH 01/17] Introduce qemu_write_full()

From: Kirill A. Shutemov A variant of write(2) which handles partial write. Signed-off-by: Kirill A. Shutemov Signed-off-by: Juan Quintela --- osdep.c | 27 +++ qemu-common.h |1 + 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/osdep.c b/os

[Qemu-devel] [PATCH 03/17] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCposix-aio-compat.o cc1: warnings being treated as errors posix-aio-compat.c: In function 'aio_signal_handler': posix-aio-compat.c:505: error: ignoring return value of 'write', declared with attribute warn_unused_result make: *** [posix-aio-compat.o] Error 1 Signed

[Qemu-devel] [PATCH 05/17] block/qcow.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/qcow.o cc1: warnings being treated as errors block/qcow.c: In function 'qcow_create': block/qcow.c:804: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow.c:806: error: ignoring return value of 'write', declared wit

[Qemu-devel] [PATCH 04/17] block/cow.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/cow.o cc1: warnings being treated as errors block/cow.c: In function 'cow_create': block/cow.c:251: error: ignoring return value of 'write', declared with attribute warn_unused_result block/cow.c:253: error: ignoring return value of 'ftruncate', declared with

[Qemu-devel] [PATCH 06/17] block/vmdk.o: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/vmdk.o cc1: warnings being treated as errors block/vmdk.c: In function 'vmdk_snapshot_create': block/vmdk.c:236: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result block/vmdk.c: In function 'vmdk_create': block/vmdk.c:775:

[Qemu-devel] [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CCblock/vvfat.o In

[Qemu-devel] [PATCH 08/17] block/qcow2.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCblock/qcow2.o cc1: warnings being treated as errors block/qcow2.c: In function 'qcow_create2': block/qcow2.c:829: error: ignoring return value of 'write', declared with attribute warn_unused_result block/qcow2.c:838: error: ignoring return value of 'write', declare

[Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCnet/slirp.o cc1: warnings being treated as errors net/slirp.c: In function 'slirp_smb_cleanup': net/slirp.c:470: error: ignoring return value of 'system', declared with attribute warn_unused_result make: *** [net/slirp.o] Error 1 Signed-off-by: Kirill A. Shutemov

[Qemu-devel] [PATCH 11/17] vl.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCi386-softmmu/vl.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/vl.c: In function 'qemu_event_increment': /usr/src/RPM/BUILD/qemu-0.11.92/vl.c:3404: error: ignoring return value of 'write', declared with attribute warn_unused_result /usr/src

[Qemu-devel] [PATCH 10/17] usb-linux.c: fix warning with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCusb-linux.o cc1: warnings being treated as errors usb-linux.c: In function 'usb_host_read_file': usb-linux.c:1204: error: ignoring return value of 'fgets', declared with attribute warn_unused_result make: *** [usb-linux.o] Error 1 Signed-off-by: Kirill A. Shutemov

[Qemu-devel] [PATCH 12/17] monitor.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCi386-softmmu/monitor.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c: In function 'do_memory_save': /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c:1318: error: ignoring return value of 'fwrite', declared with attribute warn_unused_resul

[Qemu-devel] [PATCH 13/17] linux-user/mmap.c: fix warnings with _FORTIFY_SOURCE

From: Kirill A. Shutemov CCi386-linux-user/mmap.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c: In function 'mmap_frag': /usr/src/RPM/BUILD/qemu-0.11.92/linux-user/mmap.c:253: error: ignoring return value of 'pread', declared with attribute warn_unu

[Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2

From: Kirill A. Shutemov _FORTIFY_SOURCE is a Glibc feature which adds memory and string function protection. Signed-off-by: Kirill A. Shutemov Signed-off-by: Juan Quintela --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5631

[Qemu-devel] [PATCH 14/17] check pipe() return value

Signed-off-by: Juan Quintela --- hw/xen_domainbuild.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/xen_domainbuild.c b/hw/xen_domainbuild.c index 20d731d..2f59856 100644 --- a/hw/xen_domainbuild.c +++ b/hw/xen_domainbuild.c @@ -156,15 +156,18 @@ quit:

[Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all

Signed-off-by: Juan Quintela --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 5556b9d..d8af978 100755 --- a/configure +++ b/configure @@ -101,7 +101,7 @@ QEMU_CFLAGS="-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS" QEMU_CFLAGS="-I. -I\$(SRC_PA

[Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error

Signed-off-by: Juan Quintela --- linux-user/mmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index c1c7e48..25fc0b2 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -243,7 +243,7 @@ static int mmap_frag(abi_ulong real_

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Jamie Lokier wrote: > john cooper wrote: >> As before a cpu feature 'check' option is added which warns when >> feature flags (either implicit in a cpu model or explicit on the >> command line) would have otherwise been quietly unavailable to a >> guest: >> >> # qemu-system-x86_64 ... -cpu Neha

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

On Wed, Jan 20, 2010 at 03:09:53PM -0500, john cooper wrote: > Anthony Liguori wrote: > > On 01/19/2010 02:03 PM, Chris Wright wrote: > >> * Anthony Liguori (anth...@codemonkey.ws) wrote: > >> > >>> I'm very much against having -cpu Nehalem. The whole point of this is > >>> to make things easie

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

On 01/20/2010 02:26 PM, Daniel P. Berrange wrote: To be honest all possible naming schemes for '-cpu' are just as unfriendly as each other. The only user friendly option is '-cpu host'. IMHO, we should just pick a concise naming scheme& document it. Given they are all equally unfriendly, the on

[Qemu-devel] [PATCH] Tell users about out-of-memory errors

Aborting without an error message when memory is short is not helpful, so print the reason for the abort. Try qemu -m 100 to force an out-of-memory error. Signed-off-by: Stefan Weil --- osdep.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/osdep.c b/o

[Qemu-devel] [PATCH] Documentation: Add missing texi description for command line options

Some more command line options had entries for command line help, but documentation for texi and derived formats (man, html, info) was missing. For conditional options, the texi documentation was added unconditionally. This seems reasonable because typically man pages are shared, and html users e

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

On 01/20/2010 09:19 AM, identifier scorpio wrote: Below i'll append my newly generated patch against stable-0.10, in case it is mangled, i also put it in the attachment. For the record, the inline portion was again mangled; the attachment is fine. in qemu_ld/st, we must use $16,$17,$18 as t

[Qemu-devel] [PATCH 1/3] qdev: Add help for device properties

When called with property "?", a list of supported properties will be printed (instead of an error message). This is useful for command lines like qemu -device e1000,? and was already standard for other options like model=? Signed-off-by: Stefan Weil --- hw/qdev-properties.c | 15

[Qemu-devel] [PATCH 2/3] qdev: Add help for property value

When called with property value "?", a help text will be printed (instead of an error message). This is useful for command lines like qemu -device e1000,mac=? and is already standard for other command line options. A better help text could be provided by extending the Property structure w

[Qemu-devel] [PATCH 3/3] Documentation: Improve command line help for -device option

* Fix column for help text. * Give some more help, especially for the new '?' parameters. Signed-off-by: Stefan Weil --- qemu-options.hx | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index ee60d8a..ef82cac 100644 --- a/

Re: [Qemu-devel] [PATCH] Documentation: Add missing documentation for qdev related command line options

Markus Armbruster schrieb: > Stefan Weil writes: > >> Markus Armbruster schrieb: >>> Stefan Weil writes: >>> The command line options -device, -nodefaults, -readconfig, -writeconfig had entries for command line help, but documentation for texi and derived formats (man, html, info)

[Qemu-devel] Re: [PATCH 01/14] arm host: Fix compiler warning

Stefan Weil schrieb: > Compilation for arm (native or cross) results in this > warning: > > fpu/softfloat-native.c: In function ‘float64_round_to_int’: > fpu/softfloat-native.c:387: error: control reaches end of non-void function > > float64_round_to_int uses special assembler code for arm > and ha

Re: [Qemu-devel] [PATCH] Tell users about out-of-memory errors

On Wed, 20 Jan 2010, Stefan Weil wrote: > Aborting without an error message when memory is short > is not helpful, so print the reason for the abort. > > Try > qemu -m 100 > to force an out-of-memory error. The patch is wrong for, at least, Windows. > > Signed-off-by: Stefan Weil >

[Qemu-devel] Re: [PATCH] Add definitions for current cpu models..

On Monday 18 January 2010, john cooper wrote: > +.name = "Conroe", > +.level = 2, > +.vendor1 = CPUID_VENDOR_INTEL_1, > +.vendor2 = CPUID_VENDOR_INTEL_2, > +.vendor3 = CPUID_VENDOR_INTEL_3, > +.family = 6, /* P6 */ > +.model = 2,

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

* Daniel P. Berrange (berra...@redhat.com) wrote: > To be honest all possible naming schemes for '-cpu ' are just as > unfriendly as each other. The only user friendly option is '-cpu host'. > > IMHO, we should just pick a concise naming scheme & document it. Given > they are all equally unfriend

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

Chris Wright wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: >> To be honest all possible naming schemes for '-cpu ' are just as >> unfriendly as each other. The only user friendly option is '-cpu host'. >> >> IMHO, we should just pick a concise naming scheme & document it. Given >> the

Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform

Thank Mr. Weil for your reply.   > > Maybe you can also try the TCG interpreter (TCI) from > http://repo.or.cz/w/qemu/ar7.git. > In theory, it supports any host architecture with or > without native TCG > support. > > It was tested successful with some basic tests on x86, > mips, ppc and arm, > s

[Qemu-devel] possible qemu miscompilation by latest gcc

Hi folks- Just wanted to let you know that perhaps the function helper_neon_rshl_s8() is being miscompiled by the latest gcc. I'm using qemu 0.12.2 and gcc rev 156103, which is a pre-version of gcc 4.5. This is on an x86 machine running Ubuntu 9.10. At -O2 or higher this is the resulting o

Re: [Qemu-devel] [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote: > From: Kirill A. Shutemov > > CCblock/vvfat.o > cc1: warnings being treated as errors > block/vvfat.c: In function 'commit_one_file': > block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared > with attribute w

Re: [Qemu-devel] Stop using "which" in ./configure

On Tue, Jan 19, 2010, Stefan Weil wrote: > I did not test the whole patch, but I think this would be better: > +type "$local_command" >/dev/null 2>&1 Attaching an updated patch Thanks -- Loïc Minier >From 1c0b63fb9fc735a6d367a65a6ed1b998942fb6a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?

Re: [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount

Am 19.01.2010 19:51, schrieb Christoph Hellwig: > On Mon, Jan 18, 2010 at 01:11:33PM +0100, Kevin Wolf wrote: >> If update_refcount fails, try to undo any changes made so far to avoid >> inconsistencies in the image file. >> >> Signed-off-by: Kevin Wolf >> --- >> block/qcow2-refcount.c | 32 +++

Re: [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts

Am 19.01.2010 19:53, schrieb Christoph Hellwig: >> #endif >> -if (length <= 0) >> +if (length < 0) { >> return -EINVAL; >> +} >> + >> start = offset & ~(s->cluster_size - 1); >> last = (offset + length - 1) & ~(s->cluster_size - 1); >> for(cluster_offset = start

Re: [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters return value

Am 19.01.2010 19:58, schrieb Christoph Hellwig: > On Mon, Jan 18, 2010 at 01:11:36PM +0100, Kevin Wolf wrote: >> @@ -55,6 +55,9 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size) >> >> /* write new table (align to cluster) */ >> new_l1_table_offset = qcow2_alloc_clusters(bs,

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: > On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: > > From: Kirill A. Shutemov > > > > CC    block/vvfat.o > > cc1: warnings being treated as errors > > block/vvfat.c: In function 'commit_one_file': > > block/vvfat.c:2259:

Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to

On Wed, Jan 20, 2010 at 08:26:56AM +0100, Markus Armbruster wrote: > Jamie Lokier writes: > > > Michael S. Tsirkin wrote: > >> On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: > >> > BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't have > >> > BDRV_DONT_SNAPSHOT, either

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange wrote: > On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: >> On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: >> > From: Kirill A. Shutemov >> > >> > CC    block/vvfat.o >> > cc1: warnings being treated as errors >> > b

Re: [Qemu-devel] Re: Stop using "which" in ./configure

On Tue, Jan 19, 2010, Måns Rullgård wrote: [...] > Why the extra variable? Using $1 directly seems just as obvious to me. [...] I'm attaching an updated patch which doesn't use this variable. Should be applied after the sdl-config patch. > Is the full path of these tools really important? Do

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

Am 19.01.2010 22:15, schrieb Christoph Hellwig: > If we go over the maximum number of iovecs support by syscall we get > back EINVAL from the kernel which translate to I/O errors for the guest. > > Signed-off-by: Christoph Hellwig Is this really enough? We don't check for IOV_MAX in any other pl

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: > On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange > wrote: >> On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: >>> On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: From: Kirill A. Shutemov CCblock/vv

[Qemu-devel] [PATCH v2 3/6] monitor: convert do_memory_save() to QError

Signed-off-by: Markus Armbruster --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index c22901f..e63d0a7 100644 --- a/monitor.c +++ b/monitor.c @@ -1317,7 +1317,7 @@ static void do_memory_save(Monitor *mon, const QDict *qdict, QObject

[Qemu-devel] [PATCH v2 1/6] monitor: Don't check for mon_get_cpu() failure

mon_get_cpu() can't return null pointer, because it passes its return value to cpu_synchronize_state() first, which crashes if its argument is null. Remove the (pretty cheesy) handling of this non-existing error. Signed-off-by: Markus Armbruster --- monitor.c | 39 +++-

[Qemu-devel] [PATCH v2 6/6] monitor: convert do_cpu_set() to QObject, QError

Signed-off-by: Markus Armbruster --- monitor.c |4 ++-- qemu-monitor.hx |3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 816f6fd..b9166c3 100644 --- a/monitor.c +++ b/monitor.c @@ -808,11 +808,11 @@ static void do_info_cpus(Monitor

[Qemu-devel] [PATCH v2 5/6] QError: New QERR_INVALID_CPU_INDEX

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 2f657f4..6c2aba0 100644 --- a/qerror.c +++ b/qerror.c @@ -81,6 +81,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH v2 0/6] Convert memsave, pmemsave, cpu to QObject+QError

First patch is cleanup to get rid of an error that can't happen. Rest are straightforward conversions. v2: Renames suggested by Luiz, typo fixed, rebased Markus Armbruster (6): monitor: Don't check for mon_get_cpu() failure QError: New QERR_OPEN_FILE_FAILED monitor: convert do_memory_save(

[Qemu-devel] [PATCH v2 4/6] monitor: convert do_physical_memory_save() to QError

Signed-off-by: Markus Armbruster --- monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index e63d0a7..816f6fd 100644 --- a/monitor.c +++ b/monitor.c @@ -1344,7 +1344,7 @@ static void do_physical_memory_save(Monitor *mon, const QDict *qdict

[Qemu-devel] [PATCH v2 2/6] QError: New QERR_OPEN_FILE_FAILED

Signed-off-by: Markus Armbruster --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 5f8fc5d..2f657f4 100644 --- a/qerror.c +++ b/qerror.c @@ -73,6 +73,10 @@ static const QErrorStringTable qerror_table[] = {

Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to

"Michael S. Tsirkin" writes: > On Wed, Jan 20, 2010 at 08:26:56AM +0100, Markus Armbruster wrote: >> Jamie Lokier writes: >> >> > Michael S. Tsirkin wrote: >> >> On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: >> >> > BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

Kevin Wolf writes: > Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: >> On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange >> wrote: >>> On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: On Wed, Jan 20, 2010 at 1:56 AM, Juan Quintela wrote: [...] > diff --git a/blo

[Qemu-devel] Re: Stop using "which" in ./configure

On 01/20/2010 12:37 PM, Loïc Minier wrote: +# not found +IFS="$local_ifs" If you do this, you should set IFS to space-tab-lf at the beginning of the script, like this: IFS=" "" "" " or this (better because it does not rely on embedding whitespace characters within the line): IFS=

Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to

On Wed, Jan 20, 2010 at 01:09:29PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Jan 20, 2010 at 08:26:56AM +0100, Markus Armbruster wrote: > >> Jamie Lokier writes: > >> > >> > Michael S. Tsirkin wrote: > >> >> On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Arm

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

On Wed, Jan 20, 2010 at 2:15 PM, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: >>> On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange >>> wrote: On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A. Shutemov wrote: > On Wed, Jan 20,

[Qemu-devel] [PATCH] QMP: Fix asynchronous events delivery

Commit f039a563f200beee80cc10fd70b21ea396979dab introduces a regression as monitor_protocol_event() will return in the first user Monitor it finds in the QLIST_FOREACH() loop. The right thing to do is to only delivery an asynchronous event if the 'mon' is a QMP Monitor. The aforementioned commit

[Qemu-devel] Re: Stop using "which" in ./configure

Loïc Minier wrote: > On Tue, Jan 19, 2010, Måns Rullgård wrote: > [...] >> Why the extra variable? Using $1 directly seems just as obvious to me. > [...] > > I'm attaching an updated patch which doesn't use this variable. Should > be applied after the sdl-config patch. > >> Is the full path of

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

"Kirill A. Shutemov" writes: > On Wed, Jan 20, 2010 at 2:15 PM, Markus Armbruster wrote: >> Kevin Wolf writes: >> >>> Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: On Wed, Jan 20, 2010 at 12:33 PM, Daniel P. Berrange wrote: > On Wed, Jan 20, 2010 at 08:19:26AM +0200, Kirill A.

Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to

"Michael S. Tsirkin" writes: > On Wed, Jan 20, 2010 at 01:09:29PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Wed, Jan 20, 2010 at 08:26:56AM +0100, Markus Armbruster wrote: >> >> Jamie Lokier writes: >> >> >> >> > Michael S. Tsirkin wrote: >> >> >> On Mon, Jan

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

On Wed, Jan 20, 2010 at 02:03:04PM +0100, Markus Armbruster wrote: > "Kirill A. Shutemov" writes: > > > On Wed, Jan 20, 2010 at 2:15 PM, Markus Armbruster > > wrote: > >> Kevin Wolf writes: > >> > >>> Am 20.01.2010 12:09, schrieb Kirill A. Shutemov: > On Wed, Jan 20, 2010 at 12:33 PM, Dan

[Qemu-devel] Re: Stop using "which" in ./configure

On 01/20/2010 01:49 PM, Juan Quintela wrote: + if prog_exist "awk" -a \ + prog_exist "grep"; then + if prog_exist "texi2html" -a \ + prog_exist "pod2man" ; then -a is wrong here. BTW, it's evil for test too because its precedence rules WRT ! and -f/-n/-z/-x/etc. are broke

Re: [Qemu-devel] [PATCH v2 0/6] Convert memsave, pmemsave, cpu to QObject+QError

On Wed, 20 Jan 2010 13:07:29 +0100 Markus Armbruster wrote: > First patch is cleanup to get rid of an error that can't happen. Rest > are straightforward conversions. Looks good to me.

Re: [Qemu-devel] Re: [PATCH v2 2/4] Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to

Michael S. Tsirkin wrote: > On Wed, Jan 20, 2010 at 08:26:56AM +0100, Markus Armbruster wrote: > > Jamie Lokier writes: > > > > > Michael S. Tsirkin wrote: > > >> On Mon, Jan 18, 2010 at 11:34:59AM +0100, Markus Armbruster wrote: > > >> > BDRV_O_RDWR is a flag, just like BDRV_SNAPSHOT. We don't

[Qemu-devel] [PATCH][rtc hack]: reduce number of reinjects on ACK

Windows 7 BSODs under load with HAL_RTC_IRQF_WILL_NOT_CLEAR error. It happens here: hal!HalpRtcUnmaskClock: 8281b93a 8bffmov edi,edi 8281b93c 56 pushesi 8281b93d 33f6xor esi,esi 8281b93f 6a0cpush0Ch 8281b941 e8b2ff callh

[Qemu-devel] [PATCH 1/3] net: Make inet_strfamily() public

So that it can be used by other subsystems. Signed-off-by: Luiz Capitulino --- qemu-sockets.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 8850516..720de22 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c

[Qemu-devel] [PATCH 0/3]: Small VNC related cleanup

This series makes VNC events code use inet_strfamily() from qemu-socket instead of duplicating code, as suggested by Gerd. Thanks.

[Qemu-devel] [PATCH 2/3] net: inet_strfamily(): Better unknown family report

Returning "" is a bit meaningless, let's call it "unknown". Signed-off-by: Luiz Capitulino --- qemu-sockets.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index 720de22..d912fed 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -

[Qemu-devel] [PATCH 3/3] vnc: Use inet_strfamily()

Signed-off-by: Luiz Capitulino --- vnc.c | 22 +- 1 files changed, 1 insertions(+), 21 deletions(-) diff --git a/vnc.c b/vnc.c index c7d6652..cc2a26e 100644 --- a/vnc.c +++ b/vnc.c @@ -100,26 +100,6 @@ char *vnc_socket_remote_addr(const char *format, int fd) { return a

Re: [Qemu-devel] Re: Stop using "which" in ./configure

On Wed, Jan 20, 2010, Paolo Bonzini wrote: > On 01/20/2010 12:37 PM, Loïc Minier wrote: > >+# not found > >+IFS="$local_ifs" > If you do this, you should set IFS to space-tab-lf at the beginning of > the script, like this: > > IFS=" "" "" > " Are you saying that I can't backup/rest

Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE

On Wed, Jan 20, 2010 at 3:03 PM, Markus Armbruster wrote: > "Kirill A. Shutemov" writes: >> No, compiler can't add anything between. 'char' is always byte-aligned. > > You got some reading to do then. Do you want to say that it's not true? Could you provide an example when 'char' isn't byte-alig

  1   2   >