Am 19.01.2010 19:58, schrieb Christoph Hellwig: > On Mon, Jan 18, 2010 at 01:11:36PM +0100, Kevin Wolf wrote: >> @@ -55,6 +55,9 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size) >> >> /* write new table (align to cluster) */ >> new_l1_table_offset = qcow2_alloc_clusters(bs, new_l1_size2); >> + if (new_l1_table_offset < 0) { >> + return new_l1_table_offset; >> + } > > I think the error return needs to free new_l1_table first.
Right. Actually, I have found this bug already and included the fix in patch 11/10 which contains the fix to the problem you found with patch 1 (however, I wasn't aware any more that I introduced it myself). Maybe I should better respin the series instead of posting patch 11 on top. Kevin