Ján Tomko writes:
> On a Friday in 2023, Markus Armbruster wrote:
>>> { "sandbox", NULL, QEMU_CAPS_SECCOMP_SANDBOX },
>>
>>Does option -sandbox exist?
>>
>>It does since v1.2. If CONFIG_SECCOMP is off, actually using it is a
>>fatal error. Compiling out the option entirely would be more use
On a Friday in 2023, Markus Armbruster wrote:
{ "sandbox", NULL, QEMU_CAPS_SECCOMP_SANDBOX },
Does option -sandbox exist?
It does since v1.2. If CONFIG_SECCOMP is off, actually using it is a
fatal error. Compiling out the option entirely would be more useful, I
guess.
Is this probe stil
Stefan, one question regarding your commit 40e07370f21 inline.
Peter Krempa writes:
[...]
> In fact I strive to eliminate it after your suggestions, but we can't
> still detect the few outstanding flags from anywhere else.
>
> List of currently outstanding queries using q
From: Claudio Imbrenda
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
Reported-by: Boris Fiuczynski
From: Claudio Imbrenda
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
Reported-by: Boris Fiuczynski
On 05/05/2023 14.00, Claudio Imbrenda wrote:
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it
On 05/05/2023 14.00, Claudio Imbrenda wrote:
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
Reported
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
Reported-by: Boris Fiuczynski
Fixes: c891c24b1a (&qu
Add new -run-with option with an async-teardown=on|off parameter. It
is visible in the output of query-command-line-options QMP command, so
it can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
v6->v7
* move variable declaration inside #ifdef
On Fri, 28 Apr 2023 14:16:42 +0200
Thomas Huth wrote:
> On 28/04/2023 13.12, Claudio Imbrenda wrote:
> > Add new -run-with option with an async-teardown=on|off parameter. It is
> > visible in the output of query-command-line-options QMP command, so it
> > can be discovere
On 28/04/2023 13.12, Claudio Imbrenda wrote:
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
Reported
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
Reported-by: Boris Fiuczynski
Fixes: c891c24b1a (&qu
Add new -run-with option with an async-teardown=on|off parameter. It
is visible in the output of query-command-line-options QMP command, so
it can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
v5->v6
* deprecate the old -async-teardown opt
Thomas Huth writes:
> On 28/03/2023 07.26, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> I am honestly not a fan of adding a more complex option,.just because
>>> query-command-line-options only returns the square holes whereas here we
>>&g
On 28/03/2023 07.26, Markus Armbruster wrote:
Paolo Bonzini writes:
I am honestly not a fan of adding a more complex option,.just because
query-command-line-options only returns the square holes whereas here we
got a round one.
Can we imagine another functionality that would be added to
Paolo Bonzini writes:
> I am honestly not a fan of adding a more complex option,.just because
> query-command-line-options only returns the square holes whereas here we
> got a round one.
>
> Can we imagine another functionality that would be added to -teardown? If
> not, it&#
I am honestly not a fan of adding a more complex option,.just because
query-command-line-options only returns the square holes whereas here we
got a round one.
Can we imagine another functionality that would be added to -teardown? If
not, it's not a good design. If it works, I would
Add new -teardown option with an async=on|off parameter. It is visible
in the output of query-command-line-options QMP command, so it can be
discovered and used by libvirt.
The option -async-teardown is now redundant. We'd normally deprecate it
and remove it after a grace period, but i
Add new -teardown option with an async=on|off parameter. It is visible
in the output of query-command-line-options QMP command, so it can be
discovered and used by libvirt.
The option -async-teardown is now redundant. We'd normally deprecate it
and remove it after a grace period, but i
Claudio Imbrenda writes:
> The recently introduced -async-teardown commandline option was not
> wired up properly and did not show up in the output of the QMP command
> query-command-line-options. This means that libvirt had no way to
> discover whether the feature was supported.
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by adding a new
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt had no way to
discover whether the feature was supported.
This patch fixes the issue by replacing the
On 24/03/2023 18.45, Claudio Imbrenda wrote:
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported
-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by correctly wiring up the commandline
option so that it appears in the output of query-command-line-options.
Reported-by: Boris Fiuczynski
Fixes: c891c24b1a (&qu
On Fri, 24 Mar 2023 18:56:06 +0100
Thomas Huth wrote:
> On 24/03/2023 18.45, Claudio Imbrenda wrote:
> > The recently introduced -async-teardown commandline option was not
> > wired up properly and did not show up in the output of the QMP command
> > query-command-line-opt
On 24/03/2023 18.45, Claudio Imbrenda wrote:
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by correctly
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by adding a new
rg/archive/html/qemu-devel/2022-08/msg04479.html
>
> ?
>
> Anyway, how to continue now here? If I've got that right, we currently need
> an option that takes a parameter if we want to make it visible via QAPI,
> right?
Visible in query-command-line-options, to be precise.
On 22/03/2023 10.28, Daniel P. Berrangé wrote:
On Tue, Mar 21, 2023 at 09:47:57PM +0100, Paolo Bonzini wrote:
Il lun 20 mar 2023, 16:42 Thomas Huth ha scritto:
Would it make sense to add it e.g. to "-action" instead, i.e. something
like
"-action teardown=async" ?
-action is just a wrapper
On Tue, Mar 21, 2023 at 09:47:57PM +0100, Paolo Bonzini wrote:
> Il lun 20 mar 2023, 16:42 Thomas Huth ha scritto:
>
> > Would it make sense to add it e.g. to "-action" instead, i.e. something
> > like
> > "-action teardown=async" ?
> >
>
> -action is just a wrapper for the action-set QMP comman
Il lun 20 mar 2023, 16:42 Thomas Huth ha scritto:
> Would it make sense to add it e.g. to "-action" instead, i.e. something
> like
> "-action teardown=async" ?
>
-action is just a wrapper for the action-set QMP command. I don't think it
fits very well; its arguments are only guest actions while
>>> wired up properly and did not show up in the output of the QMP command
> >>> query-command-line-options. This means that libvirt will have no way to
> >>> discover whether the feature is supported.
> >>
> >> There was nothing imprope
Thomas Huth writes:
> On 20/03/2023 16.31, Markus Armbruster wrote:
>> Claudio Imbrenda writes:
>>
>>> The recently introduced -async-teardown commandline option was not
>>> wired up properly and did not show up in the output of the QMP command
>>> q
On 20/03/2023 16.31, Markus Armbruster wrote:
Claudio Imbrenda writes:
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover
Claudio Imbrenda writes:
> The recently introduced -async-teardown commandline option was not
> wired up properly and did not show up in the output of the QMP command
> query-command-line-options. This means that libvirt will have no way to
> discover whether the feature is supported
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by correctly
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by correctly
On Mon, 20 Mar 2023 09:56:05 +0100
Thomas Huth wrote:
> On 20/03/2023 08.48, Claudio Imbrenda wrote:
> > The recently introduced -async-teardown commandline option was not
> > wired up properly and did not show up in the output of the QMP command
> > query-command-line-opt
On 20/03/2023 08.48, Claudio Imbrenda wrote:
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported
The recently introduced -async-teardown commandline option was not
wired up properly and did not show up in the output of the QMP command
query-command-line-options. This means that libvirt will have no way to
discover whether the feature is supported.
This patch fixes the issue by correctly
> > I think it would be worthwile to check with the QEMU developers and
> > make sure that they're aware of this behavior. Is it intended? Is it
> > documented anywhere? It certainly seems extremely confusing to me.
>
> query-command-line-options has... issues.
>
>
x27;re checking whether -acpi itself exists as a
>> > top-level option. Which it doesn't, but -no-acpi does and yet it
>> > doesn't seem to be advertised in the output of
>> > query-command-line-options?
>>
>> Well, it actually does exist in the o
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This is pretty much out of sync with reality, for example settings
like "kvm_shadow_mem" or "accel" are not parameters fo
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This is pretty much out of sync with reality, for example settings
like "kvm_shadow_mem" or "accel" are not parameters fo
Thomas Huth writes:
> On 15/11/2022 08.53, Markus Armbruster wrote:
>> Thomas Huth writes:
>>
>>> On 11/11/2022 15.53, Markus Armbruster wrote:
>>>> Thomas Huth writes:
>>>>
>>>>> The "query-command-line-options" comm
On 15/11/2022 08.53, Markus Armbruster wrote:
Thomas Huth writes:
On 11/11/2022 15.53, Markus Armbruster wrote:
Thomas Huth writes:
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This i
Thomas Huth writes:
> On 11/11/2022 15.53, Markus Armbruster wrote:
>> Thomas Huth writes:
>>
>>> The "query-command-line-options" command uses a hand-crafted list
>>> of options that should be returned for the "machine" parameter.
>>
On 11/11/2022 15.53, Markus Armbruster wrote:
Thomas Huth writes:
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This is pretty much out of sync with reality, for example settings
like
Thomas Huth writes:
> The "query-command-line-options" command uses a hand-crafted list
> of options that should be returned for the "machine" parameter.
> This is pretty much out of sync with reality, for example settings
> like "kvm_shadow_mem" or
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This is pretty much out of sync with reality, for example settings
like "kvm_shadow_mem" or "accel" are not parameters fo
On 09/11/2022 09.44, Thomas Huth wrote:
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This is pretty much out of sync with reality, for example settings
like "kvm_shadow_mem" or &quo
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This is pretty much out of sync with reality, for example settings
like "kvm_shadow_mem" or "accel" are not parameters fo
From: Marc-André Lureau
Direct leak of 160 byte(s) in 4 object(s) allocated from:
#0 0x55ed7678cda8 in calloc
(/home/elmarco/src/qq/build/x86_64-softmmu/qemu-system-x86_64+0x797da8)
#1 0x7f3f5e725f75 in g_malloc0
/home/elmarco/src/gnome/glib/builddir/../glib/gmem.c:124
#2 0x55ed778a
From: Marc-André Lureau
Direct leak of 160 byte(s) in 4 object(s) allocated from:
#0 0x55ed7678cda8 in calloc
(/home/elmarco/src/qq/build/x86_64-softmmu/qemu-system-x86_64+0x797da8)
#1 0x7f3f5e725f75 in g_malloc0
/home/elmarco/src/gnome/glib/builddir/../glib/gmem.c:124
#2 0x55ed778a
Direct leak of 160 byte(s) in 4 object(s) allocated from:
#0 0x55ed7678cda8 in calloc
(/home/elmarco/src/qq/build/x86_64-softmmu/qemu-system-x86_64+0x797da8)
#1 0x7f3f5e725f75 in g_malloc0
/home/elmarco/src/gnome/glib/builddir/../glib/gmem.c:124
#2 0x55ed778aa3a7 in query_option_descs
On 12/15/2017 09:06 AM, Marc-André Lureau wrote:
> Direct leak of 160 byte(s) in 4 object(s) allocated from:
> #0 0x55ed7678cda8 in calloc
> (/home/elmarco/src/qq/build/x86_64-softmmu/qemu-system-x86_64+0x797da8)
> #1 0x7f3f5e725f75 in g_malloc0
> /home/elmarco/src/gnome/glib/builddir/../
Direct leak of 160 byte(s) in 4 object(s) allocated from:
#0 0x55ed7678cda8 in calloc
(/home/elmarco/src/qq/build/x86_64-softmmu/qemu-system-x86_64+0x797da8)
#1 0x7f3f5e725f75 in g_malloc0
/home/elmarco/src/gnome/glib/builddir/../glib/gmem.c:124
#2 0x55ed778aa3a7 in query_option_descs
Direct leak of 160 byte(s) in 4 object(s) allocated from:
#0 0x55ed7678cda8 in calloc
(/home/elmarco/src/qq/build/x86_64-softmmu/qemu-system-x86_64+0x797da8)
#1 0x7f3f5e725f75 in g_malloc0
/home/elmarco/src/gnome/glib/builddir/../glib/gmem.c:124
#2 0x55ed778aa3a7 in query_option_descs
Recently we moved a few options from QemuOptsLists in blockdev.c to
bdrv_runtime_opts in block.c in order to make them accissble using
blockdev-add. However, this has the side effect that these options are
missing from query-command-line-options now, and libvirt consequently
disables the
ts to the list of QemuOptsLists that are
> returned in query-command-line-options. For the future, libvirt is
> advised to use QMP schema introspection for block device options.
>
> Reported-by: Michal Privoznik
> Signed-off-by: Kevin Wolf
Tested-by: Gerd Hoffmann
> ---
>
dd. However, this has the side effect that these options are
> >missing from query-command-line-options now, and libvirt consequently
> >disables the corresponding feature.
> >
> >This problem was reported as a regression for the 'discard' option,
> >introdu
eturned in query-command-line-options. For the future, libvirt is
advised to use QMP schema introspection for block device options.
Reported-by: Michal Privoznik
Signed-off-by: Kevin Wolf
---
block.c | 2 +-
include/sysemu/sysemu.h | 1 +
util/qemu-config.c |
On 06.10.2016 11:40, Kevin Wolf wrote:
> Recently we moved a few options from QemuOptsLists in blockdev.c to
> bdrv_runtime_opts in block.c in order to make them accissble using
> blockdev-add. However, this has the side effect that these options are
> missing from query-command-line
Recently we moved a few options from QemuOptsLists in blockdev.c to
bdrv_runtime_opts in block.c in order to make them accissble using
blockdev-add. However, this has the side effect that these options are
missing from query-command-line-options now, and libvirt consequently
disables the
From: Chunyan Liu
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
Signed-off-by: Stefan Hajnoczi
---
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
qapi-schema.json | 5 -
qmp-commands.hx| 2
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
qapi-schema.json | 5 -
qmp-commands.hx| 2
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
qapi-schema.json | 5 -
qmp-commands.hx| 2
On Tue, Apr 29, 2014 at 05:10:28PM +0800, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> Changes to V25:
> * update @default description in .json file
On Tue, Apr 29, 2014 at 05:08:13PM +0800, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
Reviewed-by: Leandro Dorileo
> ---
> Changes to V25:
> * update
On 04/29/2014 03:10 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> Changes to V25:
> * update @default description in .json file
>
> qapi-schema
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
Changes to V25:
* update @default description in .json file
qapi-schema.json | 5 -
qmp-commands.hx| 2 ++
util/qemu-config.
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
Changes to V25:
* update @default description in .json file
qapi-schema.json | 5 -
qmp-commands.hx| 2 ++
util/qemu-config.
On 04/10/2014 11:53 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> changes:
> * Following Leandro's comment:
> upda
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
changes:
* Following Leandro's comment:
update description of @default
qapi-schema.json | 6 +-
qmp
On Thu, Apr 03, 2014 at 05:54:21PM +0800, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> qapi-schema.json | 6 +-
> qm
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
qapi-schema.json | 6 +-
qmp-commands.hx| 2 ++
util/qemu-config.c | 4
3 files changed, 11 inser
03/05/2014 07:36 PM, Amos Kong wrote:
>> >> >> vm_config_groups[] only contains part of the options which have
>> >> >> argument, and all options which have no argument aren't added
>> >> >> to vm_config_groups[]. Current query-command-line-
On Thu, Mar 27, 2014 at 02:57:00PM +0800, Amos Kong wrote:
> This patchset fixed some issues of query-command-line-options:
> * some new options that haven't argument can't be queried. (eg: -enable-fips)
> * some legacy options that have argument can't be queried. (eg:
vm_config_groups[] only contains part of the options which have
parameters, and all options which have no parameter aren't added
to vm_config_groups[]. Current query-command-line-options only
checks options from vm_config_groups[], so some options will
be lost.
We have macro in qemu-options.
This patch added a new field to expose implicit parameter name,
we make it optional for compatibility.
Suggested-by: Eric Blake
Signed-off-by: Amos Kong
---
qapi-schema.json | 6 +-
util/qemu-config.c | 24 +++-
2 files changed, 20 insertions(+), 10 deletions(-)
diff
This patchset fixed some issues of query-command-line-options:
* some new options that haven't argument can't be queried. (eg: -enable-fips)
* some legacy options that have argument can't be queried. (eg: -vnc display)
More discussion:
http://marc.info/?l=qemu-devel&m=
> > >>> On 03/05/2014 07:36 PM, Amos Kong wrote:
> > >>>> vm_config_groups[] only contains part of the options which have
> > >>>> argument, and all options which have no argument aren't added
> > >>>> to vm_config_groups[]. Curr
gt; >> vm_config_groups[] only contains part of the options which have
> >> >> argument, and all options which have no argument aren't added
> >> >> to vm_config_groups[]. Current query-command-line-options only
> >> >> checks options from vm_
t, and all options which have no argument aren't added
>> >> to vm_config_groups[]. Current query-command-line-options only
>> >> checks options from vm_config_groups[], so some options will
>> >> be lost.
>> >>
>> >> We have macro in qemu
On Tue, Mar 11, 2014 at 06:46:10PM -0600, Eric Blake wrote:
> On 03/06/2014 11:09 PM, Amos Kong wrote:
> > vm_config_groups[] only contains part of the options which have
> > parameters, and all options which have no parameter aren't added
> > to vm_config_groups[].
I'll update.
All patch series could also be available from:
https://github.com/chunyanliu/qemu/commits/QemuOpts
>>> On 3/22/2014 at 07:27 AM, in message <532ccadc.40...@redhat.com>, Eric Blake
wrote:
> On 03/21/2014 04:12 AM, Chunyan Liu wrote:
> > Change qapi interfaces to output the newly add
On 03/20/2014 06:13 PM, Leandro Dorileo wrote:
> From: Chunyan Liu
>
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> qapi-schema.json | 6 +-
> qmp-commands.hx
On 03/21/2014 04:12 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> qapi-schema.json | 6 +-
> qmp-commands.hx|
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
qapi-schema.json | 6 +-
qmp-commands.hx| 2 ++
util/qemu-config.c | 4
3 files changed, 11 inser
From: Chunyan Liu
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
qapi-schema.json | 6 +-
qmp-commands.hx| 2 ++
util/qemu-config.c | 4
3 files changed, 11 insertions
ions which have
> > >> argument, and all options which have no argument aren't added
> > >> to vm_config_groups[]. Current query-command-line-options only
> > >> checks options from vm_config_groups[], so some options will
> > >> be lost.
> &g
fig_groups[] only contains part of the options which have
> >>>> argument, and all options which have no argument aren't added
> >>>> to vm_config_groups[]. Current query-command-line-options only
> >>>> checks options from vm_config_groups[], so some opt
27;t added
> >> to vm_config_groups[]. Current query-command-line-options only
> >> checks options from vm_config_groups[], so some options will
> >> be lost.
> >>
> >> We have macro in qemu-options.hx to generate a table that
> >> contains a
On 03/06/2014 11:09 PM, Amos Kong wrote:
> vm_config_groups[] only contains part of the options which have
> parameters, and all options which have no parameter aren't added
> to vm_config_groups[]. Current query-command-line-options only
> checks options from vm_config_groups[]
So your idea of a tri-state (QemuOpts, no argument, or other argument)
>> doesn't add anything - any option that takes "other argument" could be
>> converted to take QemuOpts, and from the command line, we can't tell the
>> difference from whether something
ions which have no argument aren't added
>>>> to vm_config_groups[]. Current query-command-line-options only
>>>> checks options from vm_config_groups[], so some options will
>>>> be lost.
>>>>
>
>>Example: -device takes unspecified parameters.
On Mon, Mar 10, 2014 at 03:31:38PM +0800, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang
Not a valid email address.
On 03/10/2014 01:31 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> qapi-schema.json | 6 +-
> qmp-commands.hx| 2 ++
> util/qemu-config.c
1 - 100 of 170 matches
Mail list logo
