Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c

2021-04-08 Thread Richard Henderson
On 4/8/21 3:56 AM, Claudio Fontana wrote: It is a struggle to balance making TCG-only symbols "invisible" to kvm-builds, so one developing for KVM only can forget about them, and keeping TCG things contained, and on the other side opening up the ability to use tcg_enabled(), which requires tho

Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c

2021-04-08 Thread Claudio Fontana
On 3/28/21 6:40 PM, Richard Henderson wrote: > On 3/26/21 1:36 PM, Claudio Fontana wrote: >> +#ifdef CONFIG_TCG >> +arm_rebuild_hflags(env); >> +#endif /* CONFIG_TCG */ > > No functional changes during code movement. > Really. > I cannot emphasize this enough. we are asserting "not reached" fo

Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c

2021-03-28 Thread Richard Henderson
On 3/26/21 1:36 PM, Claudio Fontana wrote: +#ifdef CONFIG_TCG +arm_rebuild_hflags(env); +#endif /* CONFIG_TCG */ No functional changes during code movement. Really. I cannot emphasize this enough. Also, why is this an ifdef and not tcg_enabled()? +aarch64_restore_sp(env, new_el); +#i