Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c

[Richard Henderson]

On 3/26/21 1:36 PM, Claudio Fontana wrote:

+#ifdef CONFIG_TCG
+    arm_rebuild_hflags(env);
+#endif /* CONFIG_TCG */

No functional changes during code movement.
Really.
I cannot emphasize this enough.

Also, why is this an ifdef and not tcg_enabled()?

+    aarch64_restore_sp(env, new_el);
+#ifdef CONFIG_TCG
+    arm_rebuild_hflags(env);
+#endif /* CONFIG_TCG */

Likewise.

+#ifdef CONFIG_TCG
+    if (tcg_enabled()) {

Likewise.  And, why in the world do you need both?


r~