Re: [Qemu-devel] [patch 6/7] QEMU live block copy (update)

2011-06-19 Thread Marcelo Tosatti
On Tue, Jun 07, 2011 at 12:15:55PM +0200, Jiri Denemark wrote: > > +} > > +}, > > What about using the same form of progress reporting as used by query-migrate? > That is, instead of Done. > One can trivially compute percentage from that but it's impossible to get this > kind

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-15 Thread Marcelo Tosatti
On Tue, Jun 07, 2011 at 01:15:02PM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 6, 2011 at 5:55 PM, Marcelo Tosatti wrote: > > I haven't reviewed this whole patch yet, but comments below. > > This patch, like image streaming, may hit deadlocks due to synchronous > I/O emulation. I discovered thi

Re: [Qemu-devel] [patch 6/7] QEMU live block copy (update)

2011-06-15 Thread Marcelo Tosatti
On Tue, Jun 07, 2011 at 12:15:55PM +0200, Jiri Denemark wrote: > On Mon, Jun 06, 2011 at 14:03:44 -0300, Marcelo Tosatti wrote: > ... > > + "return":[ > > +{"device":"ide1-hd0", > > +"status":"active", > > +"info":{ > > + "percentage":23, > > +

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-09 Thread Jagane Sundar
Hello Stefan, Can you expand on this some more? I have similar concerns for Livebackup. At the beginning of your paragraph, did you mean 'asynchronous I/O emulation' instead of 'synchronous I/O emulation'? Also, I don't understand the 'stack' construct that you refer to. When you say 'push a

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-08 Thread Stefan Hajnoczi
On Wed, Jun 8, 2011 at 4:10 PM, Jagane Sundar wrote: > On 6/7/2011 5:15 AM, Stefan Hajnoczi wrote: >> >> On Mon, Jun 6, 2011 at 5:55 PM, Marcelo Tosatti >>  wrote: >> >> I haven't reviewed this whole patch yet, but comments below. >> >> This patch, like image streaming, may hit deadlocks due to sy

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-08 Thread Jagane Sundar
On 6/7/2011 5:15 AM, Stefan Hajnoczi wrote: On Mon, Jun 6, 2011 at 5:55 PM, Marcelo Tosatti wrote: I haven't reviewed this whole patch yet, but comments below. This patch, like image streaming, may hit deadlocks due to synchronous I/O emulation. I discovered this problem when working on image

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-07 Thread Stefan Hajnoczi
On Mon, Jun 6, 2011 at 5:55 PM, Marcelo Tosatti wrote: I haven't reviewed this whole patch yet, but comments below. This patch, like image streaming, may hit deadlocks due to synchronous I/O emulation. I discovered this problem when working on image streaming and it should be solved by getting

Re: [Qemu-devel] [patch 6/7] QEMU live block copy (update)

2011-06-07 Thread Jiri Denemark
On Mon, Jun 06, 2011 at 14:03:44 -0300, Marcelo Tosatti wrote: ... > SQMP > +query-block-copy > +- > + > +Live block copy status. > + > +Each block copy instance information is stored in a json-object and the > returned > +value is a json-array of all instances. > + > +Each json-objec

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-05 Thread Marcelo Tosatti
On Tue, May 31, 2011 at 07:53:44PM +0300, Avi Kivity wrote: > >Don't see the need for that, management can simply wait for livecopy to > >finish or cancel livecopy and restart on destination after migration. > > They can do it, but I imagine it's pretty hard for them. Well, they have to handle mi

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-05 Thread Marcelo Tosatti
On Tue, May 24, 2011 at 10:15:09PM +0300, Blue Swirl wrote: > > +static bool aio_inflight(BdrvCopyState *s, int64_t sector) > > +{ > > +    int64_t chunk = sector / (int64_t)BDRV_SECTORS_PER_DIRTY_CHUNK; > > + > > +    if (s->aio_bitmap && > > +        (sector << BDRV_SECTOR_BITS) < bdrv_getlength(

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-05-31 Thread Marcelo Tosatti
On Sun, May 29, 2011 at 11:54:25AM +0300, Avi Kivity wrote: > On 05/24/2011 12:31 AM, Marcelo Tosatti wrote: > >Support live image copy + switch. That is, copy an image backing > >a guest hard disk to a destination image (destination image must > >be created separately), and switch to this copy. >

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-05-31 Thread Marcelo Tosatti
On Tue, May 31, 2011 at 07:14:57PM +0300, Avi Kivity wrote: > On 05/31/2011 07:06 PM, Marcelo Tosatti wrote: > >On Sun, May 29, 2011 at 11:54:25AM +0300, Avi Kivity wrote: > >> On 05/24/2011 12:31 AM, Marcelo Tosatti wrote: > >> >Support live image copy + switch. That is, copy an image backing >

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-05-31 Thread Avi Kivity
On 05/31/2011 07:38 PM, Marcelo Tosatti wrote: > > >Disadvantages: > > > >- Guest write performance is affected during copying (guest writes > >compete with stream of writes from copy). > > Competes anyway with your background task? No because guest writes are to the source and copy wri

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-05-31 Thread Avi Kivity
On 05/31/2011 07:06 PM, Marcelo Tosatti wrote: On Sun, May 29, 2011 at 11:54:25AM +0300, Avi Kivity wrote: > On 05/24/2011 12:31 AM, Marcelo Tosatti wrote: > >Support live image copy + switch. That is, copy an image backing > >a guest hard disk to a destination image (destination image must >

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-05-29 Thread Avi Kivity
On 05/24/2011 12:31 AM, Marcelo Tosatti wrote: Support live image copy + switch. That is, copy an image backing a guest hard disk to a destination image (destination image must be created separately), and switch to this copy. Command syntax: block_copy device filename [-i] -- live block copy de

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-05-24 Thread Blue Swirl
On Tue, May 24, 2011 at 12:31 AM, Marcelo Tosatti wrote: > Support live image copy + switch. That is, copy an image backing > a guest hard disk to a destination image (destination image must > be created separately), and switch to this copy. > > Command syntax: > > block_copy device filename [-i]