Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-22 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 13/01/2015 10:15, Pavel Dovgaluk wrote: > > The numbers have no meaning. They just have to be distinct in different > > places. > > This is easier to achieve if you give a name to each place. > > > Sorry, missed one thing. > > run_all is us

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-13 Thread Paolo Bonzini
On 13/01/2015 15:26, Pavel Dovgaluk wrote: >> > Should you instead distinguish which TimerListGroup is being run? Then >> > main loop would checkpoint once for every TimerListGroup (which means >> > twice). > Then I'll have to introduce some kind of deterministic ID for them > and new asynchrono

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-13 Thread Paolo Bonzini
On 13/01/2015 15:26, Pavel Dovgaluk wrote: >> > Should you instead distinguish which TimerListGroup is being run? Then >> > main loop would checkpoint once for every TimerListGroup (which means >> > twice). > Then I'll have to introduce some kind of deterministic ID for them > and new asynchrono

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-13 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 13/01/2015 10:15, Pavel Dovgaluk wrote: > > The numbers have no meaning. They just have to be distinct in different > > places. > > This is easier to achieve if you give a name to each place. > > > Sorry, missed one thing. > > run_all is us

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-13 Thread Paolo Bonzini
On 13/01/2015 10:15, Pavel Dovgaluk wrote: > The numbers have no meaning. They just have to be distinct in different > places. This is easier to achieve if you give a name to each place. > Sorry, missed one thing. > run_all is used to distinguish timers processed in AIO by calling of > timerl

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-13 Thread Pavel Dovgaluk
> From: Pavel Dovgaluk [mailto:pavel.dovga...@ispras.ru] > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > > > +default: > > > +case QEMU_CLOCK_VIRTUAL: > > > +if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) > > >

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-13 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > > +default: > > +case QEMU_CLOCK_VIRTUAL: > > +if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) > > +|| !replay_checkpoint(run_all ? 2 : 3)) { > > +

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > +default: > +case QEMU_CLOCK_VIRTUAL: > +if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) > +|| !replay_checkpoint(run_all ? 2 : 3)) { > +return false; > +} > +break; Please docum