> From: Pavel Dovgaluk [mailto:pavel.dovga...@ispras.ru] > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > On 12/01/2015 13:01, Pavel Dovgalyuk wrote: > > > + default: > > > + case QEMU_CLOCK_VIRTUAL: > > > + if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running()) > > > + || !replay_checkpoint(run_all ? 2 : 3)) { > > > + return false; > > > + } > > > + break; > > > > Please document the meaning of the numbers by making an enum. > > The numbers have no meaning. They just have to be distinct in different > places. > > > Why do you have to distinguish run_all? > > It seems to be early versions artifact. I'll remove it.
Sorry, missed one thing. run_all is used to distinguish timers processed in AIO by calling of timerlistgroup_run_timers function and in main loop by calling qemu_clock_run_all_timers. We need to distinguish that to secure the sequence of the events. It makes sense when we use checkpointing while recording the execution. Pavel Dovgalyuk
