Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-29 Thread Richard W.M. Jones
On Wed, May 29, 2013 at 09:07:25AM +0800, Fam Zheng wrote: > On Tue, 05/28 12:32, Richard W.M. Jones wrote: > > > > This fixes the obvious bug. > > Thanks for figuring out this. Mainline had this 5s timeout so I kept it, > but you don't experience this bug, right? Since master doesn't setup a > t

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Fam Zheng
On Tue, 05/28 12:32, Richard W.M. Jones wrote: > > This fixes the obvious bug. Thanks for figuring out this. Mainline had this 5s timeout so I kept it, but you don't experience this bug, right? Since master doesn't setup a timer to get curl notified about the timing, the option is just not effect

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Stefan Hajnoczi
On Tue, May 28, 2013 at 12:01:55PM +0100, Richard W.M. Jones wrote: > On Tue, May 28, 2013 at 11:35:20AM +0100, Richard W.M. Jones wrote: > > I'm continuing to investigate. > > Some more data points: > > v6 patch, with my laptop plugged directly into the gigabit ethernet > switch which is connect

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Richard W.M. Jones
This fixes the obvious bug. I wonder if it should be even larger? One use for curl is to install guests using ISOs from websites without having to download the ISO, and I imagine that even a 30 second timeout could be conservative for that task. Rich. -- Richard Jones, Virtualization Group, R

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Fam Zheng
On Tue, 05/28 12:01, Richard W.M. Jones wrote: > On Tue, May 28, 2013 at 11:35:20AM +0100, Richard W.M. Jones wrote: > > I'm continuing to investigate. > > Some more data points: > > v6 patch, with my laptop plugged directly into the gigabit ethernet > switch which is connected to the web server:

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Richard W.M. Jones
On Tue, May 28, 2013 at 11:35:20AM +0100, Richard W.M. Jones wrote: > I'm continuing to investigate. Some more data points: v6 patch, with my laptop plugged directly into the gigabit ethernet switch which is connected to the web server: - Worked perfectly 5 times in a row. v6 patch, with my la

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Richard W.M. Jones
After discussion off-list, I've gone back and retested versions 4, 5, and 6 of this patch. I'm using the test script previously attached. I'm using libguestfs (ada94eb9) & curl (ba9a) & qemu (6a4e177114) all the latest from git. I'm using a 6 GB Windows XP guest. The web server is remote, o

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Fam Zheng
On Tue, 05/28 09:46, Richard W.M. Jones wrote: > On Tue, May 28, 2013 at 08:47:59AM +0100, Richard W.M. Jones wrote: > > I'm not sure if a Windows guest is somehow necessary to show the > > errors. I'll retest with a Linux guest and get back to you about > > that. > > Reproducible with Linux gues

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Richard W.M. Jones
On Tue, May 28, 2013 at 08:47:59AM +0100, Richard W.M. Jones wrote: > I'm not sure if a Windows guest is somehow necessary to show the > errors. I'll retest with a Linux guest and get back to you about > that. Reproducible with Linux guest (remotely over slow Wifi). > Also I'm testing against a

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Richard W.M. Jones
On Tue, May 28, 2013 at 03:30:49PM +0800, Fam Zheng wrote: > > > > Sure, I'm using the attached test script. > > I used your script to test, but I don't see errors as you posted, > attached the output. The only difference is that I put libguestfs in > different directory with you and I'm using a

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-28 Thread Fam Zheng
> > Sure, I'm using the attached test script. I used your script to test, but I don't see errors as you posted, attached the output. The only difference is that I put libguestfs in different directory with you and I'm using a linux guest image instead of windows xp. Do I need to get a windows ima

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-27 Thread Richard W.M. Jones
On Mon, May 27, 2013 at 10:25:21AM +0800, Fam Zheng wrote: > On Fri, 05/24 09:07, Richard W.M. Jones wrote: > > On Fri, May 24, 2013 at 01:36:55PM +0800, Fam Zheng wrote: > > > Changes from v5: > > > 05: Rename bs to s for BDRVCURLState. > > > 06: Use int64_t for offsets. > > > Fix printf

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-26 Thread Fam Zheng
On Fri, 05/24 09:07, Richard W.M. Jones wrote: > On Fri, May 24, 2013 at 01:36:55PM +0800, Fam Zheng wrote: > > Changes from v5: > > 05: Rename bs to s for BDRVCURLState. > > 06: Use int64_t for offsets. > > Fix printf format string. > > Move introducing of use_count to 07. > > 07

Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

2013-05-24 Thread Richard W.M. Jones
On Fri, May 24, 2013 at 01:36:55PM +0800, Fam Zheng wrote: > Changes from v5: > 05: Rename bs to s for BDRVCURLState. > 06: Use int64_t for offsets. > Fix printf format string. > Move introducing of use_count to 07. > 07: Drop explicit cast. > Use int64_t for offsets. >