Re: [Qemu-devel] [PATCH v5 2/3] softmmu: Add probe_write()

2015-05-27 Thread Yongbok Kim
On 26/05/2015 18:33, Richard Henderson wrote: > On 05/26/2015 09:53 AM, Peter Maydell wrote: >> On 26 May 2015 at 17:49, Yongbok Kim wrote: >>> Add probe_write() forces a tlb_fill if the specified guest virtual >>> index isn't in the TCG softmmu TLB. >> >> Surely the point is not to fill the TLB b

Re: [Qemu-devel] [PATCH v5 2/3] softmmu: Add probe_write()

2015-05-26 Thread Richard Henderson
On 05/26/2015 09:53 AM, Peter Maydell wrote: > On 26 May 2015 at 17:49, Yongbok Kim wrote: >> Add probe_write() forces a tlb_fill if the specified guest virtual >> index isn't in the TCG softmmu TLB. > > Surely the point is not to fill the TLB but to raise an > exception if the address is not wri

Re: [Qemu-devel] [PATCH v5 2/3] softmmu: Add probe_write()

2015-05-26 Thread Peter Crosthwaite
On Tue, May 26, 2015 at 9:58 AM, Andreas Färber wrote: > Am 26.05.2015 um 18:49 schrieb Yongbok Kim: >> Add probe_write() forces a tlb_fill if the specified guest virtual >> index isn't in the TCG softmmu TLB. >> >> Signed-off-by: Yongbok Kim >> --- >> include/exec/exec-all.h |2 ++ >> softm

Re: [Qemu-devel] [PATCH v5 2/3] softmmu: Add probe_write()

2015-05-26 Thread Paolo Bonzini
On 26/05/2015 18:58, Andreas Färber wrote: >> > +#if DATA_SIZE == 1 >> > +/* >> > + * Force a tlb_fill if the specified guest virtual index isn't in the TCG >> > + * softmmu TLB. >> > + */ >> > +void probe_write(CPUArchState *env, target_ulong addr, int mmu_idx, >> > + uintptr_t r

Re: [Qemu-devel] [PATCH v5 2/3] softmmu: Add probe_write()

2015-05-26 Thread Andreas Färber
Am 26.05.2015 um 18:49 schrieb Yongbok Kim: > Add probe_write() forces a tlb_fill if the specified guest virtual > index isn't in the TCG softmmu TLB. > > Signed-off-by: Yongbok Kim > --- > include/exec/exec-all.h |2 ++ > softmmu_template.h | 20 > 2 files change

Re: [Qemu-devel] [PATCH v5 2/3] softmmu: Add probe_write()

2015-05-26 Thread Peter Maydell
On 26 May 2015 at 17:49, Yongbok Kim wrote: > Add probe_write() forces a tlb_fill if the specified guest virtual > index isn't in the TCG softmmu TLB. Surely the point is not to fill the TLB but to raise an exception if the address is not writable? > +#if DATA_SIZE == 1 > +/* > + * Force a tlb_f