Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-10-01 Thread Stefan Weil
Am 01.10.2013 10:11, schrieb Sebastian Ottlik: > On 23.09.2013 12:33, Sebastian Ottlik wrote: >> On 18.09.2013 18:58, Stefan Weil wrote: >>> If failures only happen when something is very wrong (like an invalid >>> socket id), >>> an assertion might be better, and we could remove the 'silent' >>> p

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-10-01 Thread Sebastian Ottlik
On 23.09.2013 12:33, Sebastian Ottlik wrote: On 18.09.2013 18:58, Stefan Weil wrote: Am 16.09.2013 17:10, schrieb Sebastian Ottlik: On 16.09.2013 16:55, Paolo Bonzini wrote: Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: - Added the silent flag to socket_set_fast_reuse controlling error re

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-09-23 Thread Sebastian Ottlik
On 18.09.2013 18:58, Stefan Weil wrote: Am 16.09.2013 17:10, schrieb Sebastian Ottlik: On 16.09.2013 16:55, Paolo Bonzini wrote: Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: - Added the silent flag to socket_set_fast_reuse controlling error reporting One location where SO_REUSEADDR wa

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-09-18 Thread Stefan Weil
Am 16.09.2013 17:10, schrieb Sebastian Ottlik: > On 16.09.2013 16:55, Paolo Bonzini wrote: >> Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: >>> - Added the silent flag to socket_set_fast_reuse controlling error >>> reporting >>>One location where SO_REUSEADDR was set would report errors if

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-09-18 Thread Stefan Hajnoczi
On Mon, Sep 16, 2013 at 04:23:44PM +0200, Sebastian Ottlik wrote: > This patchset disables most uses of SO_REUSEADDR on Windows and replaces it > with > calls to the new function socket_set_fast_reuse. On Windows systems the > default > behaviour is equivalent to SO_REUSEADDR on other operating s

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-09-16 Thread Sebastian Ottlik
On 16.09.2013 16:55, Paolo Bonzini wrote: Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: - Added the silent flag to socket_set_fast_reuse controlling error reporting One location where SO_REUSEADDR was set would report errors if setting the option failed. Keeping the reporting code ther

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: > - Added the silent flag to socket_set_fast_reuse controlling error reporting > One location where SO_REUSEADDR was set would report errors if setting the > option failed. Keeping the reporting code there would be somewhat unclean, > so > I