Am 16.09.2013 17:10, schrieb Sebastian Ottlik: > On 16.09.2013 16:55, Paolo Bonzini wrote: >> Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: >>> - Added the silent flag to socket_set_fast_reuse controlling error >>> reporting >>> One location where SO_REUSEADDR was set would report errors if >>> setting the >>> option failed. Keeping the reporting code there would be somewhat >>> unclean, so >>> I moved it to socket_set_fast_reuse. A side effect of this was >>> that the error >>> reporting was added for all locations that now use >>> socket_set_fast_reuse. Here >>> a new flag is added to control error reporting, which means this >>> patchset >>> won't change QEMU behaviour (except for not setting SO_REUSEADDR >>> on Windows). >> Is there actually a case where setting SO_REUSEADDR could fail? >> >> Paolo > Yes, but its very unlikely. E.g. the first parameter is not a valid > socket. >
If failures only happen when something is very wrong (like an invalid socket id), an assertion might be better, and we could remove the 'silent' parameter. Stefan
