Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-20 Thread Markus Armbruster
Peter Xu writes: > On Tue, Jun 19, 2018 at 03:53:11PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Previously we clean up the queues when we got CLOSED event. It was used >> > to make sure we won't send leftover replies/events of a old client to a >> > new client which makes per

Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-19 Thread Peter Xu
On Tue, Jun 19, 2018 at 03:55:12PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Tue, Jun 19, 2018 at 01:34:22PM +0800, Peter Xu wrote: > > > > [...] > > > >> Fixes: 6d2d563f8c ("qmp: cleanup qmp queues properly", 2018-03-27) > >> Suggested-by: Markus Armbruster > >> Signed-off-by:

Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-19 Thread Peter Xu
On Tue, Jun 19, 2018 at 03:53:11PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Previously we clean up the queues when we got CLOSED event. It was used > > to make sure we won't send leftover replies/events of a old client to a > > new client which makes perfect sense. However this w

Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-19 Thread Markus Armbruster
Peter Xu writes: > On Tue, Jun 19, 2018 at 01:34:22PM +0800, Peter Xu wrote: > > [...] > >> Fixes: 6d2d563f8c ("qmp: cleanup qmp queues properly", 2018-03-27) >> Suggested-by: Markus Armbruster >> Signed-off-by: Peter Xu >> >> Signed-off-by: Peter Xu > > I am pretty sure this time that this 2

Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-19 Thread Markus Armbruster
Peter Xu writes: > Previously we clean up the queues when we got CLOSED event. It was used > to make sure we won't send leftover replies/events of a old client to a > new client which makes perfect sense. However this will also drop the > replies/events even if the output port of the previous ch

Re: [Qemu-devel] [PATCH v4 3/7] monitor: flush qmp responses when CLOSED

2018-06-18 Thread Peter Xu
On Tue, Jun 19, 2018 at 01:34:22PM +0800, Peter Xu wrote: [...] > Fixes: 6d2d563f8c ("qmp: cleanup qmp queues properly", 2018-03-27) > Suggested-by: Markus Armbruster > Signed-off-by: Peter Xu > > Signed-off-by: Peter Xu I am pretty sure this time that this 2nd line is not there in my local