On Tue, Jun 19, 2018 at 03:55:12PM +0200, Markus Armbruster wrote:
> Peter Xu <pet...@redhat.com> writes:
>
> > On Tue, Jun 19, 2018 at 01:34:22PM +0800, Peter Xu wrote:
> >
> > [...]
> >
> >> Fixes: 6d2d563f8c ("qmp: cleanup qmp queues properly", 2018-03-27)
> >> Suggested-by: Markus Armbruster <arm...@redhat.com>
> >> Signed-off-by: Peter Xu <pet...@redhat.com>
> >>
> >> Signed-off-by: Peter Xu <pet...@redhat.com>
> >
> > I am pretty sure this time that this 2nd line is not there in my local
> > tree. :)
> >
> > I think it's a git-format-patch bug, otherwise I must have misused it
> > for a long time. Instead of figuring this out and repost again, I'll
> > see how far the rest of the series can go.
>
> Do you use git-format-patch -s, or have format.signOff set in
> .git/config or ~/.gitconfig?
Ah it's in my ~/.gitconfig! Removing that fixes the issue.
Though I'm still not sure why the problem doesn't happen with other
patches. After all, due to the line wrapping mess I still prefer to
drop that chunk in commit message directly.
Regards,
--
Peter Xu
