Re: [Qemu-devel] [PATCH v4 1/8] bootindex: add modify_boot_device_path function

2014-08-04 Thread Gonglei (Arei)
Hi, > >> > >> > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com > wrote: > >> > [...] > >> > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev, > >> > > + const char *suffix) > >> > > +{ > >> > > +FWBootEntry *i, *old_entry = NULL

Re: [Qemu-devel] [PATCH v4 1/8] bootindex: add modify_boot_device_path function

2014-08-04 Thread Markus Armbruster
"Gonglei (Arei)" writes: > Hi, > >> >> > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com wrote: >> > [...] >> > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev, >> > > + const char *suffix) >> > > +{ >> > > +FWBootEntry *i, *o

Re: [Qemu-devel] [PATCH v4 1/8] bootindex: add modify_boot_device_path function

2014-08-04 Thread Gonglei (Arei)
Hi, > > > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com wrote: > > [...] > > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev, > > > + const char *suffix) > > > +{ > > > +FWBootEntry *i, *old_entry = NULL; > > > + > > > +a

Re: [Qemu-devel] [PATCH v4 1/8] bootindex: add modify_boot_device_path function

2014-08-01 Thread Luiz Capitulino
On Fri, 1 Aug 2014 10:36:18 -0300 Eduardo Habkost wrote: > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com wrote: > [...] > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev, > > + const char *suffix) > > +{ > > +FWBootEntry *i,

Re: [Qemu-devel] [PATCH v4 1/8] bootindex: add modify_boot_device_path function

2014-08-01 Thread Eduardo Habkost
On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com wrote: [...] > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev, > + const char *suffix) > +{ > +FWBootEntry *i, *old_entry = NULL; > + > +assert(dev != NULL || suffix != NULL); >