On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com wrote:
[...]
> +void modify_boot_device_path(int32_t bootindex, DeviceState *dev,
> + const char *suffix)
> +{
> + FWBootEntry *i, *old_entry = NULL;
> +
> + assert(dev != NULL || suffix != NULL);
> +
> + if (bootindex >= 0) {
> + QTAILQ_FOREACH(i, &fw_boot_order, link) {
> + if (i->bootindex == bootindex) {
> + qerror_report(ERROR_CLASS_GENERIC_ERROR,
> + "The bootindex %d has already been used",
> + bootindex);
Isn't an Error** parameter preferable here, instead of using qerror_report()?
> + return;
> + }
> + }
> + }
[...]
--
Eduardo
