Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 03:48:04PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 04:09:28PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > > > Michael, Paolo: Are you happy with v4? > > > > Looks pretty clean by itself. I sent some

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 04:09:28PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > > Michael, Paolo: Are you happy with v4? > > Looks pretty clean by itself. I sent some comments but they can be > addressed later. What worries me most is the c

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > Michael, Paolo: Are you happy with v4? Looks pretty clean by itself. I sent some comments but they can be addressed later. What worries me most is the code duplication with regular virtio. I see two ways to reduce the maintainanc

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Paolo Bonzini
Il 29/11/2012 10:18, Stefan Hajnoczi ha scritto: > Michael, Paolo: Are you happy with v4? Sure. > Kevin: Do you want to take this series through the block tree? Paolo

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 4:16 PM, Stefan Hajnoczi wrote: > This series adds the -device virtio-blk-pci,x-data-plane=on property that > enables a high performance I/O codepath. A dedicated thread is used to > process > virtio-blk requests outside the global mutex and without going through the > Q