Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-06 Thread BALATON Zoltan
On Mon, 6 Mar 2017, Peter Maydell wrote: On 4 March 2017 at 22:58, BALATON Zoltan wrote: On Sat, 4 Mar 2017, Peter Maydell wrote: Right, but we should test the PCI-on-a-little-endian CPU case, because right now your code has #ifdef TARGET_WORDS_BIGENDIAN in it which means that the PCI device w

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-06 Thread Peter Maydell
On 4 March 2017 at 22:58, BALATON Zoltan wrote: > On Sat, 4 Mar 2017, Peter Maydell wrote: >> Right, but we should test the PCI-on-a-little-endian CPU >> case, because right now your code has #ifdef TARGET_WORDS_BIGENDIAN >> in it which means that the PCI device will behave differently >> on big a

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-04 Thread BALATON Zoltan
On Sat, 4 Mar 2017, Peter Maydell wrote: On 3 March 2017 at 20:11, BALATON Zoltan wrote: On Fri, 3 Mar 2017, Peter Maydell wrote: So what cases have you tested? The Linux kernel seems to support: * sh embedded device, little endian * PCI card, little endian host * PCI card, big endian host and

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-04 Thread Peter Maydell
On 3 March 2017 at 20:11, BALATON Zoltan wrote: > On Fri, 3 Mar 2017, Peter Maydell wrote: >> So what cases have you tested? The Linux kernel seems to support: >> * sh embedded device, little endian >> * PCI card, little endian host >> * PCI card, big endian host >> and there are also >> * 16 bit

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-03 Thread BALATON Zoltan
On Fri, 3 Mar 2017, Peter Maydell wrote: On 3 March 2017 at 02:15, BALATON Zoltan wrote: Maybe it's not correct but works for everything I could test better than the original code (which was broken even for the SH images one can find) so I think we could just go with this until someone complain

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-03 Thread Peter Maydell
On 3 March 2017 at 02:15, BALATON Zoltan wrote: > Maybe it's not correct but works for everything I could test better than the > original code (which was broken even for the SH images one can find) so I > think we could just go with this until someone complains and provides a test > case. I've giv

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-02 Thread BALATON Zoltan
On Thu, 2 Mar 2017, Peter Maydell wrote: On 25 February 2017 at 18:46, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- v2: Split off small clean up to other patch hw/display/sm501.c | 6 +++--- hw/display/sm501_template.h | 23 ++- 2 files changed, 17 i

Re: [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness

2017-03-02 Thread Peter Maydell
On 25 February 2017 at 18:46, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > > v2: Split off small clean up to other patch > > hw/display/sm501.c | 6 +++--- > hw/display/sm501_template.h | 23 ++- > 2 files changed, 17 insertions(+), 12 deletions(-)