Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Su Hang
> -Original Messages- > From: "Eric Blake" > Sent Time: 2018-03-19 23:25:20 (Monday) > To: "Su Hang" , vsement...@virtuozzo.com > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix > Having the c

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-19 Thread Eric Blake
On 03/19/2018 08:56 AM, Su Hang wrote: Bug fix: checkpatch.pl stops complaining about following pattern: """ do { //do somethins; s/somethins/something/ } while (conditions); Having the commit message point to the commit id that introduced the bug is useful. The grammar is awkward (i

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Su Hang
ot;Peter Maydell" > Sent Time: 2018-03-15 19:50:55 (Thursday) > To: "Su Hang" > Cc: "Eric Blake" , "Vladimir Sementsov-Ogievskiy" > , "QEMU Developers" > Subject: Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix > > O

Re: [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Peter Maydell
On 15 March 2018 at 11:45, Su Hang wrote: > Bug fix: checkpatch.pl stops complaining about following pattern: > """ > do { > //do somethins; > } while (conditions); > """ > > Two things need to be mentioned: > 1) Before I casue this bug, checkpatch.pl will raise a wrong > complain: > """ > ERR