Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2014-01-13 Thread Gerd Hoffmann
On Mi, 2014-01-08 at 09:35 +1000, Dave Airlie wrote: > On Fri, Dec 6, 2013 at 6:58 PM, Dave Airlie wrote: > > On Fri, Dec 6, 2013 at 6:24 PM, Gerd Hoffmann wrote: > >> Hi, > >> > >>> Now the advice given was to have virtio-vga wrap virtio-gpu-base but > >>> from what I can see it really can't.

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2014-01-07 Thread Dave Airlie
On Fri, Dec 6, 2013 at 6:58 PM, Dave Airlie wrote: > On Fri, Dec 6, 2013 at 6:24 PM, Gerd Hoffmann wrote: >> Hi, >> >>> Now the advice given was to have virtio-vga wrap virtio-gpu-base but >>> from what I can see it really can't. Since it needs to act and look >>> like a PCI device >> >> Oops,

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-12-06 Thread Dave Airlie
On Fri, Dec 6, 2013 at 6:24 PM, Gerd Hoffmann wrote: > Hi, > >> Now the advice given was to have virtio-vga wrap virtio-gpu-base but >> from what I can see it really can't. Since it needs to act and look >> like a PCI device > > Oops, yes. VirtIOPCIProxy wasn't on my radar. That makes things a

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-12-06 Thread Gerd Hoffmann
Hi, > Now the advice given was to have virtio-vga wrap virtio-gpu-base but > from what I can see it really can't. Since it needs to act and look > like a PCI device Oops, yes. VirtIOPCIProxy wasn't on my radar. That makes things a bit more messy. Can you just push what you have now somewhere

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-12-05 Thread Dave Airlie
On Thu, Nov 21, 2013 at 9:06 PM, Gerd Hoffmann wrote: > On Do, 2013-11-21 at 13:12 +1000, Dave Airlie wrote: >> On Wed, Nov 20, 2013 at 10:02 PM, Gerd Hoffmann wrote: >> > On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: >> >> From: Dave Airlie >> >> >> >> This is a virtio-vga device built o

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-21 Thread Gerd Hoffmann
On Do, 2013-11-21 at 13:12 +1000, Dave Airlie wrote: > On Wed, Nov 20, 2013 at 10:02 PM, Gerd Hoffmann wrote: > > On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> This is a virtio-vga device built on top of the virtio-gpu device. > > > > Ah, I see what you use

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-20 Thread Paolo Bonzini
Il 21/11/2013 04:12, Dave Airlie ha scritto: > I'm not sure what that buys me here, I need the virtio-vga to attach > the vga ops the first console that the virtio-gpu registers, it can't > be a separate console, and since virtio-gpu initialises before > virtio-vga I can't tell it to not register t

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-20 Thread Dave Airlie
On Wed, Nov 20, 2013 at 10:02 PM, Gerd Hoffmann wrote: > On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> This is a virtio-vga device built on top of the virtio-gpu device. > > Ah, I see what you use the wrapping for. Hmm. I think you should use a > common base cl

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: > From: Dave Airlie > > This is a virtio-vga device built on top of the virtio-gpu device. Ah, I see what you use the wrapping for. Hmm. I think you should use a common base class instead, i.e. something like virtio-gpu-base which holds all