Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-02-14 Thread Paolo Bonzini
On 31/01/19 23:24, Philippe Mathieu-Daudé wrote: > The model implementation is: > - abstract SuperIO parent which can instantiate all configs, > - child implementation. > > Childs require their parent, and even if the parent will instantiate > them without all properties, the parent needs to link

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-31 Thread Philippe Mathieu-Daudé
On 1/31/19 11:14 PM, Paolo Bonzini wrote: > On 31/01/19 22:22, Philippe Mathieu-Daudé wrote: >> I kinda disagree with the SuperIO generated configs here, but partly my >> fault because the previous Makefile.objs missed the CONFIG_ISA_SUPERIO >> (I missed to review eae2e2e96bf from Thomas where is i

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-31 Thread Paolo Bonzini
On 31/01/19 22:22, Philippe Mathieu-Daudé wrote: > I kinda disagree with the SuperIO generated configs here, but partly my > fault because the previous Makefile.objs missed the CONFIG_ISA_SUPERIO > (I missed to review eae2e2e96bf from Thomas where is introduced > CONFIG_SMC37C669). > So introducing

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-31 Thread Philippe Mathieu-Daudé
Hi Paolo, On 1/25/19 11:07 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > Reviewed-by: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > default-configs/i386-softmmu.mak | 9 - > hw/aud

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Yang Zhong
On Wed, Jan 30, 2019 at 12:58:23PM +0100, Thomas Huth wrote: > On 2019-01-25 11:07, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Yang Zhong > > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > > Reviewed-by: Thomas Huth > > Signed-off-by: Paolo Bonzini > >

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-25 11:07, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > Reviewed-by: Thomas Huth > Signed-off-by: Paolo Bonzini > --- [...] > diff --git a/hw/net/Kconfig b/hw/net/Kconfig > index d50e301..

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Paolo Bonzini
On 30/01/19 12:32, Thomas Huth wrote: > Oh, I thought this was for convenience. So for s390x, the main problem is > AFAIK that the architecture does not support LSI, so all devices that > require LSI can not work here. Maybe we should introduce a "LSI" switch > instead, so that the boards which pro

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-30 12:13, Paolo Bonzini wrote: > On 30/01/19 11:53, Thomas Huth wrote: >>> diff --git a/hw/watchdog/Kconfig b/hw/watchdog/Kconfig >>> index edb3d42..35ccb72 100644 >>> --- a/hw/watchdog/Kconfig >>> +++ b/hw/watchdog/Kconfig >>> @@ -8,6 +8,8 @@ config WDT_IB6300ESB >>> >>> config WDT_I

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Paolo Bonzini
On 30/01/19 11:53, Thomas Huth wrote: >> diff --git a/hw/watchdog/Kconfig b/hw/watchdog/Kconfig >> index edb3d42..35ccb72 100644 >> --- a/hw/watchdog/Kconfig >> +++ b/hw/watchdog/Kconfig >> @@ -8,6 +8,8 @@ config WDT_IB6300ESB >> >> config WDT_IB700 >> bool >> +default y >> +depends

Re: [Qemu-devel] [PATCH 41/52] isa: express dependencies with kconfig

2019-01-30 Thread Thomas Huth
On 2019-01-25 11:07, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Message-Id: <20190123065618.3520-36-yang.zh...@intel.com> > Reviewed-by: Thomas Huth > Signed-off-by: Paolo Bonzini > --- > default-configs/i386-softmmu.mak | 9 - > hw/audio/Kconfig