Re: [Qemu-devel] [PATCH 08/10] sm501: Add support for panel layer

2017-02-25 Thread Peter Maydell
On 24 February 2017 at 20:38, BALATON Zoltan wrote: > On Fri, 24 Feb 2017, Peter Maydell wrote: >> Please don't change variable names in the middle of a patch that's >> adding new functionality, it makes the patch harder to review. > > > Where should I do it then? Again another patch? Yes. Either

Re: [Qemu-devel] [PATCH 08/10] sm501: Add support for panel layer

2017-02-24 Thread BALATON Zoltan
On Fri, 24 Feb 2017, Peter Maydell wrote: On 19 February 2017 at 16:35, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 73 +++--- 1 file changed, 37 insertions(+), 36 deletions(-) diff --git a/hw/display/sm501.c b/

Re: [Qemu-devel] [PATCH 08/10] sm501: Add support for panel layer

2017-02-24 Thread Peter Maydell
On 19 February 2017 at 16:35, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > hw/display/sm501.c | 73 > +++--- > 1 file changed, 37 insertions(+), 36 deletions(-) > > diff --git a/hw/display/sm501.c b/hw/display/sm501.c > index 1bd0