On 24 February 2017 at 20:38, BALATON Zoltan <bala...@eik.bme.hu> wrote: > On Fri, 24 Feb 2017, Peter Maydell wrote: >> Please don't change variable names in the middle of a patch that's >> adding new functionality, it makes the patch harder to review. > > > Where should I do it then? Again another patch?
Yes. Either make it its own patch, or drop the change altogether. Anything that makes the core "this is making a bug fix or adding new functionality" patch bigger by adding unnecessary code change to it makes that patch harder to review. (Conversely a patch that's just "change this variable name" is trivially easy to review.) thanks -- PMM
