Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.

2011-08-10 Thread Avi Kivity
On 08/11/2011 09:22 AM, Avi Kivity wrote: On 08/11/2011 01:28 AM, Richard Henderson wrote: } }; +static const MemoryRegionOps cs_ioport_ops = { +.read = cs_read, +.write = cs_write, +.impl = { +.min_access_size = 1, +.max_access_size = 1, +} +}; Should

Re: [Qemu-devel] [PATCH 05/11] cs4231a: Convert to MemoryRegion.

2011-08-10 Thread Avi Kivity
On 08/11/2011 01:28 AM, Richard Henderson wrote: } }; +static const MemoryRegionOps cs_ioport_ops = { +.read = cs_read, +.write = cs_write, +.impl = { +.min_access_size = 1, +.max_access_size = 1, +} +}; Should be .valid, not .impl. .impl means the impl