On 08/11/2011 09:22 AM, Avi Kivity wrote:
On 08/11/2011 01:28 AM, Richard Henderson wrote:
}
};
+static const MemoryRegionOps cs_ioport_ops = {
+ .read = cs_read,
+ .write = cs_write,
+ .impl = {
+ .min_access_size = 1,
+ .max_access_size = 1,
+ }
+};
Should be .valid, not .impl.
.impl means the implementation only supports this access size; emulate
other sizes by using a supported size (e.g. crack a 4-byte access into
4 1-byte accesses). .valid means what the device actually supports;
if the guest uses another size something bus-defined happens.
Oh, the standard qemu implementation auto-cracks, so .impl is correct.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
