Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Eric Blake
On 01/04/2018 06:44 AM, Thomas Huth wrote: > On 04.01.2018 13:33, Peter Maydell wrote: >> On 4 January 2018 at 12:27, Thomas Huth wrote: >>> The option has been marked as deprecated since QEMU 2.10, and so far >>> nobody complained that it is urgently required anymore. So let's now >>> get rid of

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Hello, Thomas Huth, on jeu. 04 janv. 2018 16:01:24 +0100, wrote: > On 04.01.2018 15:23, Samuel Thibault wrote: > > Thomas Huth, on jeu. 04 janv. 2018 15:22:25 +0100, wrote: > >> On 04.01.2018 14:26, Samuel Thibault wrote: > >> I think it's more common to not do any magic default setup with > >> "-

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 15:23, Samuel Thibault wrote: > Thomas Huth, on jeu. 04 janv. 2018 15:22:25 +0100, wrote: >> On 04.01.2018 14:26, Samuel Thibault wrote: >> I think it's more common to not do any magic default setup with >> "-device", but if you think this should be the case here, it can >> certainly

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Thomas Huth, on jeu. 04 janv. 2018 15:22:25 +0100, wrote: > On 04.01.2018 14:26, Samuel Thibault wrote: > I think it's more common to not do any magic default setup with > "-device", but if you think this should be the case here, it can > certainly be added again Yes, please: it will almost never

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 14:26, Samuel Thibault wrote: > Hello, > > I'm afraid I can't even work out how to replace -usbdevice braille (or > -usbdevice serial, all questions below apply, except making chardev > default to braille): > > ... -usbdevice braille > > -usbdevice braille: '-usbdevice' is deprecat

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Samuel Thibault
Hello, I'm afraid I can't even work out how to replace -usbdevice braille (or -usbdevice serial, all questions below apply, except making chardev default to braille): ... -usbdevice braille -usbdevice braille: '-usbdevice' is deprecated, please use '-device usb-...' instead but -device usb-ser

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 13:49, Peter Maydell wrote: > On 4 January 2018 at 12:44, Thomas Huth wrote: >> On 04.01.2018 13:33, Peter Maydell wrote: >>> The diffstat is nice, but can we retain the "please use >>> $NEWOPTION instead of $OLDOPTION" message for a bit? >>> I'm pretty sure there will be users out t

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Peter Maydell
On 4 January 2018 at 12:44, Thomas Huth wrote: > On 04.01.2018 13:33, Peter Maydell wrote: >> The diffstat is nice, but can we retain the "please use >> $NEWOPTION instead of $OLDOPTION" message for a bit? >> I'm pretty sure there will be users out there who've >> been happily ignoring deprecation

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Thomas Huth
On 04.01.2018 13:33, Peter Maydell wrote: > On 4 January 2018 at 12:27, Thomas Huth wrote: >> The option has been marked as deprecated since QEMU 2.10, and so far >> nobody complained that it is urgently required anymore. So let's now >> get rid of this legacy pile, to simplify the usb code quite

Re: [Qemu-devel] [PATCH] usb: Remove legacy -usbdevice option

2018-01-04 Thread Peter Maydell
On 4 January 2018 at 12:27, Thomas Huth wrote: > The option has been marked as deprecated since QEMU 2.10, and so far > nobody complained that it is urgently required anymore. So let's now > get rid of this legacy pile, to simplify the usb code quite a bit. > > Signed-off-by: Thomas Huth The dif