On 04.01.2018 13:49, Peter Maydell wrote: > On 4 January 2018 at 12:44, Thomas Huth <th...@redhat.com> wrote: >> On 04.01.2018 13:33, Peter Maydell wrote: >>> The diffstat is nice, but can we retain the "please use >>> $NEWOPTION instead of $OLDOPTION" message for a bit? >>> I'm pretty sure there will be users out there who've >>> been happily ignoring deprecation notices, and I think >>> we'll reduce the amount of support traffic if they >>> get a new QEMU with a specific error message telling them >>> what they need to fix, rather than one which just prints >>> a generic "unknown option" message. >> >> Sounds like a good idea at the first glance ... but at a second thought: >> Don't we confuse the management layers like libvirt this way, which >> might probe for the availability of this option by executing QEMU with >> this parameter? > > If they do (which I'd hope they don't) then QEMU will > exit with a failure status code, which they ought to > identify as "not supported".
OK, makes sense. I'll cook a v2 of the patch accordingly... Thomas