Re: [Qemu-devel] [PATCH] translator mega-patch

2017-06-19 Thread Peter Maydell
On 19 June 2017 at 05:08, Emilio G. Cota wrote: > On Sun, Jun 18, 2017 at 17:37:39 +0300, Lluís Vilanova wrote: >> I kind of dislike it every time I see container_of, and it makes type >> checking from the compiler a bit more fragile. > > container_of is *very* useful! You should like it more :-)

Re: [Qemu-devel] [PATCH] translator mega-patch

2017-06-18 Thread Emilio G. Cota
On Sun, Jun 18, 2017 at 17:37:39 +0300, Lluís Vilanova wrote: > Emilio G Cota writes: > > > On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote: > >> Signed-off-by: Lluís Vilanova > >> --- > >> include/exec/gen-icount.h |2 > >> include/exec/translate-all_template.h | 7

Re: [Qemu-devel] [PATCH] translator mega-patch

2017-06-18 Thread Peter Maydell
On 18 June 2017 at 15:37, Lluís Vilanova wrote: > I seem to remember we discussed this at some point before I sent the first > version, to allow multiple targets on the same binary, but decided against it. > > Still, I can leave the ops struct in place without even trying to support > multiple tar

Re: [Qemu-devel] [PATCH] translator mega-patch

2017-06-18 Thread Lluís Vilanova
Emilio G Cota writes: > On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> include/exec/gen-icount.h |2 >> include/exec/translate-all_template.h | 73 >> include/qom/cpu.h | 22 >> trans