Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Eric Blake
On 07/28/2017 07:19 AM, Peter Maydell wrote: > On 28 July 2017 at 13:08, Eric Blake wrote: >> On 07/28/2017 04:04 AM, Peter Maydell wrote: >>> On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy >>> wrote: To make logs more readable prefix all hex values with '0x' mark. This is neede

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Peter Maydell
On 28 July 2017 at 13:08, Eric Blake wrote: > On 07/28/2017 04:04 AM, Peter Maydell wrote: >> On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy >> wrote: >>> To make logs more readable prefix all hex values with '0x' mark. >>> This is needed for consistency too, as a lot of hex values are al

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Eric Blake
On 07/28/2017 04:04 AM, Peter Maydell wrote: > On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy > wrote: >> To make logs more readable prefix all hex values with '0x' mark. >> This is needed for consistency too, as a lot of hex values are already >> prefixed with '0x'. Also, bring all hex ou

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Stefan Hajnoczi
On Fri, Jul 28, 2017 at 11:55:47AM +0300, Vladimir Sementsov-Ogievskiy wrote: > To make logs more readable prefix all hex values with '0x' mark. > This is needed for consistency too, as a lot of hex values are already > prefixed with '0x'. Also, bring all hex outputs to the common form - > use '%#'

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 13:01:15 +0300 Vladimir Sementsov-Ogievskiy wrote: > 28.07.2017 12:41, Cornelia Huck wrote: > > On Fri, 28 Jul 2017 11:55:47 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> To make logs more readable prefix all hex values with '0x' mark. > >> This is needed for consi

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2017 12:41, Cornelia Huck wrote: On Fri, 28 Jul 2017 11:55:47 +0300 Vladimir Sementsov-Ogievskiy wrote: To make logs more readable prefix all hex values with '0x' mark. This is needed for consistency too, as a lot of hex values are already prefixed with '0x'. Also, bring all hex outputs

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 11:55:47 +0300 Vladimir Sementsov-Ogievskiy wrote: > To make logs more readable prefix all hex values with '0x' mark. > This is needed for consistency too, as a lot of hex values are already > prefixed with '0x'. Also, bring all hex outputs to the common form - > use '%#', not

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2017 12:04, Peter Maydell wrote: On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy wrote: To make logs more readable prefix all hex values with '0x' mark. This is needed for consistency too, as a lot of hex values are already prefixed with '0x'. Also, bring all hex outputs to the com

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Vladimir Sementsov-Ogievskiy
28.07.2017 12:06, Daniel P. Berrange wrote: On Fri, Jul 28, 2017 at 11:55:47AM +0300, Vladimir Sementsov-Ogievskiy wrote: To make logs more readable prefix all hex values with '0x' mark. This is needed for consistency too, as a lot of hex values are already prefixed with '0x'. Also, bring all he

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Daniel P. Berrange
On Fri, Jul 28, 2017 at 11:55:47AM +0300, Vladimir Sementsov-Ogievskiy wrote: > To make logs more readable prefix all hex values with '0x' mark. > This is needed for consistency too, as a lot of hex values are already > prefixed with '0x'. Also, bring all hex outputs to the common form - > use '%#'

Re: [Qemu-devel] [PATCH] trace-events: print 0x before hex numbers

2017-07-28 Thread Peter Maydell
On 28 July 2017 at 09:55, Vladimir Sementsov-Ogievskiy wrote: > To make logs more readable prefix all hex values with '0x' mark. > This is needed for consistency too, as a lot of hex values are already > prefixed with '0x'. Also, bring all hex outputs to the common form - > use '%#', not '0x%'. >