Re: [Qemu-devel] [PATCH] target-i386: Fix mulx for identical target regs

2015-11-17 Thread Eduardo Habkost
On Tue, Nov 17, 2015 at 12:41:47PM +0100, Richard Henderson wrote: > The Intel specification clearly indicates that the low part > of the result is written first and the high part of the result > is written second; thus if ModRM:reg and VEX. are identical, > the final result should be the high

Re: [Qemu-devel] [PATCH] target-i386: Fix mulx for identical target

2015-11-16 Thread Richard Henderson
On 11/17/2015 04:40 AM, Max Reitz wrote: -tcg_gen_mulu2_i64(cpu_regs[s->vex_v], cpu_regs[reg], - cpu_T[0], cpu_regs[R_EDX]); +tcg_gen_op3_i64(INDEX_op_mul_i64, cpu_regs[s->vex_v], +cpu