Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Roy Franz
On Fri, Oct 18, 2013 at 7:11 AM, Peter Maydell wrote: > On 18 October 2013 15:05, Roy Franz wrote: >> On Fri, Oct 18, 2013 at 7:01 AM, Peter Maydell >> wrote: >>> Yes, you should make the default for the device-width property >>> be to be the same as the bank-width, since that's what we >>> cur

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Peter Maydell
On 18 October 2013 15:05, Roy Franz wrote: > On Fri, Oct 18, 2013 at 7:01 AM, Peter Maydell > wrote: >> Yes, you should make the default for the device-width property >> be to be the same as the bank-width, since that's what we >> currently implement; then we can just change the platforms >> whe

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Roy Franz
On Fri, Oct 18, 2013 at 7:01 AM, Peter Maydell wrote: > On 18 October 2013 14:54, Roy Franz wrote: >> On Fri, Oct 18, 2013 at 6:36 AM, Peter Maydell >> wrote: >>> Probably instead of a single "width" property we should have two, >>> similar to the device tree binding's pair: >>> - bank-width :

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Peter Maydell
On 18 October 2013 14:54, Roy Franz wrote: > On Fri, Oct 18, 2013 at 6:36 AM, Peter Maydell > wrote: >> Probably instead of a single "width" property we should have two, >> similar to the device tree binding's pair: >> - bank-width : Width (in bytes) of the bank. Equal to the >>device widt

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Roy Franz
On Fri, Oct 18, 2013 at 6:36 AM, Peter Maydell wrote: > On 18 October 2013 12:38, Stefan Hajnoczi wrote: >> On Thu, Oct 17, 2013 at 07:30:02PM -0700, Roy Franz wrote: >>> For buffered writes, mask the length with the maximum supported >>> length. This is required for block writes to work on the

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Peter Maydell
On 18 October 2013 12:38, Stefan Hajnoczi wrote: > On Thu, Oct 17, 2013 at 07:30:02PM -0700, Roy Franz wrote: >> For buffered writes, mask the length with the maximum supported >> length. This is required for block writes to work on the ARM vexpress >> platform, where the flash interface is 32 bi

Re: [Qemu-devel] [PATCH] block: mask NOR flash buffered write length

2013-10-18 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 07:30:02PM -0700, Roy Franz wrote: > For buffered writes, mask the length with the maximum supported > length. This is required for block writes to work on the ARM vexpress > platform, where the flash interface is 32 bits wide. For buffered writes > to the 2 16 bit flashes