Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Gleb Natapov
On Thu, Jan 07, 2010 at 12:02:01PM -0600, Anthony Liguori wrote: > On 01/07/2010 11:08 AM, Gleb Natapov wrote: > >On Thu, Jan 07, 2010 at 06:56:31PM +0200, Avi Kivity wrote: > >>On 01/07/2010 06:53 PM, Anthony Liguori wrote: > >>>I don't want to deviate unnecessarily from qemu-kvm so we can > >>>ap

Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Anthony Liguori
On 01/07/2010 11:08 AM, Gleb Natapov wrote: On Thu, Jan 07, 2010 at 06:56:31PM +0200, Avi Kivity wrote: On 01/07/2010 06:53 PM, Anthony Liguori wrote: I don't want to deviate unnecessarily from qemu-kvm so we can approach this in one of two ways. We can remove the guard in qemu-kvm a

Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Gleb Natapov
On Thu, Jan 07, 2010 at 06:56:31PM +0200, Avi Kivity wrote: > On 01/07/2010 06:53 PM, Anthony Liguori wrote: > > > >I don't want to deviate unnecessarily from qemu-kvm so we can > >approach this in one of two ways. We can remove the guard in > >qemu-kvm and Avi can send me a pull request with this

Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Gleb Natapov
On Thu, Jan 07, 2010 at 10:53:30AM -0600, Anthony Liguori wrote: > On 01/07/2010 10:15 AM, Gleb Natapov wrote: > >>KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always > >>been present in kvm_para.h. Since we include kvm_para.h > >>unconditionally, there's no way we wouldn't have > >>

Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Avi Kivity
On 01/07/2010 06:53 PM, Anthony Liguori wrote: I don't want to deviate unnecessarily from qemu-kvm so we can approach this in one of two ways. We can remove the guard in qemu-kvm and Avi can send me a pull request with this feature. I can also just pull in the patch as-is and we can fix thi

Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Anthony Liguori
On 01/07/2010 10:15 AM, Gleb Natapov wrote: KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always been present in kvm_para.h. Since we include kvm_para.h unconditionally, there's no way we wouldn't have KVM_CPUID_SIGNATURE. It is there in qemu-kvm and we suppose to bring know

Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Gleb Natapov
On Thu, Jan 07, 2010 at 10:09:16AM -0600, Anthony Liguori wrote: > On 01/07/2010 06:44 AM, Gleb Natapov wrote: > >Initialize KVM paravirt cpuid leaf and allow user to control guest > >visible PV features through -cpu flag. > > > >Signed-off-by: Gleb Natapov > >diff --git a/target-i386/cpu.h b/targe

Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf

2010-01-07 Thread Anthony Liguori
On 01/07/2010 06:44 AM, Gleb Natapov wrote: Initialize KVM paravirt cpuid leaf and allow user to control guest visible PV features through -cpu flag. Signed-off-by: Gleb Natapov diff --git a/target-i386/cpu.h b/target-i386/cpu.h index f3834b3..216b00e 100644 --- a/target-i386/cpu.h +++ b/target-