Re: [Qemu-devel] [PATCH]: set up rbd snapshot handling

2012-01-11 Thread Gregory Farnum
On Wed, Jan 11, 2012 at 1:58 AM, Stefan Hajnoczi wrote: > On Tue, Jan 10, 2012 at 8:01 PM, Gregory Farnum > wrote: >> +static int qemu_rbd_snap_remove(BlockDriverState *bs, >> +                                const char *snapshot_name) >> +{ >> +    BDRVRBDState *s = bs->opaque; >> +    int r; >>

Re: [Qemu-devel] [PATCH]: set up rbd snapshot handling

2012-01-11 Thread Stefan Hajnoczi
On Tue, Jan 10, 2012 at 8:01 PM, Gregory Farnum wrote: > +static int qemu_rbd_snap_remove(BlockDriverState *bs, > +                                const char *snapshot_name) > +{ > +    BDRVRBDState *s = bs->opaque; > +    int r; > + > +    r = rbd_snap_remove(s->image, snapshot_name); > +    if (

Re: [Qemu-devel] [PATCH]: set up rbd snapshot handling

2012-01-11 Thread Christoph Hellwig
> +static int qemu_rbd_snap_remove(BlockDriverState *bs, > +const char *snapshot_name) > +{ > +BDRVRBDState *s = bs->opaque; > +int r; > + > +r = rbd_snap_remove(s->image, snapshot_name); > +r = rbd_snap_rollback(s->image, snapshot_name); Have these