Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-24 Thread Max Reitz
On 24.10.19 16:07, Andrey Shinkevich wrote: > > > On 24/10/2019 16:48, Max Reitz wrote: >> On 24.10.19 14:56, Andrey Shinkevich wrote: >>> >>> >>> On 24/10/2019 12:34, Max Reitz wrote: On 22.10.19 15:53, Andrey Shinkevich wrote: [...] > If the support of COW for compressed

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-24 Thread Andrey Shinkevich
On 24/10/2019 16:48, Max Reitz wrote: > On 24.10.19 14:56, Andrey Shinkevich wrote: >> >> >> On 24/10/2019 12:34, Max Reitz wrote: >>> On 22.10.19 15:53, Andrey Shinkevich wrote: >>> >>> [...] >>> If the support of COW for compressed writes is found feasible, will it make a sense to imp

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-24 Thread Andrey Shinkevich
On 24/10/2019 16:48, Max Reitz wrote: > On 24.10.19 14:56, Andrey Shinkevich wrote: >> >> >> On 24/10/2019 12:34, Max Reitz wrote: >>> On 22.10.19 15:53, Andrey Shinkevich wrote: >>> >>> [...] >>> If the support of COW for compressed writes is found feasible, will it make a sense to imp

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-24 Thread Max Reitz
On 24.10.19 14:56, Andrey Shinkevich wrote: > > > On 24/10/2019 12:34, Max Reitz wrote: >> On 22.10.19 15:53, Andrey Shinkevich wrote: >> >> [...] >> >>> If the support of COW for compressed writes is found feasible, will it >>> make a sense to implement? Then this series will follow. >> >> Hm, w

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-24 Thread Andrey Shinkevich
On 24/10/2019 12:34, Max Reitz wrote: > On 22.10.19 15:53, Andrey Shinkevich wrote: > > [...] > >> If the support of COW for compressed writes is found feasible, will it >> make a sense to implement? Then this series will follow. > > Hm, what exactly do you mean by support of COW for compresse

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-24 Thread Max Reitz
On 22.10.19 15:53, Andrey Shinkevich wrote: [...] > If the support of COW for compressed writes is found feasible, will it > make a sense to implement? Then this series will follow. Hm, what exactly do you mean by support of COW for compressed writes? > A comment for the option would warn a us

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Andrey Shinkevich
On 22/10/2019 15:56, Max Reitz wrote: > On 22.10.19 14:23, Vladimir Sementsov-Ogievskiy wrote: >> 22.10.2019 14:31, Max Reitz wrote: >>> On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: 22.10.2019 13:21, Andrey Shinkevich wrote: > > On 22/10/2019 12:28, Max Reitz wrote: >>

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
22.10.2019 15:56, Max Reitz wrote: > On 22.10.19 14:23, Vladimir Sementsov-Ogievskiy wrote: >> 22.10.2019 14:31, Max Reitz wrote: >>> On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: 22.10.2019 13:21, Andrey Shinkevich wrote: > > On 22/10/2019 12:28, Max Reitz wrote: >> On 20

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Max Reitz
On 22.10.19 14:23, Vladimir Sementsov-Ogievskiy wrote: > 22.10.2019 14:31, Max Reitz wrote: >> On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: >>> 22.10.2019 13:21, Andrey Shinkevich wrote: On 22/10/2019 12:28, Max Reitz wrote: > On 20.10.19 22:37, Andrey Shinkevich wrote:

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
22.10.2019 14:31, Max Reitz wrote: > On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: >> 22.10.2019 13:21, Andrey Shinkevich wrote: >>> >>> On 22/10/2019 12:28, Max Reitz wrote: On 20.10.19 22:37, Andrey Shinkevich wrote: > To inform the block layer about writing all the data compres

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Max Reitz
On 22.10.19 12:46, Vladimir Sementsov-Ogievskiy wrote: > 22.10.2019 13:21, Andrey Shinkevich wrote: >> >> On 22/10/2019 12:28, Max Reitz wrote: >>> On 20.10.19 22:37, Andrey Shinkevich wrote: To inform the block layer about writing all the data compressed, we introduce the 'compress' comm

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Vladimir Sementsov-Ogievskiy
22.10.2019 13:21, Andrey Shinkevich wrote: > > On 22/10/2019 12:28, Max Reitz wrote: >> On 20.10.19 22:37, Andrey Shinkevich wrote: >>> To inform the block layer about writing all the data compressed, we >>> introduce the 'compress' command line option. Based on that option, the >>> written data w

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Andrey Shinkevich
On 22/10/2019 12:28, Max Reitz wrote: > On 20.10.19 22:37, Andrey Shinkevich wrote: >> To inform the block layer about writing all the data compressed, we >> introduce the 'compress' command line option. Based on that option, the >> written data will be aligned by the cluster size at the generic l

Re: [PATCH v5 1/4] block: support compressed write at generic layer

2019-10-22 Thread Max Reitz
On 20.10.19 22:37, Andrey Shinkevich wrote: > To inform the block layer about writing all the data compressed, we > introduce the 'compress' command line option. Based on that option, the > written data will be aligned by the cluster size at the generic layer. > > Suggested-by: Roman Kagan > Sugg