Re: [PATCH v4 5/6] migration: Unfold control_save_page()

2025-02-27 Thread Peter Xu
On Thu, Feb 27, 2025 at 12:42:30AM +, Zhijian Li (Fujitsu) wrote: > > > On 26/02/2025 23:51, Peter Xu wrote: > > On Wed, Feb 26, 2025 at 02:30:42PM +0800, Li Zhijian wrote: > >> control_save_page() is for RDMA only, unfold it to make the code more > >> clear. > >> In addition: > >> - Simila

Re: [PATCH v4 5/6] migration: Unfold control_save_page()

2025-02-26 Thread Zhijian Li (Fujitsu)
On 26/02/2025 23:51, Peter Xu wrote: > On Wed, Feb 26, 2025 at 02:30:42PM +0800, Li Zhijian wrote: >> control_save_page() is for RDMA only, unfold it to make the code more >> clear. >> In addition: >> - Similar to other branches style in ram_save_target_page(), involve RDMA >> only if the c

Re: [PATCH v4 5/6] migration: Unfold control_save_page()

2025-02-26 Thread Peter Xu
On Wed, Feb 26, 2025 at 02:30:42PM +0800, Li Zhijian wrote: > control_save_page() is for RDMA only, unfold it to make the code more > clear. > In addition: > - Similar to other branches style in ram_save_target_page(), involve RDMA >only if the condition 'migrate_rdma()' is true. > - Further