On Wed, Feb 26, 2025 at 02:30:42PM +0800, Li Zhijian wrote: > control_save_page() is for RDMA only, unfold it to make the code more > clear. > In addition: > - Similar to other branches style in ram_save_target_page(), involve RDMA > only if the condition 'migrate_rdma()' is true. > - Further simplify the code by removing the RAM_SAVE_CONTROL_NOT_SUPP. > > Signed-off-by: Li Zhijian <lizhij...@fujitsu.com>
[...] > @@ -56,7 +55,7 @@ static inline > int rdma_control_save_page(QEMUFile *f, ram_addr_t block_offset, > ram_addr_t offset, size_t size) > { > - return RAM_SAVE_CONTROL_NOT_SUPP; > + g_assert_not_reached(); > } Not sure if some compiler will be unhappy on the retval not provided, but anyway we'll see.. Reviewed-by: Peter Xu <pet...@redhat.com> > #endif > #endif > -- > 2.44.0 > -- Peter Xu