Re: [PATCH v4 08/16] cputlb: Move ROM handling from I/O path to TLB path

2019-09-25 Thread Richard Henderson
On 9/24/19 11:59 PM, David Hildenbrand wrote: >>> +if (section->readonly) { >>> +tn.addr_write |= TLB_ROM; >>> +} else if (cpu_physical_memory_is_clean( >>> +memory_region_get_ram_addr(section->mr) + xlat)) { >>> +tn.ad

Re: [PATCH v4 08/16] cputlb: Move ROM handling from I/O path to TLB path

2019-09-25 Thread Alex Bennée
David Hildenbrand writes: > On 25.09.19 02:16, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> It does not require going through the whole I/O path >>> in order to discard a write. >>> >>> Reviewed-by: David Hildenbrand >>> Signed-off-by: Richard Henderson >>> --- >>> include/exec

Re: [PATCH v4 08/16] cputlb: Move ROM handling from I/O path to TLB path

2019-09-25 Thread David Hildenbrand
On 25.09.19 02:16, Alex Bennée wrote: > > Richard Henderson writes: > >> It does not require going through the whole I/O path >> in order to discard a write. >> >> Reviewed-by: David Hildenbrand >> Signed-off-by: Richard Henderson >> --- >> include/exec/cpu-all.h| 5 - >> include/exe

Re: [PATCH v4 08/16] cputlb: Move ROM handling from I/O path to TLB path

2019-09-24 Thread Alex Bennée
Richard Henderson writes: > It does not require going through the whole I/O path > in order to discard a write. > > Reviewed-by: David Hildenbrand > Signed-off-by: Richard Henderson > --- > include/exec/cpu-all.h| 5 - > include/exec/cpu-common.h | 1 - > accel/tcg/cputlb.c