On 9/24/19 11:59 PM, David Hildenbrand wrote: >>> + if (section->readonly) { >>> + tn.addr_write |= TLB_ROM; >>> + } else if (cpu_physical_memory_is_clean( >>> + memory_region_get_ram_addr(section->mr) + xlat)) { >>> + tn.addr_write |= TLB_NOTDIRTY; >>> + } >> >> This reads a bit weird because we are saying romd isn't a ROM but >> something that identifies as RAM can be ROM rather than just a memory >> protected piece of RAM. >> > > I proposed a bunch of alternatives as reply to v3 (e.g., > TLB_DISCARD_WRITES), either Richard missed them or I missed his reply :)
Missed it, sorry. r~