Re: [PATCH v4 03/20] target/arm: Add isar_feature tests for PAN + ATS1E1

2020-02-14 Thread Richard Henderson
On 2/14/20 3:28 AM, Peter Maydell wrote: >> +static inline bool isar_feature_aa32_pan(const ARMISARegisters *id) >> +{ >> +return FIELD_EX64(id->mvfr0, ID_MMFR3, PAN) != 0; >> +} >> + >> +static inline bool isar_feature_aa32_ats1e1(const ARMISARegisters *id) >> +{ >> +return FIELD_EX64(id->

Re: [PATCH v4 03/20] target/arm: Add isar_feature tests for PAN + ATS1E1

2020-02-14 Thread Peter Maydell
On Fri, 14 Feb 2020 at 11:28, Peter Maydell wrote: > > On Sat, 8 Feb 2020 at 12:58, Richard Henderson > wrote: > > > > Include definitions for all of the bits in ID_MMFR3. > > We already have a definition for ID_AA64MMFR1.PAN. > > > > Reviewed-by: Alex Bennée > > Reviewed-by: Peter Maydell > >

Re: [PATCH v4 03/20] target/arm: Add isar_feature tests for PAN + ATS1E1

2020-02-14 Thread Peter Maydell
On Sat, 8 Feb 2020 at 12:58, Richard Henderson wrote: > > Include definitions for all of the bits in ID_MMFR3. > We already have a definition for ID_AA64MMFR1.PAN. > > Reviewed-by: Alex Bennée > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > @@ -3443,6 +3452,16 @@ static inli