Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-26 Thread John Snow
On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: > On 6/17/20 7:13 PM, Philippe Mathieu-Daudé wrote: >> On 6/16/20 11:49 PM, Cleber Rosa wrote: >>> On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: On 6/9/20 11:55 PM, John Snow wrote: > > > On 6/9/2

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-22 Thread Philippe Mathieu-Daudé
+Alex On 6/22/20 8:08 PM, John Snow wrote: > On 6/22/20 1:55 PM, Philippe Mathieu-Daudé wrote: >> On 6/22/20 7:51 PM, John Snow wrote: >>> >>> >>> On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: Still doesn't work... https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 >>> >>>

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-22 Thread John Snow
On 6/22/20 1:55 PM, Philippe Mathieu-Daudé wrote: > On 6/22/20 7:51 PM, John Snow wrote: >> >> >> On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: >>> Still doesn't work... >>> https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 >> >> I tried running from master with just these patche

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-22 Thread Philippe Mathieu-Daudé
On 6/22/20 7:51 PM, John Snow wrote: > > > On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: >> Still doesn't work... >> https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 > > I tried running from master with just these patches applied. So far, the > only failures I am seeing on gitla

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-22 Thread John Snow
On 6/20/20 6:14 AM, Philippe Mathieu-Daudé wrote: > Still doesn't work... > https://travis-ci.org/github/philmd/qemu/jobs/700309163#L5445 I tried running from master with just these patches applied. So far, the only failures I am seeing on gitlab/travis are job timeouts. Are you doing somethi

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-20 Thread Philippe Mathieu-Daudé
On 6/17/20 7:13 PM, Philippe Mathieu-Daudé wrote: > On 6/16/20 11:49 PM, Cleber Rosa wrote: >> On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: >>> On 6/9/20 11:55 PM, John Snow wrote: On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: > Hi John, > >>>

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-17 Thread Philippe Mathieu-Daudé
On 6/4/20 9:52 PM, John Snow wrote: > v3: > - Split _post_shutdown refactor into own patch (now 1/3) > - Re-add sigkill warning squelch (now 3/3) > > NOTE: I re-added the squelch in its own patch for review purposes, but > for the purposes of avoiding temporary breakage, a maintainer may wish >

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-17 Thread Philippe Mathieu-Daudé
On 6/16/20 11:49 PM, Cleber Rosa wrote: > On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: >> On 6/9/20 11:55 PM, John Snow wrote: >>> >>> >>> On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: Hi John, On 6/4/20 9:52 PM, John Snow wrote: > v3: > - Spl

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-16 Thread Cleber Rosa
On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: > On 6/9/20 11:55 PM, John Snow wrote: > > > > > > On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: > >> Hi John, > >> > >> On 6/4/20 9:52 PM, John Snow wrote: > >>> v3: > >>> - Split _post_shutdown refactor into own patch (

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-16 Thread Philippe Mathieu-Daudé
On 6/16/20 5:06 PM, John Snow wrote: > > > On 6/15/20 6:21 PM, Eduardo Habkost wrote: >> On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: >>> On 6/9/20 11:55 PM, John Snow wrote: On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 6

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-16 Thread John Snow
On 6/15/20 6:21 PM, Eduardo Habkost wrote: > On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: >> On 6/9/20 11:55 PM, John Snow wrote: >>> >>> >>> On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: Hi John, On 6/4/20 9:52 PM, John Snow wrote: > v3: > -

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-15 Thread Eduardo Habkost
On Mon, Jun 15, 2020 at 05:21:18PM +0200, Philippe Mathieu-Daudé wrote: > On 6/9/20 11:55 PM, John Snow wrote: > > > > > > On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: > >> Hi John, > >> > >> On 6/4/20 9:52 PM, John Snow wrote: > >>> v3: > >>> - Split _post_shutdown refactor into own patch

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-15 Thread Philippe Mathieu-Daudé
On 6/9/20 11:55 PM, John Snow wrote: > > > On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On 6/4/20 9:52 PM, John Snow wrote: >>> v3: >>> - Split _post_shutdown refactor into own patch (now 1/3) >>> - Re-add sigkill warning squelch (now 3/3) >>> >>> NOTE: I re-added the sque

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-09 Thread John Snow
On 6/9/20 9:08 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 6/4/20 9:52 PM, John Snow wrote: >> v3: >> - Split _post_shutdown refactor into own patch (now 1/3) >> - Re-add sigkill warning squelch (now 3/3) >> >> NOTE: I re-added the squelch in its own patch for review purposes, but >>

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-09 Thread Philippe Mathieu-Daudé
Hi John, On 6/4/20 9:52 PM, John Snow wrote: > v3: > - Split _post_shutdown refactor into own patch (now 1/3) > - Re-add sigkill warning squelch (now 3/3) > > NOTE: I re-added the squelch in its own patch for review purposes, but > for the purposes of avoiding temporary breakage, a maintainer m

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

2020-06-05 Thread Kevin Wolf
Am 04.06.2020 um 21:52 hat John Snow geschrieben: > v3: > - Split _post_shutdown refactor into own patch (now 1/3) Feels much easier to read now! > - Re-add sigkill warning squelch (now 3/3) > > NOTE: I re-added the squelch in its own patch for review purposes, but > for the purposes of avoidi