On 6/4/20 9:52 PM, John Snow wrote: > v3: > - Split _post_shutdown refactor into own patch (now 1/3) > - Re-add sigkill warning squelch (now 3/3) > > NOTE: I re-added the squelch in its own patch for review purposes, but > for the purposes of avoiding temporary breakage, a maintainer may wish > to squash patches 2 and 3 if they are accepted. > > v2: Philippe took patches 1, 3 and 4. > > This is a re-write of what was: > [PATCH RFC 03/32] python//machine.py: remove bare except > [PATCH 2/4] python/machine.py: remove bare except > > It's a bit heavier handed, but it should address some of kwolf's > feedback from the RFC version. > > Applies straight to origin/master, ought to pass pylint and flake8: > >> cd ~/src/qemu/python/qemu >> pylint *.py >> flake8 *.py > > John Snow (3): > python/machine.py: consolidate _post_shutdown() > python/machine.py: refactor shutdown > python/machine.py: re-add sigkill warning suppression > > python/qemu/machine.py | 100 +++++++++++++++++++++++++++++------------ > 1 file changed, 71 insertions(+), 29 deletions(-) >
I had prepared: Thanks, applied to my python-next tree (including your diff in python/qemu/machine.py): https://gitlab.com/philmd/qemu/commits/python-next But I just noticed Cleber review comment asking for more testing, so I'm keeping this applied, but will delay the pull request since I have to re-run the testing. Phil.
