Re: [PATCH v2 2/2] gdbstub: do not split gdb_monitor_write payload

2019-12-13 Thread Damien Hedde
On 12/12/19 11:52 AM, Alex Bennée wrote: > > Damien Hedde writes: > >> On 12/11/19 7:59 PM, Alex Bennée wrote: >>> >>> Damien Hedde writes: >>> Since we can now send packets of arbitrary length: simplify gdb_monitor_write() and send the whole payload in one packet. >>> >>> Do w

Re: [PATCH v2 2/2] gdbstub: do not split gdb_monitor_write payload

2019-12-12 Thread Alex Bennée
Damien Hedde writes: > On 12/11/19 7:59 PM, Alex Bennée wrote: >> >> Damien Hedde writes: >> >>> Since we can now send packets of arbitrary length: >>> simplify gdb_monitor_write() and send the whole payload >>> in one packet. >> >> Do we know gdb won't barf on us. Does the negotiated max p

Re: [PATCH v2 2/2] gdbstub: do not split gdb_monitor_write payload

2019-12-12 Thread Damien Hedde
On 12/11/19 7:59 PM, Alex Bennée wrote: > > Damien Hedde writes: > >> Since we can now send packets of arbitrary length: >> simplify gdb_monitor_write() and send the whole payload >> in one packet. > > Do we know gdb won't barf on us. Does the negotiated max packet size > only apply to data

Re: [PATCH v2 2/2] gdbstub: do not split gdb_monitor_write payload

2019-12-12 Thread Damien Hedde
On 12/11/19 7:58 PM, Philippe Mathieu-Daudé wrote: > On 12/11/19 5:05 PM, Damien Hedde wrote: >> Since we can now send packets of arbitrary length: >> simplify gdb_monitor_write() and send the whole payload >> in one packet. > > While we can send arbitrary length on the wire, we advertise > Pac

Re: [PATCH v2 2/2] gdbstub: do not split gdb_monitor_write payload

2019-12-11 Thread Alex Bennée
Damien Hedde writes: > Since we can now send packets of arbitrary length: > simplify gdb_monitor_write() and send the whole payload > in one packet. Do we know gdb won't barf on us. Does the negotiated max packet size only apply to data sent to the gdbserver? > > Suggested-by: Luc Michel > S

Re: [PATCH v2 2/2] gdbstub: do not split gdb_monitor_write payload

2019-12-11 Thread Philippe Mathieu-Daudé
On 12/11/19 5:05 PM, Damien Hedde wrote: Since we can now send packets of arbitrary length: simplify gdb_monitor_write() and send the whole payload in one packet. While we can send arbitrary length on the wire, we advertise PacketSize=MAX_PACKET_LENGTH in handle_query_supported(). We can rai