Damien Hedde <damien.he...@greensocs.com> writes:
> Since we can now send packets of arbitrary length:
> simplify gdb_monitor_write() and send the whole payload
> in one packet.
Do we know gdb won't barf on us. Does the negotiated max packet size
only apply to data sent to the gdbserver?
>
> Suggested-by: Luc Michel <luc.mic...@greensocs.com>
> Signed-off-by: Damien Hedde <damien.he...@greensocs.com>
> ---
> gdbstub.c | 23 +++--------------------
> 1 file changed, 3 insertions(+), 20 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 93b26f1b86..ef999abee2 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -3200,28 +3200,11 @@ static void gdb_chr_event(void *opaque, int event)
> }
> }
>
> -static void gdb_monitor_output(GDBState *s, const char *msg, int len)
> -{
> - g_autoptr(GString) buf = g_string_new("O");
> - memtohex(buf, (uint8_t *)msg, len);
> - put_packet(buf->str);
> -}
> -
> static int gdb_monitor_write(Chardev *chr, const uint8_t *buf, int len)
> {
> - const char *p = (const char *)buf;
> - int max_sz;
> -
> - max_sz = (MAX_PACKET_LENGTH / 2) + 1;
> - for (;;) {
> - if (len <= max_sz) {
> - gdb_monitor_output(&gdbserver_state, p, len);
> - break;
> - }
> - gdb_monitor_output(&gdbserver_state, p, max_sz);
> - p += max_sz;
> - len -= max_sz;
> - }
> + g_autoptr(GString) hex_buf = g_string_new("O");
> + memtohex(hex_buf, buf, len);
> + put_packet(hex_buf->str);
> return len;
> }
--
Alex Bennée
