Re: [PATCH v2 06/22] target/loongarch: Add main translation routines

2021-07-26 Thread Richard Henderson
On 7/25/21 11:39 PM, Song Gao wrote: +void gen_base_offset_addr(TCGv addr, int base, int offset) +{ +    if (base == 0) { +    tcg_gen_movi_tl(addr, offset); +    } else if (offset == 0) { +    gen_load_gpr(addr, base); +    } else { +    tcg_gen_movi_tl(addr, offset); +    gen_op

Re: [PATCH v2 06/22] target/loongarch: Add main translation routines

2021-07-26 Thread Song Gao
Hi, Richard. On 07/23/2021 07:50 AM, Richard Henderson wrote: > On 7/20/21 11:53 PM, Song Gao wrote: >> +/* General purpose registers moves. */ >> +void gen_load_gpr(TCGv t, int reg) >> +{ >> +    if (reg == 0) { >> +    tcg_gen_movi_tl(t, 0); >> +    } else { >> +    tcg_gen_mov_tl(t, cpu

Re: [PATCH v2 06/22] target/loongarch: Add main translation routines

2021-07-22 Thread Richard Henderson
On 7/20/21 11:53 PM, Song Gao wrote: +/* General purpose registers moves. */ +void gen_load_gpr(TCGv t, int reg) +{ +if (reg == 0) { +tcg_gen_movi_tl(t, 0); +} else { +tcg_gen_mov_tl(t, cpu_gpr[reg]); +} +} Please have a look at https://patchew.org/QEMU/202107090426